From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756034AbYDBLFh (ORCPT ); Wed, 2 Apr 2008 07:05:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753052AbYDBLF2 (ORCPT ); Wed, 2 Apr 2008 07:05:28 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:52507 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752913AbYDBLF2 (ORCPT ); Wed, 2 Apr 2008 07:05:28 -0400 Subject: Re: GFP_ATOMIC page allocation failures. From: Peter Zijlstra To: David Miller Cc: kosaki.motohiro@jp.fujitsu.com, akpm@linux-foundation.org, csnook@redhat.com, davej@codemonkey.org.uk, nickpiggin@yahoo.com.au, linux-kernel@vger.kernel.org, netdev@vger.kernel.org In-Reply-To: <20080402.012406.246863209.davem@davemloft.net> References: <47F32789.2070703@redhat.com> <20080402005646.f8df1c1b.akpm@linux-foundation.org> <20080402171104.9591.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20080402.012406.246863209.davem@davemloft.net> Content-Type: text/plain Date: Wed, 02 Apr 2008 13:04:59 +0200 Message-Id: <1207134299.8514.771.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.21.92 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2008-04-02 at 01:24 -0700, David Miller wrote: > From: KOSAKI Motohiro > Date: Wed, 02 Apr 2008 17:17:50 +0900 > > > if network guys hope known-good driver should call > > __netdev_alloc_skb(dev, length, GFP_ATOMIC|__GFP_NOWARN) instead netdev_alloc_skb, > > I think we should make netdev_alloc_skb_nowarn. > > Giving it a proper name like this takes away the indication that this > situation is very special. > > Two leading underscores to an interface means "something special and > unusual requiring more careful consideration than usual is occuring > here." netdev_alloc_skb_nowarn() on the other hand, does not > convey this meaning. > > And we will have very few drivers that use this construct, thus it > really is best to handle things the way Andrew has. Would we not hope that most net drivers can handle {,net}dev_alloc_skb() failing? Otherwise we have some serious trouble.