public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: linux-kernel@vger.kernel.org, k-ueda@ct.jp.nec.com,
	j-nomura@ce.jp.nec.com, jens.axboe@oracle.com,
	zaitcev@redhat.com
Subject: Re: kernel BUG at drivers/block/ub.c:820!
Date: Thu, 03 Apr 2008 17:02:58 +0200	[thread overview]
Message-ID: <1207234978.9155.13.camel@localhost> (raw)
In-Reply-To: <47F4E694.4060103@panasas.com>

On Thu, 2008-04-03 at 17:15 +0300, Boaz Harrosh wrote:
> OK So first this confirms that for ages the ub.c driver was leaking
> BIO's
> on first connection. Just that it was never noticed before.
> 
> or that we have a BLOCK_PC at hand but before the 7d699baf patch
> we completed with - rq->hard_nr_sectors << 9 - where now
> blk_rq_bytes(rq)
> will return 218 which is less. Could you also put rq->hard_nr_sectors
> in the print above?
> 
> Did you mange to find what is that 218 bytes command. Put a WARN_ON(1)
> in ub_request_fn_1 for any command that has a blk_rq_bytes(rq) of 218
> so we'll see who issues these commands. And what is the real bug.

I've added a WARN_ON(blk_rq_bytes(rq) == 218) right before the
ub_submit_scsi in ub_request_fn_1. ub_end_rq still reports the odd size
but I get nothing from ub_request_fn_1. Interesting.

-- 
blue skies,
  Martin.

"Reality continues to ruin my life." - Calvin.



  reply	other threads:[~2008-04-03 15:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-03  8:42 kernel BUG at drivers/block/ub.c:820! Martin Schwidefsky
2008-04-03 11:32 ` Boaz Harrosh
2008-04-03 13:57   ` Martin Schwidefsky
2008-04-03 14:15     ` Boaz Harrosh
2008-04-03 15:02       ` Martin Schwidefsky [this message]
2008-04-03 16:08 ` Kiyoshi Ueda
2008-04-03 15:18   ` Martin Schwidefsky
2008-04-03 16:30     ` Pete Zaitcev
2008-04-03 17:36       ` Boaz Harrosh
2008-04-04  4:30         ` Andrew Morton
2008-04-04 15:29           ` Kiyoshi Ueda
2008-04-04 19:45             ` Pete Zaitcev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1207234978.9155.13.camel@localhost \
    --to=schwidefsky@de.ibm.com \
    --cc=bharrosh@panasas.com \
    --cc=j-nomura@ce.jp.nec.com \
    --cc=jens.axboe@oracle.com \
    --cc=k-ueda@ct.jp.nec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zaitcev@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox