From: Joe Perches <joe@perches.com>
To: Jason Baron <jbaron@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Randy Dunlap <randy.dunlap@oracle.com>,
mathieu.desnoyers@polymtl.ca
Subject: Re: [patch 1/3] dynamic printk - core infrastructure
Date: Fri, 04 Apr 2008 11:33:46 -0700 [thread overview]
Message-ID: <1207334026.23161.385.camel@localhost> (raw)
In-Reply-To: <20080404181308.GA14160@redhat.com>
On Fri, 2008-04-04 at 14:13 -0400, Jason Baron wrote:
> here is a re-spun patch incorporating comments from the thread.
> +#define dev_dbg(dev, format, arg...) do { \
> + if (unlikely(imv_read(dynamic_debug_on))) \
I think the use of unlikely here and in pr_debug is unnecessary.
> +static struct hlist_head file_table[FILE_TABLE_SIZE] =
> + { [0 ... FILE_TABLE_SIZE-1] = HLIST_HEAD_INIT };
> +static DECLARE_MUTEX(debug_list_mutex);
> +static int nr_entries;
Shouldn't this be a module_table?
I think that hashing may be an unnecessary optimization and
that there's no real need to use a limited FILE_TABLE_SIZE
at all. I think the most likely use cases for this facility
has either one or two modules being debugged or all modules
or no modules.
cheers, Joe
prev parent reply other threads:[~2008-04-04 18:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-01 19:49 [patch 1/3] dynamic printk - core infrastructure Jason Baron
2008-04-01 20:09 ` mws
2008-04-01 21:47 ` Randy Dunlap
2008-04-02 2:07 ` Joe Perches
2008-04-02 18:21 ` Jason Baron
2008-04-02 18:58 ` Joe Perches
2008-04-04 18:13 ` Jason Baron
2008-04-04 18:33 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207334026.23161.385.camel@localhost \
--to=joe@perches.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox