From: Soeren Sonnenburg <kernel@nn7.de>
To: Justin Mattock <justinmattock@gmail.com>
Cc: rpurdie@rpsys.net, Julien BLACHE <jb@jblache.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
"Rafael J\. Wysocki" <rjw@sisk.pl>
Subject: Re: 2.6.25 intended change: smc:kbd_backlight vs. smc::kbd_backlight ?
Date: Sat, 05 Apr 2008 07:32:36 +0200 [thread overview]
Message-ID: <1207373556.10237.2.camel@localhost> (raw)
In-Reply-To: <dd18b0c30804040812x76f99af7o99fa57c9a1ec10bc@mail.gmail.com>
On Fri, 2008-04-04 at 15:12 +0000, Justin Mattock wrote:
> Hello; I noticed this as well, you loose the greatest feature; the
> cool leds lights on the keyboard with the macbook pro,
> A solution that worked for me was to compile pommed from the source
> and edit kbd_backlight.h
> regards;
> Justin P. Mattock
Yeah, but it will not only affect pommed... and I don't see the
rationale of introducing :: to separate things... so I think we should
have another patch replacing the :: with ':' again to unbreak userspace
for 2.6.25.
Could someone more official please respond to this regression (CCing
Rafael to record it)
Soeren
> On Fri, Apr 4, 2008 at 6:54 AM, Soeren Sonnenburg <kernel@nn7.de> wrote:
> > On Wed, 2008-04-02 at 20:58 +0200, Soeren Sonnenburg wrote:
> > > Dear all,
> > >
> > > I am wondering whether the change from
> > >
> > > /sys/devices/platform/applesmc.768/leds/smc:kbd_backlight (2.6.24)
> > > /sys/devices/platform/applesmc.768/leds/smc::kbd_backlight (2.6.25)
> > >
> > > is intentional?
> > >
> > > I recognized that it breaks current userspace applications changing the
> > > keyboard background leds like pommed...
> >
> > OK it looks like commit 6c152beefbf90579d21afc4f7e075b1f801f9a75 from
> > Richard Purdie, 'leds: Standardise LED naming scheme' introduced this
> > change.
> >
> > Why do we need '::' instead of a single ':' (that would not have broken
> > things)?
> >
> > Also sometimes only a single ':' seperator is used like in
> > corgi:green:mail but e.g. not in clevo::mail ?!
> >
> > Soeren
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
> >
>
>
>
next prev parent reply other threads:[~2008-04-05 5:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 18:58 2.6.25 intended change: smc:kbd_backlight vs. smc::kbd_backlight ? Soeren Sonnenburg
2008-04-04 6:54 ` Soeren Sonnenburg
2008-04-04 15:12 ` Justin Mattock
2008-04-05 5:32 ` Soeren Sonnenburg [this message]
2008-04-05 6:44 ` Justin Mattock
2008-04-05 6:51 ` Soeren Sonnenburg
2008-04-05 10:42 ` Richard Purdie
2008-04-05 15:33 ` Soeren Sonnenburg
2008-04-05 16:22 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207373556.10237.2.camel@localhost \
--to=kernel@nn7.de \
--cc=jb@jblache.org \
--cc=justinmattock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).