From: Harvey Harrison <harvey.harrison@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Richard Purdie <rpurdie@rpsys.net>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lzo: fix possible typo in decompresor
Date: Thu, 10 Apr 2008 13:52:19 -0700 [thread overview]
Message-ID: <1207860739.22001.41.camel@brick> (raw)
In-Reply-To: <alpine.LFD.1.00.0804101346240.3143@woody.linux-foundation.org>
On Thu, 2008-04-10 at 13:49 -0700, Linus Torvalds wrote:
>
> On Thu, 10 Apr 2008, Harvey Harrison wrote:
> >
> > Shift of a le value seems strange, probably meant to shift the cpu-order
> > variable as in the prvious section of the switch statement.
>
> Hmm. This patch looks ObviouslyCorrect(tm), but it worries me that
> apparently the old broken code has been around since last July, and afaik
> it can never have worked on big-endian machines.
>
> So did nobody ever use it, or why hasn't this ever triggered? How did you
> find this? A sparse warning?
>
> Linus
When converting in tree users to my proposed unaligned byteswapping api.
See the 8 patch series posted today to linux-arch.
Harvey
next prev parent reply other threads:[~2008-04-10 20:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 20:38 [PATCH] lzo: fix possible typo in decompresor Harvey Harrison
2008-04-10 20:49 ` Linus Torvalds
2008-04-10 20:52 ` Harvey Harrison [this message]
2008-04-10 22:18 ` Richard Purdie
2008-04-10 22:22 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207860739.22001.41.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox