From: Peter Zijlstra <peterz@infradead.org>
To: Paul Menage <menage@google.com>
Cc: Miles Lane <miles.lane@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: 2.6.25-rc8-mm2 -- kernel/sched.c:8294: error: unknown field ‘read_uint’ specified in initializer
Date: Fri, 11 Apr 2008 20:55:24 +0200 [thread overview]
Message-ID: <1207940124.7427.1.camel@twins> (raw)
In-Reply-To: <6599ad830804111146k2c3db442y3708f95a3fbee83@mail.gmail.com>
On Fri, 2008-04-11 at 11:46 -0700, Paul Menage wrote:
> On Fri, Apr 11, 2008 at 9:55 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Fri, 2008-04-11 at 09:48 -0400, Miles Lane wrote:
> > > CC kernel/sched.o
> > > kernel/sched.c:8294: error: unknown field 'read_uint' specified in initializer
> > > kernel/sched.c:8294: warning: initialization makes integer from
> > > pointer without a cast
> > > kernel/sched.c:8295: error: unknown field 'write_uint' specified in initializer
> > > kernel/sched.c:8295: warning: initialization from incompatible pointer type
> >
> > someone mucked around with the cgroup api; this should fix it:
> >
> > Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > ---
> > diff --git a/kernel/sched.c b/kernel/sched.c
> > index 7119895..8b4e0b6 100644
> > --- a/kernel/sched.c
> > +++ b/kernel/sched.c
> > @@ -8291,8 +8291,8 @@ static struct cftype cpu_files[] = {
> > },
> > {
> > .name = "rt_period_us",
> > - .read_uint = cpu_rt_period_read_uint,
> > - .write_uint = cpu_rt_period_write_uint,
> > + .read_u64 = cpu_rt_period_read_uint,
> > + .write_u64 = cpu_rt_period_write_uint,
> > },
> > #endif
> >
>
> Sorry - this change was in my original API patch (plus renaming the
> read/write functions to have u64 suffices) but I think it collided
> with the git-sched instability around the end of February.
Yeah, no worries, I recognised it the moment I looked at it. This is
just a merge artefact from changes in different trees.
next prev parent reply other threads:[~2008-04-11 18:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 13:48 2.6.25-rc8-mm2 -- kernel/sched.c:8294: error: unknown field ‘read_uint’ specified in initializer Miles Lane
2008-04-11 13:55 ` Ingo Molnar
2008-04-11 15:29 ` Miles Lane
2008-04-11 15:47 ` Miles Lane
2008-04-11 16:55 ` Peter Zijlstra
2008-04-11 18:46 ` Paul Menage
2008-04-11 18:55 ` Peter Zijlstra [this message]
2008-04-12 4:24 ` Andrew Morton
2008-04-15 2:28 ` Miles Lane
2008-04-15 2:38 ` Andrew Morton
2008-04-15 3:55 ` Miles Lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207940124.7427.1.camel@twins \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=miles.lane@gmail.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox