From: "Alexander van Heukelum" <heukelum@fastmail.fm>
To: "Thomas Gleixner" <tglx@linutronix.de>
Cc: "Ingo Molnar" <mingo@elte.hu>,
"Alexander van Heukelum" <heukelum@mailshack.com>,
linux-kernel@vger.kernel.org
Subject: Re: x86: ppc fixes for find_first_bit
Date: Mon, 14 Apr 2008 18:48:39 +0200 [thread overview]
Message-ID: <1208191719.12568.1247788911@webmail.messagingengine.com> (raw)
Hello Thomas,
I see Ingo has applied three fixes to the x86-tree:
find_first_bit() ppc fix
powerpc: fix powerpc build
find_next_bit() fix
Could you please give some insight in what went wrong with
ppc and powerpc?
"find_first_bit() ppc fix" disables the use of find_first_bit
for every user of GENERIC_FIND_NEXT_BIT=y. It replaces it by a
macro to call find_next_bit with offset=0. It should be possible
for an arch to use GENERIC_FIND_NEXT_BIT=y and implement
find_first_bit by itself.
"powerpc: fix powerpc build" removes the private 'implementation'
of asm-generic/bitops/find.h. It seems correct code to me. What
was the problem here? If it is duplicate declarations, then
I would suggest putting #ifndef GENERIC_FIND_NEXT_BIT around
them.
"find_next_bit() fix" changes asm-generic/bitops/find.h to
declare find_next_bit only if CONFIG_GENERIC_FIND_NEXT_BIT=n.
That is indeed a good change. It would be better if this
file disappeared completely, though.
Greetings,
Alexander
--
Alexander van Heukelum
heukelum@fastmail.fm
--
http://www.fastmail.fm - One of many happy users:
http://www.fastmail.fm/docs/quotes.html
next reply other threads:[~2008-04-14 16:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 16:48 Alexander van Heukelum [this message]
2008-04-16 12:57 ` x86: ppc fixes for find_first_bit Ingo Molnar
2008-04-16 13:55 ` [PATCH] x86: fix find_next_bit breakage on ppc and powerpc Alexander van Heukelum
2008-04-16 14:40 ` Ingo Molnar
2008-04-16 15:03 ` Alexander van Heukelum
2008-04-16 22:55 ` Paul Mackerras
2008-04-17 9:04 ` Alexander van Heukelum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208191719.12568.1247788911@webmail.messagingengine.com \
--to=heukelum@fastmail.fm \
--cc=heukelum@mailshack.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox