From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757267AbYDNWse (ORCPT ); Mon, 14 Apr 2008 18:48:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755362AbYDNWr7 (ORCPT ); Mon, 14 Apr 2008 18:47:59 -0400 Received: from py-out-1112.google.com ([64.233.166.177]:58009 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754608AbYDNWr6 (ORCPT ); Mon, 14 Apr 2008 18:47:58 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding; b=VmfCul+PDa9NhR5cH6O1ciTnTTEtkISan4yaI2l5pI+06yoMFMLYWTa4Fn+dinNfmswUDaCwF16ge0T9DuNqQ4yogaD3QJBe0/MsFLXOuvxgH9UAa3TrDOUagMkcl6GPGhB9lQ4dzWnuTeG9JEW4H5otKL9cu7xeuU3OvwyEuz4= Subject: [PATCH-mm 02/15] char: Use get_unaligned_* helpers From: Harvey Harrison To: Andrew Morton Cc: LKML Content-Type: text/plain Date: Mon, 14 Apr 2008 15:47:57 -0700 Message-Id: <1208213277.11920.32.camel@brick> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove unnecessary temp variable from_buf in snsc_event.c Signed-off-by: Harvey Harrison --- drivers/char/rocket_int.h | 2 +- drivers/char/snsc_event.c | 10 +++------- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/char/rocket_int.h b/drivers/char/rocket_int.h index b01d381..143cc43 100644 --- a/drivers/char/rocket_int.h +++ b/drivers/char/rocket_int.h @@ -55,7 +55,7 @@ static inline void sOutW(unsigned short port, unsigned short value) static inline void out32(unsigned short port, Byte_t *p) { - u32 value = le32_to_cpu(get_unaligned((__le32 *)p)); + u32 value = get_unaligned_le32(p); #ifdef ROCKET_DEBUG_IO printk(KERN_DEBUG "out32(%x, %lx)...\n", port, value); #endif diff --git a/drivers/char/snsc_event.c b/drivers/char/snsc_event.c index 1b75b0b..31a7765 100644 --- a/drivers/char/snsc_event.c +++ b/drivers/char/snsc_event.c @@ -63,16 +63,13 @@ static int scdrv_parse_event(char *event, int *src, int *code, int *esp_code, char *desc) { char *desc_end; - __be32 from_buf; /* record event source address */ - from_buf = get_unaligned((__be32 *)event); - *src = be32_to_cpup(&from_buf); + *src = get_unaligned_be32(event); event += 4; /* move on to event code */ /* record the system controller's event code */ - from_buf = get_unaligned((__be32 *)event); - *code = be32_to_cpup(&from_buf); + *code = get_unaligned_be32(event); event += 4; /* move on to event arguments */ /* how many arguments are in the packet? */ @@ -86,8 +83,7 @@ scdrv_parse_event(char *event, int *src, int *code, int *esp_code, char *desc) /* not an integer argument, so give up */ return -1; } - from_buf = get_unaligned((__be32 *)event); - *esp_code = be32_to_cpup(&from_buf); + *esp_code = get_unaligned_be32(event); event += 4; /* parse out the event description */ -- 1.5.5.144.g3e42