From: Harvey Harrison <harvey.harrison@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: padlock-aes.c replace private copy of bit rotation routines
Date: Tue, 15 Apr 2008 15:23:06 -0700 [thread overview]
Message-ID: <1208298186.11920.93.camel@brick> (raw)
In-Reply-To: <20080415130541.4123b8a3.akpm@linux-foundation.org>
On Tue, 2008-04-15 at 13:05 -0700, Andrew Morton wrote:
> On Tue, 15 Apr 2008 12:16:03 -0700
> Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> > Use the generic kernel implementation of the bit-rotation routines.
> > The generic routines to not shift by mod 32, but all callers in the
> > file pass constant values less than 32 making this a non-issue.
> >
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > ---
> > drivers/crypto/padlock-aes.c | 19 +++----------------
>
> git-cryptodev.patch has taken a big chainsaw to the code which you're
> patching.
And after looking through cryptodev.git, this patch is indeed no longer
needed.
Harvey
prev parent reply other threads:[~2008-04-15 22:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-15 19:16 [PATCH] crypto: padlock-aes.c replace private copy of bit rotation routines Harvey Harrison
2008-04-15 20:05 ` Andrew Morton
2008-04-15 20:07 ` Harvey Harrison
2008-04-15 22:23 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208298186.11920.93.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox