From: Tom Zanussi <tzanussi@gmail.com>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Pekka J Enberg <penberg@cs.helsinki.fi>,
David Wilder <dwilder@us.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
systemtap-ml <systemtap@sources.redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -mm] relayfs: support larger relay buffer take 3
Date: Wed, 16 Apr 2008 23:05:28 -0500 [thread overview]
Message-ID: <1208405128.8701.42.camel@charm-linux> (raw)
In-Reply-To: <480658DC.6030507@redhat.com>
On Wed, 2008-04-16 at 15:51 -0400, Masami Hiramatsu wrote:
> Use vmalloc() and memset() instead of kcalloc() to allocate a page* array
> when the array size is bigger than one page. This enables relayfs to support
> bigger relay buffers than 64MB on 4k-page system, 512MB on 16k-page system.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
> ---
> Changes from take2 to take3:
> - Use struct page ** instead of struct page *.
> - move functions to the place before relay_mmap_buf.
> - add comments.
>
> This is useful for a 64-bit system which has a plenty of memory (tens of
> giga bytes) and a large kernel memory space.
>
> I tested it on x86-64 and ia64.
>
Hi,
Looks fine to me.
Reviewed-by: Tom Zanussi <tzanussi@gmail.com>
next prev parent reply other threads:[~2008-04-17 4:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-15 15:27 [PATCH -mm] relayfs: support larger relay buffer Masami Hiramatsu
2008-04-16 4:22 ` Tom Zanussi
2008-04-16 16:19 ` Masami Hiramatsu
2008-04-16 18:03 ` [PATCH -mm] relayfs: support larger relay buffer take 2 Masami Hiramatsu
2008-04-16 18:21 ` Pekka J Enberg
2008-04-16 18:34 ` Masami Hiramatsu
2008-04-16 19:51 ` [PATCH -mm] relayfs: support larger relay buffer take 3 Masami Hiramatsu
2008-04-16 19:54 ` Pekka Enberg
2008-04-16 20:48 ` Andrew Morton
2008-04-16 21:00 ` Masami Hiramatsu
2008-04-17 4:05 ` Tom Zanussi [this message]
2008-04-16 8:33 ` [PATCH -mm] relayfs: support larger relay buffer Pekka Enberg
2008-04-16 14:36 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208405128.8701.42.camel@charm-linux \
--to=tzanussi@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dwilder@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=penberg@cs.helsinki.fi \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox