From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6DE3C49ED9 for ; Thu, 12 Sep 2019 09:55:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7ACC214AF for ; Thu, 12 Sep 2019 09:55:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730845AbfILJzU (ORCPT ); Thu, 12 Sep 2019 05:55:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:52420 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730428AbfILJzT (ORCPT ); Thu, 12 Sep 2019 05:55:19 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id D7EDCB67E; Thu, 12 Sep 2019 09:55:17 +0000 (UTC) From: Thomas Renninger To: Abhishek Goel Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, shuah@kernel.org, Thomas Renninger Subject: Re: [PATCH] cpupower : Handle set and info subcommands for powerpc Date: Thu, 12 Sep 2019 11:54:08 +0200 Message-ID: <12087195.kFesu4gPPu@skinner.arch.suse.de> In-Reply-To: <20190911095424.49605-1-huntbag@linux.vnet.ibm.com> References: <20190911095424.49605-1-huntbag@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Abishek, On Wednesday, September 11, 2019 11:54:24 AM CEST Abhishek Goel wrote: > Cpupower tool has set and info options which are not being used by > POWER machines. For powerpc, we will return directly for these two > subcommands. This removes the ambiguous error message while using set > option in case of power systems. > > Signed-off-by: Abhishek Goel > --- > tools/power/cpupower/utils/cpupower-info.c | 5 +++++ > tools/power/cpupower/utils/cpupower-set.c | 5 +++++ > 2 files changed, 10 insertions(+) > > diff --git a/tools/power/cpupower/utils/cpupower-info.c > b/tools/power/cpupower/utils/cpupower-info.c index > 4c9d342b70ff..674b707a76af 100644 > --- a/tools/power/cpupower/utils/cpupower-info.c > +++ b/tools/power/cpupower/utils/cpupower-info.c > @@ -39,6 +39,11 @@ int cmd_info(int argc, char **argv) > } params = {}; > int ret = 0; > > + #ifdef __powerpc__ > + printf(_("Cannot read info as system does not support performance bias > setting\n")); + return 0; > + #endif > + Please do no do this. cpupower info is designed to show general information related to powersaving features of your CPU. For examle there has been (see changelog): cpupower: Remove mc and smt power aware scheduler info/settings These kernel interfaces got removed by: Unfortunately only -b (perf bias on Intel only) is left right now. So if you cut this out for Power you do not see anything and the cmd is useless. Which is a pity, but for now makes sense. Ideally you provide some tag/option which makes sense on power (e.g. whether run in OPAL mode and if provide some figures otherwise tell running in VM mode). But if this is cut out something like this should do the same and is more flexible: - Still allows additional cpupower info features for other CPUs later easily - Should also cover AMD or other non-perf bias supporting CPUs to exclude perf_bias setting/info If this one works for you, can you please re-submit with also handling the set cmd similar. If it works or you only slightly adjust, feel free to already add: Acked-by: Thomas Renninger Thanks! Thomas --- tools/power/cpupower/utils/cpupower-info.c.orig 2019-09-12 11:45:02.578568335 +0200 +++ tools/power/cpupower/utils/cpupower-info.c 2019-09-12 11:46:09.618571947 +0200 @@ -55,8 +55,11 @@ } }; - if (!params.params) + if (!params.params) { params.params = 0x7; + if !(cpupower_cpu_info.caps & CPUPOWER_CAP_PERF_BIAS) + params.perf_bias = 0; + } /* Default is: show output of CPU 0 only */ if (bitmask_isallclear(cpus_chosen))