Re: [PATCH 1/11] Add generic helpers for arch IPI function calls

Avi Kivity
2008-04-22T14:47:52Z

Peter Zijlstra wrote:
>> Perhaps we need a new flag for failable async IPIs (or better, API).
>> I'm pretty sure no one uses s_c_f_s() from irq disabled context on x86,
>> since it will WARN_ON(irqs_disabled()).
>>
>
> Yeah, no current users, but that doesn't say I don't want to add new
> ones ;-

I suggest having a new API for that, I dislike long tails of flag arguments.

smp_call_function_single_async()?

--
error compiling committee.c: too many arguments to function