Re: [PATCH 1/11] Add generic helpers for arch IPI function calls

Linus Torvalds
2008-04-22T15:00:15Z

On Tue, 22 Apr 2008, Linus Torvalds wrote:
>
> You forgot to free the "data" here? The waiter must also free the object,
> since now the callee does not.

Ahh. For the single case, the caller will have it on the stack.

But the smp_call_function_mask() case seems to leak these things.

How about just always doing the "wait" case on the stack? Also, I'd
suggest you get rid of the static allocation, and just turn it into a wait
case, so that you don't need *three* different allocation cases, just two.

Or am I missing something?

Linus