Re: [PATCH 1/11] Add generic helpers for arch IPI function calls

Peter Zijlstra
2008-04-22T14:45:10Z

On Tue, 2008-04-22 at 17:38 +0300, Avi Kivity wrote:
> Jens Axboe wrote:
> >> Introducing this fallback will make any usage from irq disabled context
> >> deadlock prone.
> >>
> >> I rather like the current interface.
> >>
> >
> > Hmm good point, I'll back that bit out again.
> >
>
> But then you need to fix all callers to handle errors.

Sure.

> Perhaps we need a new flag for failable async IPIs (or better, API).
> I'm pretty sure no one uses s_c_f_s() from irq disabled context on x86,
> since it will WARN_ON(irqs_disabled()).

Yeah, no current users, but that doesn't say I don't want to add new
ones ;-)