Re: [PATCH 3/11] powerpc: convert to generic helpers for IPI function calls

Paul Mackerras
2008-04-22T12:43:31Z

Jens Axboe writes:

> I touched on both of these points in the initial mail, but perhaps you
> missed it as I didn't CC everyone for the 0/11 part. I'll add the full
> explanation to the 1/11 patch as well.

OK, that would be fine. I didn't read right to the end of the 0/11
mail in detail, I admit. :)

Now that I have, I don't see anything about smp_send_stop trying to
get the interrupt sent off in a panic situation when some other cpu
might be stuck holding the lock (unless that's the "ipi_lock is a
little muddy" part, but that only talks about cpu onlining). That bit
looks to be powerpc-specific, added in commit e057d985 in December
2007, so perhaps a mention that that has gone away now in the
description for 3/11 would be good.

Regards,
Paul.