Re: [PATCH 0/11] Generic smp_call_function() and friends

Peter Zijlstra
2008-04-22T08:49:11Z

On Tue, 2008-04-22 at 09:57 +0200, Jens Axboe wrote:
> Hi,
>
> While working on the more scalable and faster
> smp_call_function_single(), the amount of arch duplicated code in there
> botherered me. So I started adding a generic kernel/smp.c helper that
> the archs could use instead.
>
> Arch code exports two helper functions:
>
> arch_send_call_function_single_ipi(cpu)
> Send call function single ipi to given cpu
> arch_send_call_function_ipi(cpumask)
> Send call function ipi to cpus in cpumask
>
> and then use the generic ipi interrupt helpers to execute the code. I
> converted most of the archs capable of SMP, I think only sparc and
> sparc64 are still missing. Archs set CONFIG_GENERIC_SMP_HELPERS if they
> wish to use the generic helpers for this.
>
> The end result is that we have unified code for handling ipi for
> function calls. Even with adding special handling for the single cpu
> function call, the diffstat is pretty nice (see below.

Real nice work Jens!