Re: [PATCH 1/4] capability: capability.h whitespace, syntax, and other cleanups

Serge E. Hallyn
2008-04-24T12:27:15Z

Quoting Eric Paris (eparis@redhat.com):
> On Wed, 2008-04-23 at 20:54 -0500, Serge E. Hallyn wrote:
> > Quoting eparis@redhat.com (eparis@redhat.com):
> > > From: Eric Paris <eparis@redhat.com>
> > >
> > > This patch changes capability.h to fix whitespace and syntax issues. Things that
> > > are fixed may include (does not not have to include)
> > >
> > > whitespace at end of lines
> > > spaces followed by tabs
> > > spaces used instead of tabs
> > > spacing around parenthesis
> > > location of { around structs and else clauses
> > > location of * in pointer declarations
> > > removal of initialization of static data to keep it in the right section
> > > useless {} in if statemetns
> > > useless checking for NULL before kfree
> > > fixing of the indentation depth of switch statements
> > > no assignments in if statements
> > > include spaces around , in function calls
> > > and any number of other things I forgot to mention
> >
> > Thanks. Looks fine other than the inexplicable (afaics)
> > jumping of the capability #s by one tab for CAP_NET_ADMIN
> > and then again from CAP_IPC_OWNER on.
>
> It just looks that way in the patch for things whose names are exactly
> that long because of the + at the beginning of the line pushing them
> over a tab column in your mailer. They are correct after the patch
> applies.
>
> > Hmm, well you also made some odd (inconsistent) tab+space choices at and
> > following cap_clear.
>
> Same thing. And I'll admit that it is a bit inconsistent, but a whole
> new tab just pushed things too far to the right and I didn't want to
> leave 8 spaces anywhere in the file. So that's what I came up with...
> I promise it looks nice in the end :)

Okay, sounds good - something needed to be done about those files in any
case. Thanks for doing that.

-serge