From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: make rt_sched_class, idle_sched_class static
Date: Fri, 25 Apr 2008 19:55:31 +0200 [thread overview]
Message-ID: <1209146131.1956.8.camel@lappy> (raw)
In-Reply-To: <1209145993.20088.16.camel@brick>
On Fri, 2008-04-25 at 10:53 -0700, Harvey Harrison wrote:
> The C files are included directly in sched.c, so they are
> effectively static.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> ---
> kernel/sched_idletask.c | 2 +-
> kernel/sched_rt.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched_idletask.c b/kernel/sched_idletask.c
> index 2bcafa3..3a4f92d 100644
> --- a/kernel/sched_idletask.c
> +++ b/kernel/sched_idletask.c
> @@ -99,7 +99,7 @@ static void prio_changed_idle(struct rq *rq, struct task_struct *p,
> /*
> * Simple, special scheduling class for the per-CPU idle tasks:
> */
> -const struct sched_class idle_sched_class = {
> +static const struct sched_class idle_sched_class = {
> /* .next is NULL */
> /* no enqueue/yield_task for idle tasks */
>
> diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
> index c2730a5..dcd6495 100644
> --- a/kernel/sched_rt.c
> +++ b/kernel/sched_rt.c
> @@ -1309,7 +1309,7 @@ static void set_curr_task_rt(struct rq *rq)
> p->se.exec_start = rq->clock;
> }
>
> -const struct sched_class rt_sched_class = {
> +static const struct sched_class rt_sched_class = {
> .next = &fair_sched_class,
> .enqueue_task = enqueue_task_rt,
> .dequeue_task = dequeue_task_rt,
next prev parent reply other threads:[~2008-04-25 17:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-25 17:53 [PATCH] sched: make rt_sched_class, idle_sched_class static Harvey Harrison
2008-04-25 17:55 ` Peter Zijlstra [this message]
2008-04-26 14:48 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209146131.1956.8.camel@lappy \
--to=a.p.zijlstra@chello.nl \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox