* [PATCH] sched: make rt_sched_class, idle_sched_class static
@ 2008-04-25 17:53 Harvey Harrison
2008-04-25 17:55 ` Peter Zijlstra
0 siblings, 1 reply; 3+ messages in thread
From: Harvey Harrison @ 2008-04-25 17:53 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar; +Cc: LKML
The C files are included directly in sched.c, so they are
effectively static.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
kernel/sched_idletask.c | 2 +-
kernel/sched_rt.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched_idletask.c b/kernel/sched_idletask.c
index 2bcafa3..3a4f92d 100644
--- a/kernel/sched_idletask.c
+++ b/kernel/sched_idletask.c
@@ -99,7 +99,7 @@ static void prio_changed_idle(struct rq *rq, struct task_struct *p,
/*
* Simple, special scheduling class for the per-CPU idle tasks:
*/
-const struct sched_class idle_sched_class = {
+static const struct sched_class idle_sched_class = {
/* .next is NULL */
/* no enqueue/yield_task for idle tasks */
diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
index c2730a5..dcd6495 100644
--- a/kernel/sched_rt.c
+++ b/kernel/sched_rt.c
@@ -1309,7 +1309,7 @@ static void set_curr_task_rt(struct rq *rq)
p->se.exec_start = rq->clock;
}
-const struct sched_class rt_sched_class = {
+static const struct sched_class rt_sched_class = {
.next = &fair_sched_class,
.enqueue_task = enqueue_task_rt,
.dequeue_task = dequeue_task_rt,
--
1.5.5.1.270.g89765
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sched: make rt_sched_class, idle_sched_class static
2008-04-25 17:53 [PATCH] sched: make rt_sched_class, idle_sched_class static Harvey Harrison
@ 2008-04-25 17:55 ` Peter Zijlstra
2008-04-26 14:48 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Peter Zijlstra @ 2008-04-25 17:55 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Ingo Molnar, LKML
On Fri, 2008-04-25 at 10:53 -0700, Harvey Harrison wrote:
> The C files are included directly in sched.c, so they are
> effectively static.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> ---
> kernel/sched_idletask.c | 2 +-
> kernel/sched_rt.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched_idletask.c b/kernel/sched_idletask.c
> index 2bcafa3..3a4f92d 100644
> --- a/kernel/sched_idletask.c
> +++ b/kernel/sched_idletask.c
> @@ -99,7 +99,7 @@ static void prio_changed_idle(struct rq *rq, struct task_struct *p,
> /*
> * Simple, special scheduling class for the per-CPU idle tasks:
> */
> -const struct sched_class idle_sched_class = {
> +static const struct sched_class idle_sched_class = {
> /* .next is NULL */
> /* no enqueue/yield_task for idle tasks */
>
> diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
> index c2730a5..dcd6495 100644
> --- a/kernel/sched_rt.c
> +++ b/kernel/sched_rt.c
> @@ -1309,7 +1309,7 @@ static void set_curr_task_rt(struct rq *rq)
> p->se.exec_start = rq->clock;
> }
>
> -const struct sched_class rt_sched_class = {
> +static const struct sched_class rt_sched_class = {
> .next = &fair_sched_class,
> .enqueue_task = enqueue_task_rt,
> .dequeue_task = dequeue_task_rt,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sched: make rt_sched_class, idle_sched_class static
2008-04-25 17:55 ` Peter Zijlstra
@ 2008-04-26 14:48 ` Ingo Molnar
0 siblings, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-04-26 14:48 UTC (permalink / raw)
To: Peter Zijlstra; +Cc: Harvey Harrison, LKML
* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> On Fri, 2008-04-25 at 10:53 -0700, Harvey Harrison wrote:
> > The C files are included directly in sched.c, so they are
> > effectively static.
> >
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
>
> Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
thanks, applied.
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-04-26 14:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-25 17:53 [PATCH] sched: make rt_sched_class, idle_sched_class static Harvey Harrison
2008-04-25 17:55 ` Peter Zijlstra
2008-04-26 14:48 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox