* [PATCH 00/24] Unify integer type definitions, and add fixed type constructor macros
@ 2008-04-24 23:05 H. Peter Anvin
[not found] ` <1209078352-7593-2-git-send-email-hpa@zytor.com>
` (2 more replies)
0 siblings, 3 replies; 70+ messages in thread
From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton
Cc: Linux Kernel Mailing List, Linux Arch Mailing List,
H. Peter Anvin
This patchset unifies the integer definitions across all the
<asm-*/types.h> files, replacing them with two asm-generic files, one
for the LL64 model (all 32-bit architectures plus x86-64) and one for
the L64 model (all other 64-bit architectures.)
The latter patches introduce constructor macros, similar to the C99
<inttypes.h> macros, e.g. U64_C(0x123456789abcdef), which produces the
same result as (u64)0x123456789abcdef but (a) is usable in the
preprocessor, (b) doesn't generate warnings, (c) is transparently
ignored for assembly.
The final patch uses said constructor macros to remove nuisance
warnings from kernel/time.c.
This patchset is also pullable as a git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/hpa/linux-2.6-inttypes.git
include/asm-alpha/types.h | 36 +---------------
include/asm-arm/types.h | 33 +-------------
include/asm-avr32/types.h | 32 +------------
include/asm-blackfin/types.h | 34 +-------------
include/asm-cris/types.h | 33 +-------------
include/asm-frv/types.h | 34 +-------------
include/asm-generic/Kbuild | 2 +
include/asm-generic/int-l64.h | 71 +++++++++++++++++++++++++++++
include/asm-generic/int-ll64.h | 76 ++++++++++++++++++++++++++++++++
include/asm-h8300/types.h | 33 +-------------
include/asm-ia64/types.h | 31 +------------
include/asm-m32r/types.h | 32 +------------
include/asm-m68k/types.h | 32 +-------------
include/asm-mips/types.h | 56 +++---------------------
include/asm-mn10300/types.h | 33 +-------------
include/asm-parisc/types.h | 33 +-------------
include/asm-powerpc/types.h | 48 +++-----------------
include/asm-s390/types.h | 48 +++-----------------
include/asm-sh/types.h | 34 +-------------
include/asm-sparc/types.h | 30 +------------
include/asm-sparc64/types.h | 30 +------------
include/asm-v850/types.h | 32 +-------------
include/asm-x86/types.h | 38 +---------------
include/asm-xtensa/types.h | 33 +-------------
kernel/time.c | 8 ++--
25 files changed, 201 insertions(+), 701 deletions(-)
^ permalink raw reply [flat|nested] 70+ messages in thread[parent not found: <1209078352-7593-2-git-send-email-hpa@zytor.com>]
* [PATCH 01/24] types: create <asm-generic/int-*.h> [not found] ` <1209078352-7593-2-git-send-email-hpa@zytor.com> @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 02/24] alpha: types: use <asm-generic/int-*.h> for the alpha architecture H. Peter Anvin 2008-04-25 18:27 ` [PATCH 01/24] types: create <asm-generic/int-*.h> Jan Engelhardt 2008-04-25 0:15 ` Lennert Buytenhek 1 sibling, 2 replies; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This creates two generic files with common integer definitions; one where 64 bits is "long" (most 64-bit architectures) and one where 64 bits is "long long" (all 32-bit architectures and x86-64.) Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-generic/Kbuild | 2 + include/asm-generic/int-l64.h | 51 ++++++++++++++++++++++++++++++++++++ include/asm-generic/int-ll64.h | 56 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 109 insertions(+), 0 deletions(-) create mode 100644 include/asm-generic/int-l64.h create mode 100644 include/asm-generic/int-ll64.h diff --git a/include/asm-generic/Kbuild b/include/asm-generic/Kbuild index c18110e..4c9932a 100644 --- a/include/asm-generic/Kbuild +++ b/include/asm-generic/Kbuild @@ -7,5 +7,7 @@ header-y += poll.h header-y += signal.h header-y += statfs.h +unifdef-y += int-l64.h +unifdef-y += int-ll64.h unifdef-y += resource.h unifdef-y += siginfo.h diff --git a/include/asm-generic/int-l64.h b/include/asm-generic/int-l64.h new file mode 100644 index 0000000..629b5a4 --- /dev/null +++ b/include/asm-generic/int-l64.h @@ -0,0 +1,51 @@ +/* + * asm-generic/int-l64.h + * + * Integer declarations for architectures which use "long" + * for 64-bit types. + */ + +#ifndef _ASM_GENERIC_INT_L64_H +#define _ASM_GENERIC_INT_L64_H + +#ifndef __ASSEMBLY__ +/* + * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the + * header files exported to user space + */ + +typedef __signed__ char __s8; +typedef unsigned char __u8; + +typedef __signed__ short __s16; +typedef unsigned short __u16; + +typedef __signed__ int __s32; +typedef unsigned int __u32; + +typedef __signed__ long __s64; +typedef unsigned long __u64; + +#endif /* __ASSEMBLY__ */ + +#ifdef __KERNEL__ + +#ifndef __ASSEMBLY__ + +typedef signed char s8; +typedef unsigned char u8; + +typedef signed short s16; +typedef unsigned short u16; + +typedef signed int s32; +typedef unsigned int u32; + +typedef signed long s64; +typedef unsigned long u64; + +#endif /* __ASSEMBLY__ */ + +#endif /* __KERNEL__ */ + +#endif /* _ASM_GENERIC_INT_L64_H */ diff --git a/include/asm-generic/int-ll64.h b/include/asm-generic/int-ll64.h new file mode 100644 index 0000000..1e5ffec --- /dev/null +++ b/include/asm-generic/int-ll64.h @@ -0,0 +1,56 @@ +/* + * asm-generic/int-ll64.h + * + * Integer declarations for architectures which use "long long" + * for 64-bit types. + */ + +#ifndef _ASM_GENERIC_INT_LL64_H +#define _ASM_GENERIC_INT_LL64_H + +#ifndef __ASSEMBLY__ +/* + * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the + * header files exported to user space + */ + +typedef __signed__ char __s8; +typedef unsigned char __u8; + +typedef __signed__ short __s16; +typedef unsigned short __u16; + +typedef __signed__ int __s32; +typedef unsigned int __u32; + +#ifdef __GNUC__ +__extension__ typedef __signed__ long long __s64; +__extension__ typedef unsigned long long __u64; +#elif defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L +typedef __signed__ long long __s64; +typedef unsigned long long __u64; +#endif + +#endif /* __ASSEMBLY__ */ + +#ifdef __KERNEL__ + +#ifndef __ASSEMBLY__ + +typedef signed char s8; +typedef unsigned char u8; + +typedef signed short s16; +typedef unsigned short u16; + +typedef signed int s32; +typedef unsigned int u32; + +typedef signed long long s64; +typedef unsigned long long u64; + +#endif /* __ASSEMBLY__ */ + +#endif /* __KERNEL__ */ + +#endif /* _ASM_GENERIC_INT_LL64_H */ -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 02/24] alpha: types: use <asm-generic/int-*.h> for the alpha architecture 2008-04-24 23:05 ` [PATCH 01/24] types: create <asm-generic/int-*.h> H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 2008-04-25 18:27 ` [PATCH 01/24] types: create <asm-generic/int-*.h> Jan Engelhardt 1 sibling, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, Richard Henderson, Ivan Kokshaysky This modifies <asm-alpha/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: Richard Henderson <rth@twiddle.net> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru> --- include/asm-alpha/types.h | 36 +----------------------------------- 1 files changed, 1 insertions(+), 35 deletions(-) diff --git a/include/asm-alpha/types.h b/include/asm-alpha/types.h index f571613..a9e34ca 100644 --- a/include/asm-alpha/types.h +++ b/include/asm-alpha/types.h @@ -8,28 +8,12 @@ * not a major issue. However, for interoperability, libraries still * need to be careful to avoid a name clashes. */ +#include <asm-generic/int-l64.h> #ifndef __ASSEMBLY__ typedef unsigned int umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -typedef __signed__ long __s64; -typedef unsigned long __u64; - #endif /* __ASSEMBLY__ */ /* @@ -39,23 +23,5 @@ typedef unsigned long __u64; #define BITS_PER_LONG 64 -#ifndef __ASSEMBLY__ - -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long s64; -typedef unsigned long u64; - -typedef u64 dma_addr_t; -typedef u64 dma64_addr_t; - -#endif /* __ASSEMBLY__ */ #endif /* __KERNEL__ */ #endif /* _ALPHA_TYPES_H */ -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 02/24] alpha: types: use <asm-generic/int-*.h> for the alpha architecture 2008-04-24 23:05 ` [PATCH 02/24] alpha: types: use <asm-generic/int-*.h> for the alpha architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 03/24] arm: types: use <asm-generic/int-*.h> for the arm architecture H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-alpha/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-alpha/types.h | 36 +----------------------------------- 1 files changed, 1 insertions(+), 35 deletions(-) diff --git a/include/asm-alpha/types.h b/include/asm-alpha/types.h index f571613..a9e34ca 100644 --- a/include/asm-alpha/types.h +++ b/include/asm-alpha/types.h @@ -8,28 +8,12 @@ * not a major issue. However, for interoperability, libraries still * need to be careful to avoid a name clashes. */ +#include <asm-generic/int-l64.h> #ifndef __ASSEMBLY__ typedef unsigned int umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -typedef __signed__ long __s64; -typedef unsigned long __u64; - #endif /* __ASSEMBLY__ */ /* @@ -39,23 +23,5 @@ typedef unsigned long __u64; #define BITS_PER_LONG 64 -#ifndef __ASSEMBLY__ - -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long s64; -typedef unsigned long u64; - -typedef u64 dma_addr_t; -typedef u64 dma64_addr_t; - -#endif /* __ASSEMBLY__ */ #endif /* __KERNEL__ */ #endif /* _ALPHA_TYPES_H */ -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 03/24] arm: types: use <asm-generic/int-*.h> for the arm architecture 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 2008-04-25 0:14 ` [PATCH 03/24] arm: types: use <asm-generic/int-*.h> for the arm architecture Lennert Buytenhek 0 siblings, 2 replies; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, Russell King, Lennert Buytenhek, Ben Dooks This modifies <asm-arm/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: Russell King <rmk@arm.linux.org.uk> Cc: Lennert Buytenhek <kernel@wantstofly.org> Cc: Ben Dooks <ben-linux@fluff.org> --- include/asm-arm/types.h | 33 ++------------------------------- 1 files changed, 2 insertions(+), 31 deletions(-) diff --git a/include/asm-arm/types.h b/include/asm-arm/types.h index 3141451..345df01 100644 --- a/include/asm-arm/types.h +++ b/include/asm-arm/types.h @@ -1,29 +1,12 @@ #ifndef __ASM_ARM_TYPES_H #define __ASM_ARM_TYPES_H +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* @@ -35,18 +18,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - /* Dma addresses are 32-bits wide. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 03/24] arm: types: use <asm-generic/int-*.h> for the arm architecture 2008-04-24 23:05 ` [PATCH 03/24] arm: types: use <asm-generic/int-*.h> for the arm architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 04/24] avr32: types: use <asm-generic/int-*.h> for the avr32 architecture H. Peter Anvin 2008-04-25 0:14 ` [PATCH 03/24] arm: types: use <asm-generic/int-*.h> for the arm architecture Lennert Buytenhek 1 sibling, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-arm/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-arm/types.h | 33 ++------------------------------- 1 files changed, 2 insertions(+), 31 deletions(-) diff --git a/include/asm-arm/types.h b/include/asm-arm/types.h index 3141451..345df01 100644 --- a/include/asm-arm/types.h +++ b/include/asm-arm/types.h @@ -1,29 +1,12 @@ #ifndef __ASM_ARM_TYPES_H #define __ASM_ARM_TYPES_H +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* @@ -35,18 +18,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - /* Dma addresses are 32-bits wide. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 04/24] avr32: types: use <asm-generic/int-*.h> for the avr32 architecture 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, Haavard Skinnemoen This modifies <asm-avr32/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: Haavard Skinnemoen <hskinnemoen@atmel.com> --- include/asm-avr32/types.h | 32 ++------------------------------ 1 files changed, 2 insertions(+), 30 deletions(-) diff --git a/include/asm-avr32/types.h b/include/asm-avr32/types.h index 8999a38..9cefda6 100644 --- a/include/asm-avr32/types.h +++ b/include/asm-avr32/types.h @@ -8,28 +8,12 @@ #ifndef __ASM_AVR32_TYPES_H #define __ASM_AVR32_TYPES_H +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* @@ -41,18 +25,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - /* Dma addresses are 32-bits wide. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 04/24] avr32: types: use <asm-generic/int-*.h> for the avr32 architecture 2008-04-24 23:05 ` [PATCH 04/24] avr32: types: use <asm-generic/int-*.h> for the avr32 architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 05/24] blackfin: types: use <asm-generic/int-*.h> for the blackfin architecture H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-avr32/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-avr32/types.h | 32 ++------------------------------ 1 files changed, 2 insertions(+), 30 deletions(-) diff --git a/include/asm-avr32/types.h b/include/asm-avr32/types.h index 8999a38..9cefda6 100644 --- a/include/asm-avr32/types.h +++ b/include/asm-avr32/types.h @@ -8,28 +8,12 @@ #ifndef __ASM_AVR32_TYPES_H #define __ASM_AVR32_TYPES_H +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* @@ -41,18 +25,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - /* Dma addresses are 32-bits wide. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 05/24] blackfin: types: use <asm-generic/int-*.h> for the blackfin architecture 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, Bryan Wu This modifies <asm-blackfin/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: Bryan Wu <cooloney@kernel.org> --- include/asm-blackfin/types.h | 34 ++-------------------------------- 1 files changed, 2 insertions(+), 32 deletions(-) diff --git a/include/asm-blackfin/types.h b/include/asm-blackfin/types.h index 9785a6d..8441cbc 100644 --- a/include/asm-blackfin/types.h +++ b/include/asm-blackfin/types.h @@ -8,30 +8,12 @@ * not a major issue. However, for interoperability, libraries still * need to be careful to avoid a name clashes. */ +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -/* HK0617 -- Changes to unsigned long temporarily */ -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* * These aren't exported outside the kernel to avoid name space clashes @@ -42,18 +24,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - /* Dma addresses are 32-bits wide. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 05/24] blackfin: types: use <asm-generic/int-*.h> for the blackfin architecture 2008-04-24 23:05 ` [PATCH 05/24] blackfin: types: use <asm-generic/int-*.h> for the blackfin architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 06/24] cris: types: use <asm-generic/int-*.h> for the cris architecture H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-blackfin/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-blackfin/types.h | 34 ++-------------------------------- 1 files changed, 2 insertions(+), 32 deletions(-) diff --git a/include/asm-blackfin/types.h b/include/asm-blackfin/types.h index 9785a6d..8441cbc 100644 --- a/include/asm-blackfin/types.h +++ b/include/asm-blackfin/types.h @@ -8,30 +8,12 @@ * not a major issue. However, for interoperability, libraries still * need to be careful to avoid a name clashes. */ +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -/* HK0617 -- Changes to unsigned long temporarily */ -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* * These aren't exported outside the kernel to avoid name space clashes @@ -42,18 +24,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - /* Dma addresses are 32-bits wide. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 06/24] cris: types: use <asm-generic/int-*.h> for the cris architecture 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, Mikael Starvik, Jesper Nilsson This modifies <asm-cris/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: Mikael Starvik <starvik@axis.com> Cc: Jesper Nilsson <jesper.nilsson@axis.com> --- include/asm-cris/types.h | 33 ++------------------------------- 1 files changed, 2 insertions(+), 31 deletions(-) diff --git a/include/asm-cris/types.h b/include/asm-cris/types.h index 5a21c42..5790262 100644 --- a/include/asm-cris/types.h +++ b/include/asm-cris/types.h @@ -1,29 +1,12 @@ #ifndef _ETRAX_TYPES_H #define _ETRAX_TYPES_H +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* @@ -35,18 +18,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - /* Dma addresses are 32-bits wide, just like our other addresses. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 06/24] cris: types: use <asm-generic/int-*.h> for the cris architecture 2008-04-24 23:05 ` [PATCH 06/24] cris: types: use <asm-generic/int-*.h> for the cris architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 07/24] frv: types: use <asm-generic/int-*.h> for the frv architecture H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-cris/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-cris/types.h | 33 ++------------------------------- 1 files changed, 2 insertions(+), 31 deletions(-) diff --git a/include/asm-cris/types.h b/include/asm-cris/types.h index 5a21c42..5790262 100644 --- a/include/asm-cris/types.h +++ b/include/asm-cris/types.h @@ -1,29 +1,12 @@ #ifndef _ETRAX_TYPES_H #define _ETRAX_TYPES_H +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* @@ -35,18 +18,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - /* Dma addresses are 32-bits wide, just like our other addresses. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 07/24] frv: types: use <asm-generic/int-*.h> for the frv architecture 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, David Howells This modifies <asm-frv/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: David Howells <dhowells@redhat.com> --- include/asm-frv/types.h | 34 ++-------------------------------- 1 files changed, 2 insertions(+), 32 deletions(-) diff --git a/include/asm-frv/types.h b/include/asm-frv/types.h index 767e5ed..613bf1e 100644 --- a/include/asm-frv/types.h +++ b/include/asm-frv/types.h @@ -12,29 +12,12 @@ #ifndef _ASM_TYPES_H #define _ASM_TYPES_H +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* @@ -46,19 +29,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ - -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - /* Dma addresses are 32-bits wide. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 07/24] frv: types: use <asm-generic/int-*.h> for the frv architecture 2008-04-24 23:05 ` [PATCH 07/24] frv: types: use <asm-generic/int-*.h> for the frv architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 08/24] h8300: types: use <asm-generic/int-*.h> for the h8300 architecture H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-frv/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-frv/types.h | 34 ++-------------------------------- 1 files changed, 2 insertions(+), 32 deletions(-) diff --git a/include/asm-frv/types.h b/include/asm-frv/types.h index 767e5ed..613bf1e 100644 --- a/include/asm-frv/types.h +++ b/include/asm-frv/types.h @@ -12,29 +12,12 @@ #ifndef _ASM_TYPES_H #define _ASM_TYPES_H +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* @@ -46,19 +29,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ - -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - /* Dma addresses are 32-bits wide. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 08/24] h8300: types: use <asm-generic/int-*.h> for the h8300 architecture 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, Yoshinori Sato This modifies <asm-h8300/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: Yoshinori Sato <ysato@users.sourceforge.jp> --- include/asm-h8300/types.h | 33 ++------------------------------- 1 files changed, 2 insertions(+), 31 deletions(-) diff --git a/include/asm-h8300/types.h b/include/asm-h8300/types.h index 56566e2..1287519 100644 --- a/include/asm-h8300/types.h +++ b/include/asm-h8300/types.h @@ -1,6 +1,8 @@ #ifndef _H8300_TYPES_H #define _H8300_TYPES_H +#include <asm-generic/int-ll64.h> + #if !defined(__ASSEMBLY__) /* @@ -14,41 +16,10 @@ typedef unsigned short umode_t; /* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - -/* * These aren't exported outside the kernel to avoid name space clashes */ #ifdef __KERNEL__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - #define BITS_PER_LONG 32 /* Dma addresses are 32-bits wide. */ -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 08/24] h8300: types: use <asm-generic/int-*.h> for the h8300 architecture 2008-04-24 23:05 ` [PATCH 08/24] h8300: types: use <asm-generic/int-*.h> for the h8300 architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 09/24] ia64: types: use <asm-generic/int-*.h> for the ia64 architecture H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-h8300/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-h8300/types.h | 33 ++------------------------------- 1 files changed, 2 insertions(+), 31 deletions(-) diff --git a/include/asm-h8300/types.h b/include/asm-h8300/types.h index 56566e2..1287519 100644 --- a/include/asm-h8300/types.h +++ b/include/asm-h8300/types.h @@ -1,6 +1,8 @@ #ifndef _H8300_TYPES_H #define _H8300_TYPES_H +#include <asm-generic/int-ll64.h> + #if !defined(__ASSEMBLY__) /* @@ -14,41 +16,10 @@ typedef unsigned short umode_t; /* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - -/* * These aren't exported outside the kernel to avoid name space clashes */ #ifdef __KERNEL__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - #define BITS_PER_LONG 32 /* Dma addresses are 32-bits wide. */ -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 09/24] ia64: types: use <asm-generic/int-*.h> for the ia64 architecture 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 2008-04-25 1:37 ` [PATCH 09/24] ia64: types: use <asm-generic/int-*.h> for the ia64 architecture Luck, Tony 0 siblings, 2 replies; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, Tony Luck This modifies <asm-ia64/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: Tony Luck <tony.luck@intel.com> --- include/asm-ia64/types.h | 31 ++----------------------------- 1 files changed, 2 insertions(+), 29 deletions(-) diff --git a/include/asm-ia64/types.h b/include/asm-ia64/types.h index 902850d..e36b371 100644 --- a/include/asm-ia64/types.h +++ b/include/asm-ia64/types.h @@ -13,6 +13,8 @@ * David Mosberger-Tang <davidm@hpl.hp.com>, Hewlett-Packard Co */ +#include <asm-generic/int-l64.h> + #ifdef __ASSEMBLY__ # define __IA64_UL(x) (x) # define __IA64_UL_CONST(x) x @@ -28,39 +30,10 @@ typedef unsigned int umode_t; /* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -typedef __signed__ long __s64; -typedef unsigned long __u64; - -/* * These aren't exported outside the kernel to avoid name space clashes */ # ifdef __KERNEL__ -typedef __s8 s8; -typedef __u8 u8; - -typedef __s16 s16; -typedef __u16 u16; - -typedef __s32 s32; -typedef __u32 u32; - -typedef __s64 s64; -typedef __u64 u64; - #define BITS_PER_LONG 64 /* DMA addresses are 64-bits wide, in general. */ -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 09/24] ia64: types: use <asm-generic/int-*.h> for the ia64 architecture 2008-04-24 23:05 ` [PATCH 09/24] ia64: types: use <asm-generic/int-*.h> for the ia64 architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 10/24] m32r: types: use <asm-generic/int-*.h> for the m32r architecture H. Peter Anvin 2008-04-25 1:37 ` [PATCH 09/24] ia64: types: use <asm-generic/int-*.h> for the ia64 architecture Luck, Tony 1 sibling, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-ia64/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-ia64/types.h | 31 ++----------------------------- 1 files changed, 2 insertions(+), 29 deletions(-) diff --git a/include/asm-ia64/types.h b/include/asm-ia64/types.h index 902850d..e36b371 100644 --- a/include/asm-ia64/types.h +++ b/include/asm-ia64/types.h @@ -13,6 +13,8 @@ * David Mosberger-Tang <davidm@hpl.hp.com>, Hewlett-Packard Co */ +#include <asm-generic/int-l64.h> + #ifdef __ASSEMBLY__ # define __IA64_UL(x) (x) # define __IA64_UL_CONST(x) x @@ -28,39 +30,10 @@ typedef unsigned int umode_t; /* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -typedef __signed__ long __s64; -typedef unsigned long __u64; - -/* * These aren't exported outside the kernel to avoid name space clashes */ # ifdef __KERNEL__ -typedef __s8 s8; -typedef __u8 u8; - -typedef __s16 s16; -typedef __u16 u16; - -typedef __s32 s32; -typedef __u32 u32; - -typedef __s64 s64; -typedef __u64 u64; - #define BITS_PER_LONG 64 /* DMA addresses are 64-bits wide, in general. */ -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 10/24] m32r: types: use <asm-generic/int-*.h> for the m32r architecture 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, Hirokazu Takata This modifies <asm-m32r/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: Hirokazu Takata <takata@linux-m32r.org> --- include/asm-m32r/types.h | 32 ++------------------------------ 1 files changed, 2 insertions(+), 30 deletions(-) diff --git a/include/asm-m32r/types.h b/include/asm-m32r/types.h index b64c166..bc9f7ff 100644 --- a/include/asm-m32r/types.h +++ b/include/asm-m32r/types.h @@ -1,28 +1,12 @@ #ifndef _ASM_M32R_TYPES_H #define _ASM_M32R_TYPES_H +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif #endif /* __ASSEMBLY__ */ /* @@ -34,18 +18,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - /* DMA addresses are 32-bits wide. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 10/24] m32r: types: use <asm-generic/int-*.h> for the m32r architecture 2008-04-24 23:05 ` [PATCH 10/24] m32r: types: use <asm-generic/int-*.h> for the m32r architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 11/24] m68k: types: use <asm-generic/int-*.h> for the m68k architecture H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-m32r/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-m32r/types.h | 32 ++------------------------------ 1 files changed, 2 insertions(+), 30 deletions(-) diff --git a/include/asm-m32r/types.h b/include/asm-m32r/types.h index b64c166..bc9f7ff 100644 --- a/include/asm-m32r/types.h +++ b/include/asm-m32r/types.h @@ -1,28 +1,12 @@ #ifndef _ASM_M32R_TYPES_H #define _ASM_M32R_TYPES_H +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif #endif /* __ASSEMBLY__ */ /* @@ -34,18 +18,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - /* DMA addresses are 32-bits wide. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 11/24] m68k: types: use <asm-generic/int-*.h> for the m68k architecture 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, Geert Uytterhoeven, Roman Zippel This modifies <asm-m68k/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Roman Zippel <zippel@linux-m68k.org> --- include/asm-m68k/types.h | 32 +------------------------------- 1 files changed, 1 insertions(+), 31 deletions(-) diff --git a/include/asm-m68k/types.h b/include/asm-m68k/types.h index c35c09d..6441cb5 100644 --- a/include/asm-m68k/types.h +++ b/include/asm-m68k/types.h @@ -8,30 +8,12 @@ * not a major issue. However, for interoperability, libraries still * need to be careful to avoid a name clashes. */ +#include <asm-generic/int-ll64.h> #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* @@ -43,18 +25,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - /* DMA addresses are always 32-bits wide */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 11/24] m68k: types: use <asm-generic/int-*.h> for the m68k architecture 2008-04-24 23:05 ` [PATCH 11/24] m68k: types: use <asm-generic/int-*.h> for the m68k architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 12/24] mips: types: use <asm-generic/int-*.h> for the mips architecture H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-m68k/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-m68k/types.h | 32 +------------------------------- 1 files changed, 1 insertions(+), 31 deletions(-) diff --git a/include/asm-m68k/types.h b/include/asm-m68k/types.h index c35c09d..6441cb5 100644 --- a/include/asm-m68k/types.h +++ b/include/asm-m68k/types.h @@ -8,30 +8,12 @@ * not a major issue. However, for interoperability, libraries still * need to be careful to avoid a name clashes. */ +#include <asm-generic/int-ll64.h> #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* @@ -43,18 +25,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - /* DMA addresses are always 32-bits wide */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 12/24] mips: types: use <asm-generic/int-*.h> for the mips architecture 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, Ralf Baechle This modifies <asm-mips/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: Ralf Baechle <ralf@linux-mips.org> --- include/asm-mips/types.h | 56 +++++----------------------------------------- 1 files changed, 6 insertions(+), 50 deletions(-) diff --git a/include/asm-mips/types.h b/include/asm-mips/types.h index 2dd147f..7a2ee4f 100644 --- a/include/asm-mips/types.h +++ b/include/asm-mips/types.h @@ -9,36 +9,16 @@ #ifndef _ASM_TYPES_H #define _ASM_TYPES_H +#if _MIPS_SZLONG == 64 +# include <asm-generic/int-l64.h> +#else +# include <asm-generic/int-ll64.h> +#endif + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if (_MIPS_SZLONG == 64) - -typedef __signed__ long __s64; -typedef unsigned long __u64; - -#else - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - #endif #endif /* __ASSEMBLY__ */ @@ -52,30 +32,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ - -typedef __signed char s8; -typedef unsigned char u8; - -typedef __signed short s16; -typedef unsigned short u16; - -typedef __signed int s32; -typedef unsigned int u32; - -#if (_MIPS_SZLONG == 64) - -typedef __signed__ long s64; -typedef unsigned long u64; - -#else - -#if defined(__GNUC__) && !defined(__STRICT_ANSI__) -typedef __signed__ long long s64; -typedef unsigned long long u64; -#endif - -#endif - #if (defined(CONFIG_HIGHMEM) && defined(CONFIG_64BIT_PHYS_ADDR)) \ || defined(CONFIG_64BIT) typedef u64 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 12/24] mips: types: use <asm-generic/int-*.h> for the mips architecture 2008-04-24 23:05 ` [PATCH 12/24] mips: types: use <asm-generic/int-*.h> for the mips architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 13/24] mn10300: types: use <asm-generic/int-*.h> for the mn10300 architecture H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-mips/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-mips/types.h | 56 +++++----------------------------------------- 1 files changed, 6 insertions(+), 50 deletions(-) diff --git a/include/asm-mips/types.h b/include/asm-mips/types.h index 2dd147f..7a2ee4f 100644 --- a/include/asm-mips/types.h +++ b/include/asm-mips/types.h @@ -9,36 +9,16 @@ #ifndef _ASM_TYPES_H #define _ASM_TYPES_H +#if _MIPS_SZLONG == 64 +# include <asm-generic/int-l64.h> +#else +# include <asm-generic/int-ll64.h> +#endif + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if (_MIPS_SZLONG == 64) - -typedef __signed__ long __s64; -typedef unsigned long __u64; - -#else - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - #endif #endif /* __ASSEMBLY__ */ @@ -52,30 +32,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ - -typedef __signed char s8; -typedef unsigned char u8; - -typedef __signed short s16; -typedef unsigned short u16; - -typedef __signed int s32; -typedef unsigned int u32; - -#if (_MIPS_SZLONG == 64) - -typedef __signed__ long s64; -typedef unsigned long u64; - -#else - -#if defined(__GNUC__) && !defined(__STRICT_ANSI__) -typedef __signed__ long long s64; -typedef unsigned long long u64; -#endif - -#endif - #if (defined(CONFIG_HIGHMEM) && defined(CONFIG_64BIT_PHYS_ADDR)) \ || defined(CONFIG_64BIT) typedef u64 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 13/24] mn10300: types: use <asm-generic/int-*.h> for the mn10300 architecture 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, David Howells, Koichi Yasutake This modifies <asm-mn10300/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: David Howells <dhowells@redhat.com> Cc: Koichi Yasutake <yasutake.koichi@jp.panasonic.com> --- include/asm-mn10300/types.h | 33 ++------------------------------- 1 files changed, 2 insertions(+), 31 deletions(-) diff --git a/include/asm-mn10300/types.h b/include/asm-mn10300/types.h index d40ea76..7b9f010 100644 --- a/include/asm-mn10300/types.h +++ b/include/asm-mn10300/types.h @@ -11,29 +11,12 @@ #ifndef _ASM_TYPES_H #define _ASM_TYPES_H +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) && !defined(__STRICT_ANSI__) -typedef __signed__ long long __s64; -typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* @@ -45,18 +28,6 @@ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - /* Dma addresses are 32-bits wide. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 13/24] mn10300: types: use <asm-generic/int-*.h> for the mn10300 architecture 2008-04-24 23:05 ` [PATCH 13/24] mn10300: types: use <asm-generic/int-*.h> for the mn10300 architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 14/24] parisc: types: use <asm-generic/int-*.h> for the parisc architecture H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-mn10300/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-mn10300/types.h | 33 ++------------------------------- 1 files changed, 2 insertions(+), 31 deletions(-) diff --git a/include/asm-mn10300/types.h b/include/asm-mn10300/types.h index d40ea76..7b9f010 100644 --- a/include/asm-mn10300/types.h +++ b/include/asm-mn10300/types.h @@ -11,29 +11,12 @@ #ifndef _ASM_TYPES_H #define _ASM_TYPES_H +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) && !defined(__STRICT_ANSI__) -typedef __signed__ long long __s64; -typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* @@ -45,18 +28,6 @@ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - /* Dma addresses are 32-bits wide. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 14/24] parisc: types: use <asm-generic/int-*.h> for the parisc architecture 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, Kyle McMartin, Matthew Wilcox, Grant Grundler This modifies <asm-parisc/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: Kyle McMartin <kyle@parisc-linux.org> Cc: Matthew Wilcox <matthew@wil.cx> Cc: Grant Grundler <grundler@parisc-linux.org> --- include/asm-parisc/types.h | 33 ++------------------------------- 1 files changed, 2 insertions(+), 31 deletions(-) diff --git a/include/asm-parisc/types.h b/include/asm-parisc/types.h index 56c8480..7f5a39b 100644 --- a/include/asm-parisc/types.h +++ b/include/asm-parisc/types.h @@ -1,29 +1,12 @@ #ifndef _PARISC_TYPES_H #define _PARISC_TYPES_H +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* @@ -41,18 +24,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - /* Dma addresses are 32-bits wide. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 14/24] parisc: types: use <asm-generic/int-*.h> for the parisc architecture 2008-04-24 23:05 ` [PATCH 14/24] parisc: types: use <asm-generic/int-*.h> for the parisc architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 15/24] powerpc: types: use <asm-generic/int-*.h> for the powerpc architecture H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-parisc/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-parisc/types.h | 33 ++------------------------------- 1 files changed, 2 insertions(+), 31 deletions(-) diff --git a/include/asm-parisc/types.h b/include/asm-parisc/types.h index 56c8480..7f5a39b 100644 --- a/include/asm-parisc/types.h +++ b/include/asm-parisc/types.h @@ -1,29 +1,12 @@ #ifndef _PARISC_TYPES_H #define _PARISC_TYPES_H +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* @@ -41,18 +24,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - /* Dma addresses are 32-bits wide. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 15/24] powerpc: types: use <asm-generic/int-*.h> for the powerpc architecture 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, Paul Mackerras, Anton Blanchard This modifies <asm-powerpc/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Anton Blanchard <anton@samba.org> --- include/asm-powerpc/types.h | 48 +++++------------------------------------- 1 files changed, 6 insertions(+), 42 deletions(-) diff --git a/include/asm-powerpc/types.h b/include/asm-powerpc/types.h index c243a6a..d3374bc 100644 --- a/include/asm-powerpc/types.h +++ b/include/asm-powerpc/types.h @@ -1,6 +1,12 @@ #ifndef _ASM_POWERPC_TYPES_H #define _ASM_POWERPC_TYPES_H +#ifdef __powerpc64__ +# include <asm-generic/int-l64.h> +#else +# include <asm-generic/int-ll64.h> +#endif + #ifndef __ASSEMBLY__ /* @@ -22,30 +28,6 @@ typedef unsigned int umode_t; typedef unsigned short umode_t; #endif -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#ifdef __powerpc64__ -typedef __signed__ long __s64; -typedef unsigned long __u64; -#else -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif -#endif /* __powerpc64__ */ - typedef struct { __u32 u[4]; } __attribute__((aligned(16))) __vector128; @@ -64,24 +46,6 @@ typedef struct { #ifndef __ASSEMBLY__ - -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -#ifdef __powerpc64__ -typedef signed long s64; -typedef unsigned long u64; -#else -typedef signed long long s64; -typedef unsigned long long u64; -#endif - typedef __vector128 vector128; /* Physical address used by some IO functions */ -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 15/24] powerpc: types: use <asm-generic/int-*.h> for the powerpc architecture 2008-04-24 23:05 ` [PATCH 15/24] powerpc: types: use <asm-generic/int-*.h> for the powerpc architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 16/24] s390: types: use <asm-generic/int-*.h> for the s390 architecture H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-powerpc/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-powerpc/types.h | 48 +++++------------------------------------- 1 files changed, 6 insertions(+), 42 deletions(-) diff --git a/include/asm-powerpc/types.h b/include/asm-powerpc/types.h index c243a6a..d3374bc 100644 --- a/include/asm-powerpc/types.h +++ b/include/asm-powerpc/types.h @@ -1,6 +1,12 @@ #ifndef _ASM_POWERPC_TYPES_H #define _ASM_POWERPC_TYPES_H +#ifdef __powerpc64__ +# include <asm-generic/int-l64.h> +#else +# include <asm-generic/int-ll64.h> +#endif + #ifndef __ASSEMBLY__ /* @@ -22,30 +28,6 @@ typedef unsigned int umode_t; typedef unsigned short umode_t; #endif -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#ifdef __powerpc64__ -typedef __signed__ long __s64; -typedef unsigned long __u64; -#else -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif -#endif /* __powerpc64__ */ - typedef struct { __u32 u[4]; } __attribute__((aligned(16))) __vector128; @@ -64,24 +46,6 @@ typedef struct { #ifndef __ASSEMBLY__ - -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -#ifdef __powerpc64__ -typedef signed long s64; -typedef unsigned long u64; -#else -typedef signed long long s64; -typedef unsigned long long u64; -#endif - typedef __vector128 vector128; /* Physical address used by some IO functions */ -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 16/24] s390: types: use <asm-generic/int-*.h> for the s390 architecture 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, Martin Schwidefsky, Heiko Carstens This modifies <asm-s390/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> --- include/asm-s390/types.h | 48 +++++---------------------------------------- 1 files changed, 6 insertions(+), 42 deletions(-) diff --git a/include/asm-s390/types.h b/include/asm-s390/types.h index 2c5879a..78dda03 100644 --- a/include/asm-s390/types.h +++ b/include/asm-s390/types.h @@ -9,34 +9,16 @@ #ifndef _S390_TYPES_H #define _S390_TYPES_H +#ifndef __s390x__ +# include <asm-generic/int-l64.h> +#else +# include <asm-generic/int-ll64.h> +#endif + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#ifndef __s390x__ -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif -#else /* __s390x__ */ -typedef __signed__ long __s64; -typedef unsigned long __u64; -#endif - /* A address type so that arithmetic can be done on it & it can be upgraded to 64 bit when necessary */ @@ -58,24 +40,6 @@ typedef __signed__ long saddr_t; #ifndef __ASSEMBLY__ - -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -#ifndef __s390x__ -typedef signed long long s64; -typedef unsigned long long u64; -#else /* __s390x__ */ -typedef signed long s64; -typedef unsigned long u64; -#endif /* __s390x__ */ - typedef u32 dma_addr_t; #ifndef __s390x__ -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 16/24] s390: types: use <asm-generic/int-*.h> for the s390 architecture 2008-04-24 23:05 ` [PATCH 16/24] s390: types: use <asm-generic/int-*.h> for the s390 architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 17/24] sh: types: use <asm-generic/int-*.h> for the sh architecture H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-s390/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-s390/types.h | 48 +++++---------------------------------------- 1 files changed, 6 insertions(+), 42 deletions(-) diff --git a/include/asm-s390/types.h b/include/asm-s390/types.h index 2c5879a..78dda03 100644 --- a/include/asm-s390/types.h +++ b/include/asm-s390/types.h @@ -9,34 +9,16 @@ #ifndef _S390_TYPES_H #define _S390_TYPES_H +#ifndef __s390x__ +# include <asm-generic/int-l64.h> +#else +# include <asm-generic/int-ll64.h> +#endif + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#ifndef __s390x__ -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif -#else /* __s390x__ */ -typedef __signed__ long __s64; -typedef unsigned long __u64; -#endif - /* A address type so that arithmetic can be done on it & it can be upgraded to 64 bit when necessary */ @@ -58,24 +40,6 @@ typedef __signed__ long saddr_t; #ifndef __ASSEMBLY__ - -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -#ifndef __s390x__ -typedef signed long long s64; -typedef unsigned long long u64; -#else /* __s390x__ */ -typedef signed long s64; -typedef unsigned long u64; -#endif /* __s390x__ */ - typedef u32 dma_addr_t; #ifndef __s390x__ -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 17/24] sh: types: use <asm-generic/int-*.h> for the sh architecture 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, Paul Mundt This modifies <asm-sh/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: Paul Mundt <lethal@linux-sh.org> --- include/asm-sh/types.h | 34 ++-------------------------------- 1 files changed, 2 insertions(+), 32 deletions(-) diff --git a/include/asm-sh/types.h b/include/asm-sh/types.h index a6e1d41..beea4e6 100644 --- a/include/asm-sh/types.h +++ b/include/asm-sh/types.h @@ -1,29 +1,12 @@ #ifndef __ASM_SH_TYPES_H #define __ASM_SH_TYPES_H +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* @@ -35,19 +18,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ - -typedef __signed__ char s8; -typedef unsigned char u8; - -typedef __signed__ short s16; -typedef unsigned short u16; - -typedef __signed__ int s32; -typedef unsigned int u32; - -typedef __signed__ long long s64; -typedef unsigned long long u64; - /* Dma addresses are 32-bits wide. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 17/24] sh: types: use <asm-generic/int-*.h> for the sh architecture 2008-04-24 23:05 ` [PATCH 17/24] sh: types: use <asm-generic/int-*.h> for the sh architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 18/24] sparc: types: use <asm-generic/int-*.h> for the sparc architecture H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-sh/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-sh/types.h | 34 ++-------------------------------- 1 files changed, 2 insertions(+), 32 deletions(-) diff --git a/include/asm-sh/types.h b/include/asm-sh/types.h index a6e1d41..beea4e6 100644 --- a/include/asm-sh/types.h +++ b/include/asm-sh/types.h @@ -1,29 +1,12 @@ #ifndef __ASM_SH_TYPES_H #define __ASM_SH_TYPES_H +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* @@ -35,19 +18,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ - -typedef __signed__ char s8; -typedef unsigned char u8; - -typedef __signed__ short s16; -typedef unsigned short u16; - -typedef __signed__ int s32; -typedef unsigned int u32; - -typedef __signed__ long long s64; -typedef unsigned long long u64; - /* Dma addresses are 32-bits wide. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 18/24] sparc: types: use <asm-generic/int-*.h> for the sparc architecture 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 2008-04-25 0:44 ` [PATCH 18/24] sparc: types: use <asm-generic/int-*.h> for the sparc architecture David Miller 0 siblings, 2 replies; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, William L. Irwin This modifies <asm-sparc/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: William L. Irwin <wli@holomorphy.com> --- include/asm-sparc/types.h | 30 +----------------------------- 1 files changed, 1 insertions(+), 29 deletions(-) diff --git a/include/asm-sparc/types.h b/include/asm-sparc/types.h index 42fc6ed..1b08ef8 100644 --- a/include/asm-sparc/types.h +++ b/include/asm-sparc/types.h @@ -3,34 +3,18 @@ #define _SPARC_TYPES_H /* - * _xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space. - */ - -/* * This file is never included by application software unless * explicitly requested (e.g., via linux/types.h) in which case the * application is Linux specific so (user-) name space pollution is * not a major issue. However, for interoperability, libraries still * need to be careful to avoid a name clashes. */ +#include <asm-generic/int-ll64.h> #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -typedef __signed__ long long __s64; -typedef unsigned long long __u64; - #endif /* __ASSEMBLY__ */ #ifdef __KERNEL__ @@ -39,18 +23,6 @@ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef __signed__ char s8; -typedef unsigned char u8; - -typedef __signed__ short s16; -typedef unsigned short u16; - -typedef __signed__ int s32; -typedef unsigned int u32; - -typedef __signed__ long long s64; -typedef unsigned long long u64; - typedef u32 dma_addr_t; typedef u32 dma64_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 18/24] sparc: types: use <asm-generic/int-*.h> for the sparc architecture 2008-04-24 23:05 ` [PATCH 18/24] sparc: types: use <asm-generic/int-*.h> for the sparc architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 19/24] sparc64: types: use <asm-generic/int-*.h> for the sparc64 architecture H. Peter Anvin 2008-04-25 0:44 ` [PATCH 18/24] sparc: types: use <asm-generic/int-*.h> for the sparc architecture David Miller 1 sibling, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-sparc/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-sparc/types.h | 30 +----------------------------- 1 files changed, 1 insertions(+), 29 deletions(-) diff --git a/include/asm-sparc/types.h b/include/asm-sparc/types.h index 42fc6ed..1b08ef8 100644 --- a/include/asm-sparc/types.h +++ b/include/asm-sparc/types.h @@ -3,34 +3,18 @@ #define _SPARC_TYPES_H /* - * _xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space. - */ - -/* * This file is never included by application software unless * explicitly requested (e.g., via linux/types.h) in which case the * application is Linux specific so (user-) name space pollution is * not a major issue. However, for interoperability, libraries still * need to be careful to avoid a name clashes. */ +#include <asm-generic/int-ll64.h> #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -typedef __signed__ long long __s64; -typedef unsigned long long __u64; - #endif /* __ASSEMBLY__ */ #ifdef __KERNEL__ @@ -39,18 +23,6 @@ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef __signed__ char s8; -typedef unsigned char u8; - -typedef __signed__ short s16; -typedef unsigned short u16; - -typedef __signed__ int s32; -typedef unsigned int u32; - -typedef __signed__ long long s64; -typedef unsigned long long u64; - typedef u32 dma_addr_t; typedef u32 dma64_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 19/24] sparc64: types: use <asm-generic/int-*.h> for the sparc64 architecture 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 2008-04-25 0:44 ` [PATCH 19/24] sparc64: types: use <asm-generic/int-*.h> for the sparc64 architecture David Miller 0 siblings, 2 replies; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, David S. Miller This modifies <asm-sparc64/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: David S. Miller <davem@davemloft.net> --- include/asm-sparc64/types.h | 30 +----------------------------- 1 files changed, 1 insertions(+), 29 deletions(-) diff --git a/include/asm-sparc64/types.h b/include/asm-sparc64/types.h index d0ee7f1..5dbe04f 100644 --- a/include/asm-sparc64/types.h +++ b/include/asm-sparc64/types.h @@ -9,28 +9,12 @@ * not a major issue. However, for interoperability, libraries still * need to be careful to avoid a name clashes. */ +#include <asm-generic/int-l64.h> #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * _xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space. - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -typedef __signed__ long __s64; -typedef unsigned long __u64; - #endif /* __ASSEMBLY__ */ #ifdef __KERNEL__ @@ -39,18 +23,6 @@ typedef unsigned long __u64; #ifndef __ASSEMBLY__ -typedef __signed__ char s8; -typedef unsigned char u8; - -typedef __signed__ short s16; -typedef unsigned short u16; - -typedef __signed__ int s32; -typedef unsigned int u32; - -typedef __signed__ long s64; -typedef unsigned long u64; - /* Dma addresses come in generic and 64-bit flavours. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 19/24] sparc64: types: use <asm-generic/int-*.h> for the sparc64 architecture 2008-04-24 23:05 ` [PATCH 19/24] sparc64: types: use <asm-generic/int-*.h> for the sparc64 architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 20/24] v850: types: use <asm-generic/int-*.h> for the v850 architecture H. Peter Anvin 2008-04-25 0:44 ` [PATCH 19/24] sparc64: types: use <asm-generic/int-*.h> for the sparc64 architecture David Miller 1 sibling, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-sparc64/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-sparc64/types.h | 30 +----------------------------- 1 files changed, 1 insertions(+), 29 deletions(-) diff --git a/include/asm-sparc64/types.h b/include/asm-sparc64/types.h index d0ee7f1..5dbe04f 100644 --- a/include/asm-sparc64/types.h +++ b/include/asm-sparc64/types.h @@ -9,28 +9,12 @@ * not a major issue. However, for interoperability, libraries still * need to be careful to avoid a name clashes. */ +#include <asm-generic/int-l64.h> #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * _xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space. - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -typedef __signed__ long __s64; -typedef unsigned long __u64; - #endif /* __ASSEMBLY__ */ #ifdef __KERNEL__ @@ -39,18 +23,6 @@ typedef unsigned long __u64; #ifndef __ASSEMBLY__ -typedef __signed__ char s8; -typedef unsigned char u8; - -typedef __signed__ short s16; -typedef unsigned short u16; - -typedef __signed__ int s32; -typedef unsigned int u32; - -typedef __signed__ long s64; -typedef unsigned long u64; - /* Dma addresses come in generic and 64-bit flavours. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 20/24] v850: types: use <asm-generic/int-*.h> for the v850 architecture 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 21/24] x86: types: use <asm-generic/int-*.h> for the x86 architecture H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-v850/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-v850/types.h | 32 +------------------------------- 1 files changed, 1 insertions(+), 31 deletions(-) diff --git a/include/asm-v850/types.h b/include/asm-v850/types.h index 284bda8..89f735e 100644 --- a/include/asm-v850/types.h +++ b/include/asm-v850/types.h @@ -10,28 +10,10 @@ * not a major issue. However, for interoperability, libraries still * need to be careful to avoid a name clashes. */ +#include <asm-generic/int-ll64.h> typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - #endif /* !__ASSEMBLY__ */ /* @@ -43,18 +25,6 @@ __extension__ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - /* Dma addresses are 32-bits wide. */ typedef u32 dma_addr_t; -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 21/24] x86: types: use <asm-generic/int-*.h> for the x86 architecture 2008-04-24 23:05 ` [PATCH 20/24] v850: types: use <asm-generic/int-*.h> for the v850 architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, Ingo Molnar, Thomas Gleixner This modifies <asm-x86/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Thomas Gleixner <tglx@linutronix.de> --- include/asm-x86/types.h | 38 ++------------------------------------ 1 files changed, 2 insertions(+), 36 deletions(-) diff --git a/include/asm-x86/types.h b/include/asm-x86/types.h index 63733f3..1ac80cd 100644 --- a/include/asm-x86/types.h +++ b/include/asm-x86/types.h @@ -1,34 +1,12 @@ #ifndef _ASM_X86_TYPES_H #define _ASM_X86_TYPES_H +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#ifdef __i386__ -# ifdef __GNUC__ -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -# endif -#else -typedef __signed__ long long __s64; -typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* @@ -44,18 +22,6 @@ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - typedef u64 dma64_addr_t; #if defined(CONFIG_X86_64) || defined(CONFIG_HIGHMEM64G) /* DMA addresses come in 32-bit and 64-bit flavours. */ -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 21/24] x86: types: use <asm-generic/int-*.h> for the x86 architecture 2008-04-24 23:05 ` [PATCH 21/24] x86: types: use <asm-generic/int-*.h> for the x86 architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 22/24] xtensa: types: use <asm-generic/int-*.h> for the xtensa architecture H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-x86/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-x86/types.h | 38 ++------------------------------------ 1 files changed, 2 insertions(+), 36 deletions(-) diff --git a/include/asm-x86/types.h b/include/asm-x86/types.h index 63733f3..1ac80cd 100644 --- a/include/asm-x86/types.h +++ b/include/asm-x86/types.h @@ -1,34 +1,12 @@ #ifndef _ASM_X86_TYPES_H #define _ASM_X86_TYPES_H +#include <asm-generic/int-ll64.h> + #ifndef __ASSEMBLY__ typedef unsigned short umode_t; -/* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#ifdef __i386__ -# ifdef __GNUC__ -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -# endif -#else -typedef __signed__ long long __s64; -typedef unsigned long long __u64; -#endif - #endif /* __ASSEMBLY__ */ /* @@ -44,18 +22,6 @@ typedef unsigned long long __u64; #ifndef __ASSEMBLY__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long long s64; -typedef unsigned long long u64; - typedef u64 dma64_addr_t; #if defined(CONFIG_X86_64) || defined(CONFIG_HIGHMEM64G) /* DMA addresses come in 32-bit and 64-bit flavours. */ -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 22/24] xtensa: types: use <asm-generic/int-*.h> for the xtensa architecture 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin, Chris Zankel This modifies <asm-xtensa/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Cc: Chris Zankel <chris@zankel.net> --- include/asm-xtensa/types.h | 33 +-------------------------------- 1 files changed, 1 insertions(+), 32 deletions(-) diff --git a/include/asm-xtensa/types.h b/include/asm-xtensa/types.h index b27d841..c89569a 100644 --- a/include/asm-xtensa/types.h +++ b/include/asm-xtensa/types.h @@ -11,6 +11,7 @@ #ifndef _XTENSA_TYPES_H #define _XTENSA_TYPES_H +#include <asm-generic/int-ll64.h> #ifdef __ASSEMBLY__ # define __XTENSA_UL(x) (x) @@ -25,42 +26,10 @@ typedef unsigned short umode_t; /* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - -/* * These aren't exported outside the kernel to avoid name space clashes */ #ifdef __KERNEL__ -typedef __signed__ char s8; -typedef unsigned char u8; - -typedef __signed__ short s16; -typedef unsigned short u16; - -typedef __signed__ int s32; -typedef unsigned int u32; - -typedef __signed__ long long s64; -typedef unsigned long long u64; - - #define BITS_PER_LONG 32 /* Dma addresses are 32-bits wide. */ -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 22/24] xtensa: types: use <asm-generic/int-*.h> for the xtensa architecture 2008-04-24 23:05 ` [PATCH 22/24] xtensa: types: use <asm-generic/int-*.h> for the xtensa architecture H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 23/24] types: add C99-style constructors to <asm-generic/int-*.h> H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin This modifies <asm-xtensa/types.h> to use the <asm-generic/int-*.h> generic include files. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-xtensa/types.h | 33 +-------------------------------- 1 files changed, 1 insertions(+), 32 deletions(-) diff --git a/include/asm-xtensa/types.h b/include/asm-xtensa/types.h index b27d841..c89569a 100644 --- a/include/asm-xtensa/types.h +++ b/include/asm-xtensa/types.h @@ -11,6 +11,7 @@ #ifndef _XTENSA_TYPES_H #define _XTENSA_TYPES_H +#include <asm-generic/int-ll64.h> #ifdef __ASSEMBLY__ # define __XTENSA_UL(x) (x) @@ -25,42 +26,10 @@ typedef unsigned short umode_t; /* - * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the - * header files exported to user space - */ - -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) -__extension__ typedef __signed__ long long __s64; -__extension__ typedef unsigned long long __u64; -#endif - -/* * These aren't exported outside the kernel to avoid name space clashes */ #ifdef __KERNEL__ -typedef __signed__ char s8; -typedef unsigned char u8; - -typedef __signed__ short s16; -typedef unsigned short u16; - -typedef __signed__ int s32; -typedef unsigned int u32; - -typedef __signed__ long long s64; -typedef unsigned long long u64; - - #define BITS_PER_LONG 32 /* Dma addresses are 32-bits wide. */ -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 23/24] types: add C99-style constructors to <asm-generic/int-*.h> 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 2008-04-24 23:05 ` [PATCH 24/24] Use U64_C() instead of casts in kernel/time.c H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin Add C99-style constructor macros for fixed types to <asm-generic/int-*.h>. Since Linux uses names like "u64" instead of "uint64_t", the constructor macros are called U64_C() instead of UINT64_C() and so forth. These macros allow specific sizes to be specified as U64_C(0x123456789abcdef), without gcc issuing warnings as it will if one writes (u64)0x123456789abcdef. When used from assembly, these macros pass their argument unchanged. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- include/asm-generic/int-l64.h | 20 ++++++++++++++++++++ include/asm-generic/int-ll64.h | 20 ++++++++++++++++++++ 2 files changed, 40 insertions(+), 0 deletions(-) diff --git a/include/asm-generic/int-l64.h b/include/asm-generic/int-l64.h index 629b5a4..2af9b75 100644 --- a/include/asm-generic/int-l64.h +++ b/include/asm-generic/int-l64.h @@ -44,6 +44,26 @@ typedef unsigned int u32; typedef signed long s64; typedef unsigned long u64; +#define S8_C(x) x +#define U8_C(x) x ## U +#define S16_C(x) x +#define U16_C(x) x ## U +#define S32_C(x) x +#define U32_C(x) x ## U +#define S64_C(x) x ## L +#define U64_C(x) x ## UL + +#else /* __ASSEMBLY__ */ + +#define S8_C(x) x +#define U8_C(x) x +#define S16_C(x) x +#define U16_C(x) x +#define S32_C(x) x +#define U32_C(x) x +#define S64_C(x) x +#define U64_C(x) x + #endif /* __ASSEMBLY__ */ #endif /* __KERNEL__ */ diff --git a/include/asm-generic/int-ll64.h b/include/asm-generic/int-ll64.h index 1e5ffec..2609489 100644 --- a/include/asm-generic/int-ll64.h +++ b/include/asm-generic/int-ll64.h @@ -49,6 +49,26 @@ typedef unsigned int u32; typedef signed long long s64; typedef unsigned long long u64; +#define S8_C(x) x +#define U8_C(x) x ## U +#define S16_C(x) x +#define U16_C(x) x ## U +#define S32_C(x) x +#define U32_C(x) x ## U +#define S64_C(x) x ## LL +#define U64_C(x) x ## ULL + +#else /* __ASSEMBLY__ */ + +#define S8_C(x) x +#define U8_C(x) x +#define S16_C(x) x +#define U16_C(x) x +#define S32_C(x) x +#define U32_C(x) x +#define S64_C(x) x +#define U64_C(x) x + #endif /* __ASSEMBLY__ */ #endif /* __KERNEL__ */ -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* [PATCH 24/24] Use U64_C() instead of casts in kernel/time.c 2008-04-24 23:05 ` [PATCH 23/24] types: add C99-style constructors to <asm-generic/int-*.h> H. Peter Anvin @ 2008-04-24 23:05 ` H. Peter Anvin 0 siblings, 0 replies; 70+ messages in thread From: H. Peter Anvin @ 2008-04-24 23:05 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin Use the new U64_C() constructor macro instead of using casts for constants in kernel/time.c. This avoids warnings with some gcc versions. This resolves Bugzilla 10153. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- kernel/time.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/time.c b/kernel/time.c index 35d373a..519822b 100644 --- a/kernel/time.c +++ b/kernel/time.c @@ -244,7 +244,7 @@ unsigned int inline jiffies_to_msecs(const unsigned long j) return (j + (HZ / MSEC_PER_SEC) - 1)/(HZ / MSEC_PER_SEC); #else # if BITS_PER_LONG == 32 - return ((u64)HZ_TO_MSEC_MUL32 * j) >> HZ_TO_MSEC_SHR32; + return (U64_C(HZ_TO_MSEC_MUL32) * j) >> HZ_TO_MSEC_SHR32; # else return (j * HZ_TO_MSEC_NUM) / HZ_TO_MSEC_DEN; # endif @@ -260,7 +260,7 @@ unsigned int inline jiffies_to_usecs(const unsigned long j) return (j + (HZ / USEC_PER_SEC) - 1)/(HZ / USEC_PER_SEC); #else # if BITS_PER_LONG == 32 - return ((u64)HZ_TO_USEC_MUL32 * j) >> HZ_TO_USEC_SHR32; + return (U64_C(HZ_TO_USEC_MUL32) * j) >> HZ_TO_USEC_SHR32; # else return (j * HZ_TO_USEC_NUM) / HZ_TO_USEC_DEN; # endif @@ -470,7 +470,7 @@ unsigned long msecs_to_jiffies(const unsigned int m) if (HZ > MSEC_PER_SEC && m > jiffies_to_msecs(MAX_JIFFY_OFFSET)) return MAX_JIFFY_OFFSET; - return ((u64)MSEC_TO_HZ_MUL32 * m + MSEC_TO_HZ_ADJ32) + return (U64_C(MSEC_TO_HZ_MUL32) * m + MSEC_TO_HZ_ADJ32) >> MSEC_TO_HZ_SHR32; #endif } @@ -485,7 +485,7 @@ unsigned long usecs_to_jiffies(const unsigned int u) #elif HZ > USEC_PER_SEC && !(HZ % USEC_PER_SEC) return u * (HZ / USEC_PER_SEC); #else - return ((u64)USEC_TO_HZ_MUL32 * u + USEC_TO_HZ_ADJ32) + return (U64_C(USEC_TO_HZ_MUL32) * u + USEC_TO_HZ_ADJ32) >> USEC_TO_HZ_SHR32; #endif } -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* Re: [PATCH 19/24] sparc64: types: use <asm-generic/int-*.h> for the sparc64 architecture 2008-04-24 23:05 ` [PATCH 19/24] sparc64: types: use <asm-generic/int-*.h> for the sparc64 architecture H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-25 0:44 ` David Miller 1 sibling, 0 replies; 70+ messages in thread From: David Miller @ 2008-04-25 0:44 UTC (permalink / raw) To: hpa; +Cc: torvalds, akpm, linux-kernel, linux-arch From: "H. Peter Anvin" <hpa@zytor.com> Date: Thu, 24 Apr 2008 16:05:44 -0700 > This modifies <asm-sparc64/types.h> to use the <asm-generic/int-*.h> > generic include files. > > Signed-off-by: H. Peter Anvin <hpa@zytor.com> Acked-by: David S. Miller <davem@davemloft.net> ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 18/24] sparc: types: use <asm-generic/int-*.h> for the sparc architecture 2008-04-24 23:05 ` [PATCH 18/24] sparc: types: use <asm-generic/int-*.h> for the sparc architecture H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-25 0:44 ` David Miller 1 sibling, 0 replies; 70+ messages in thread From: David Miller @ 2008-04-25 0:44 UTC (permalink / raw) To: hpa; +Cc: torvalds, akpm, linux-kernel, linux-arch, wli From: "H. Peter Anvin" <hpa@zytor.com> Date: Thu, 24 Apr 2008 16:05:42 -0700 > This modifies <asm-sparc/types.h> to use the <asm-generic/int-*.h> > generic include files. > > Signed-off-by: H. Peter Anvin <hpa@zytor.com> Signed-off-by: David S. Miller <davem@davemloft.net> ^ permalink raw reply [flat|nested] 70+ messages in thread
* RE: [PATCH 09/24] ia64: types: use <asm-generic/int-*.h> for the ia64 architecture 2008-04-24 23:05 ` [PATCH 09/24] ia64: types: use <asm-generic/int-*.h> for the ia64 architecture H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-25 1:37 ` Luck, Tony 2008-04-25 3:42 ` H. Peter Anvin 2008-04-25 4:10 ` [PATCH 24/24] Use U64_C() instead of casts in kernel/time.c H. Peter Anvin 1 sibling, 2 replies; 70+ messages in thread From: Luck, Tony @ 2008-04-25 1:37 UTC (permalink / raw) To: H. Peter Anvin, Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List I get an error while building the ia64 sim_defconfig (which uses CONFIG_HZ=32) kernel/time.c: In function `msecs_to_jiffies': kernel/time.c:472: error: `MSEC_TO_HZ_MUL32UL' undeclared (first use in this function) kernel/time.c:472: error: (Each undeclared identifier is reported only once kernel/time.c:472: error: for each function it appears in.) The generated timeconst.h has: #define MSEC_TO_HZ_MUL32 0x83126e98 So some weird cpp thing happened and the UL got concatenated before the MSEC_TO_HZ_MUL32 was swapped out for its defined value. All the rest of the ia64 configs build ok. -Tony ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 09/24] ia64: types: use <asm-generic/int-*.h> for the ia64 architecture 2008-04-25 1:37 ` [PATCH 09/24] ia64: types: use <asm-generic/int-*.h> for the ia64 architecture Luck, Tony @ 2008-04-25 3:42 ` H. Peter Anvin 2008-04-25 4:10 ` [PATCH 24/24] Use U64_C() instead of casts in kernel/time.c H. Peter Anvin 1 sibling, 0 replies; 70+ messages in thread From: H. Peter Anvin @ 2008-04-25 3:42 UTC (permalink / raw) To: Luck, Tony Cc: Linus Torvalds, Andrew Morton, Linux Kernel Mailing List, Linux Arch Mailing List Luck, Tony wrote: > I get an error while building the ia64 sim_defconfig (which > uses CONFIG_HZ=32) > > kernel/time.c: In function `msecs_to_jiffies': > kernel/time.c:472: error: `MSEC_TO_HZ_MUL32UL' undeclared (first use in this function) > kernel/time.c:472: error: (Each undeclared identifier is reported only once > kernel/time.c:472: error: for each function it appears in.) > > > The generated timeconst.h has: > #define MSEC_TO_HZ_MUL32 0x83126e98 > > So some weird cpp thing happened and the UL got concatenated > before the MSEC_TO_HZ_MUL32 was swapped out for its defined > value. > > All the rest of the ia64 configs build ok. > OK... I'm clearly having a bad day... not only is the last patch in the series (the kernel/time.c stuff) just plain broken, but I ran the wrong test battery on it. I will fix it up and post a replacement patch. -hpa ^ permalink raw reply [flat|nested] 70+ messages in thread
* [PATCH 24/24] Use U64_C() instead of casts in kernel/time.c 2008-04-25 1:37 ` [PATCH 09/24] ia64: types: use <asm-generic/int-*.h> for the ia64 architecture Luck, Tony 2008-04-25 3:42 ` H. Peter Anvin @ 2008-04-25 4:10 ` H. Peter Anvin 2008-04-25 4:44 ` Luck, Tony 1 sibling, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-25 4:10 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton, Tony Luck Cc: Linux Kernel Mailing List, Linux Arch Mailing List, H. Peter Anvin Use the new U64_C() constructor macro instead of using casts for constants in kernel/time.c. This avoids warnings with some gcc versions. Note that since pasting has priority over macro resolution, the header file generation is modified to have suffixed versions of all the generated values. This resolves Bugzilla 10153. Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- kernel/time.c | 8 ++++---- kernel/timeconst.pl | 21 ++++++++++++++++----- 2 files changed, 20 insertions(+), 9 deletions(-) This is the corrected version of this patch. My apologies. The git repository has also been corrected: git://git.kernel.org/pub/scm/linux/kernel/git/hpa/linux-2.6-inttypes.git diff --git a/kernel/time.c b/kernel/time.c index 35d373a..652fd4f 100644 --- a/kernel/time.c +++ b/kernel/time.c @@ -244,7 +244,7 @@ unsigned int inline jiffies_to_msecs(const unsigned long j) return (j + (HZ / MSEC_PER_SEC) - 1)/(HZ / MSEC_PER_SEC); #else # if BITS_PER_LONG == 32 - return ((u64)HZ_TO_MSEC_MUL32 * j) >> HZ_TO_MSEC_SHR32; + return (U64_C(HZ_TO_MSEC_MUL32) * j) >> HZ_TO_MSEC_SHR32; # else return (j * HZ_TO_MSEC_NUM) / HZ_TO_MSEC_DEN; # endif @@ -260,7 +260,7 @@ unsigned int inline jiffies_to_usecs(const unsigned long j) return (j + (HZ / USEC_PER_SEC) - 1)/(HZ / USEC_PER_SEC); #else # if BITS_PER_LONG == 32 - return ((u64)HZ_TO_USEC_MUL32 * j) >> HZ_TO_USEC_SHR32; + return (U64_C(HZ_TO_USEC_MUL32) * j) >> HZ_TO_USEC_SHR32; # else return (j * HZ_TO_USEC_NUM) / HZ_TO_USEC_DEN; # endif @@ -470,7 +470,7 @@ unsigned long msecs_to_jiffies(const unsigned int m) if (HZ > MSEC_PER_SEC && m > jiffies_to_msecs(MAX_JIFFY_OFFSET)) return MAX_JIFFY_OFFSET; - return ((u64)MSEC_TO_HZ_MUL32 * m + MSEC_TO_HZ_ADJ32) + return (U64_C(MSEC_TO_HZ_MUL32) * m + U64_C(MSEC_TO_HZ_ADJ32)) >> MSEC_TO_HZ_SHR32; #endif } @@ -485,7 +485,7 @@ unsigned long usecs_to_jiffies(const unsigned int u) #elif HZ > USEC_PER_SEC && !(HZ % USEC_PER_SEC) return u * (HZ / USEC_PER_SEC); #else - return ((u64)USEC_TO_HZ_MUL32 * u + USEC_TO_HZ_ADJ32) + return (U64_C(USEC_TO_HZ_MUL32) * u + U64_C(USEC_TO_HZ_ADJ32)) >> USEC_TO_HZ_SHR32; #endif } diff --git a/kernel/timeconst.pl b/kernel/timeconst.pl index 4146803..6212498 100644 --- a/kernel/timeconst.pl +++ b/kernel/timeconst.pl @@ -1,7 +1,7 @@ #!/usr/bin/perl # ----------------------------------------------------------------------- # -# Copyright 2007 rPath, Inc. - All Rights Reserved +# Copyright 2007-2008 rPath, Inc. - All Rights Reserved # # This file is part of the Linux kernel, and is made available under # the terms of the GNU General Public License version 2 or (at your @@ -318,6 +318,19 @@ sub compute_values($) { return @val; } +# Create defines for a value, including variants with all appropriate +# suffixes. The suffixed versions also allow pasted constructs like +# U64_C(HZ_TO_MSEC_MUL32) to work correctly. +sub outputval($$) +{ + my($name, $val) = @_; + my $csuf; + + foreach $csuf ('', 'U', 'L', 'UL', 'LL', 'ULL') { + printf "#define %-23s %s\n", $name.$csuf, $val.$csuf; + } +} + sub output($@) { my($hz, @val) = @_; @@ -342,13 +355,11 @@ sub output($@) 'HZ_TO_USEC','USEC_TO_HZ') { foreach $bit (32, 64) { foreach $suf ('MUL', 'ADJ', 'SHR') { - printf "#define %-23s %s\n", - "${pfx}_$suf$bit", shift(@val); + outputval("${pfx}_$suf$bit", shift(@val)); } } foreach $suf ('NUM', 'DEN') { - printf "#define %-23s %s\n", - "${pfx}_$suf", shift(@val); + outputval("${pfx}_$suf", shift(@val)); } } -- 1.5.4.1 ^ permalink raw reply related [flat|nested] 70+ messages in thread
* RE: [PATCH 24/24] Use U64_C() instead of casts in kernel/time.c 2008-04-25 4:10 ` [PATCH 24/24] Use U64_C() instead of casts in kernel/time.c H. Peter Anvin @ 2008-04-25 4:44 ` Luck, Tony 0 siblings, 0 replies; 70+ messages in thread From: Luck, Tony @ 2008-04-25 4:44 UTC (permalink / raw) To: H. Peter Anvin, Linus Torvalds, Andrew Morton Cc: Linux Kernel Mailing List, Linux Arch Mailing List > Note that since pasting has priority over macro resolution, the header > file generation is modified to have suffixed versions of all the > generated values. Much better. Builds and boots on ia64 now. I only ran some trivial tests, but it still seems to be counting time correctly. Acked-by: Tony Luck <tony.luck@intel.com> ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 03/24] arm: types: use <asm-generic/int-*.h> for the arm architecture 2008-04-24 23:05 ` [PATCH 03/24] arm: types: use <asm-generic/int-*.h> for the arm architecture H. Peter Anvin 2008-04-24 23:05 ` H. Peter Anvin @ 2008-04-25 0:14 ` Lennert Buytenhek 1 sibling, 0 replies; 70+ messages in thread From: Lennert Buytenhek @ 2008-04-25 0:14 UTC (permalink / raw) To: H. Peter Anvin Cc: Linus Torvalds, Andrew Morton, Linux Kernel Mailing List, Linux Arch Mailing List, Russell King, Ben Dooks On Thu, Apr 24, 2008 at 04:05:12PM -0700, H. Peter Anvin wrote: > This modifies <asm-arm/types.h> to use the <asm-generic/int-*.h> > generic include files. > > Signed-off-by: H. Peter Anvin <hpa@zytor.com> > Cc: Russell King <rmk@arm.linux.org.uk> > Cc: Lennert Buytenhek <kernel@wantstofly.org> > Cc: Ben Dooks <ben-linux@fluff.org> Acked-by: Lennert Buytenhek <kernel@wantstofly.org> ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 01/24] types: create <asm-generic/int-*.h> 2008-04-24 23:05 ` [PATCH 01/24] types: create <asm-generic/int-*.h> H. Peter Anvin 2008-04-24 23:05 ` [PATCH 02/24] alpha: types: use <asm-generic/int-*.h> for the alpha architecture H. Peter Anvin @ 2008-04-25 18:27 ` Jan Engelhardt 2008-04-25 18:36 ` Linus Torvalds 2008-04-25 20:30 ` David Miller 1 sibling, 2 replies; 70+ messages in thread From: Jan Engelhardt @ 2008-04-25 18:27 UTC (permalink / raw) To: H. Peter Anvin Cc: Linus Torvalds, Andrew Morton, Linux Kernel Mailing List, Linux Arch Mailing List On Friday 2008-04-25 01:05, H. Peter Anvin wrote: >This creates two generic files with common integer definitions; one >where 64 bits is "long" (most 64-bit architectures) and one where 64 >bits is "long long" (all 32-bit architectures and x86-64.) long long is 64 bits on both 32 and 64, is not it? If so, the split between 32 and 64 should not be necessary. ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 01/24] types: create <asm-generic/int-*.h> 2008-04-25 18:27 ` [PATCH 01/24] types: create <asm-generic/int-*.h> Jan Engelhardt @ 2008-04-25 18:36 ` Linus Torvalds 2008-04-25 18:52 ` Matthew Wilcox 2008-04-25 20:30 ` David Miller 1 sibling, 1 reply; 70+ messages in thread From: Linus Torvalds @ 2008-04-25 18:36 UTC (permalink / raw) To: Jan Engelhardt Cc: H. Peter Anvin, Andrew Morton, Linux Kernel Mailing List, Linux Arch Mailing List On Fri, 25 Apr 2008, Jan Engelhardt wrote: > > long long is 64 bits on both 32 and 64, is not it? > If so, the split between 32 and 64 should not be necessary. They may be the same size, but there are still pure C-level _type_ differences that the compiler will warn about. This is the same issue as a 32-bit type on x86-32: is it an "int" or a "long"? From a pure size perspective it shouldn't matter, but if you pass a pointer to it, or use it in a "printf()", it matters a whole lot, because the compiler will complain if you use the wrong version. So on some 32-bit architectures, "size_t" is "unsigned int", on others it is "unsigned long", and you have to get it right in order to avoid complaints. The exact same thing is true about "long" vs "long long" on 64-bit architectures. They may have the same size, but they don't have the same type. Linus ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 01/24] types: create <asm-generic/int-*.h> 2008-04-25 18:36 ` Linus Torvalds @ 2008-04-25 18:52 ` Matthew Wilcox 2008-04-25 19:03 ` Linus Torvalds 2008-04-25 19:10 ` H. Peter Anvin 0 siblings, 2 replies; 70+ messages in thread From: Matthew Wilcox @ 2008-04-25 18:52 UTC (permalink / raw) To: Linus Torvalds Cc: Jan Engelhardt, H. Peter Anvin, Andrew Morton, Linux Kernel Mailing List, Linux Arch Mailing List On Fri, Apr 25, 2008 at 11:36:26AM -0700, Linus Torvalds wrote: > On Fri, 25 Apr 2008, Jan Engelhardt wrote: > > long long is 64 bits on both 32 and 64, is not it? > > If so, the split between 32 and 64 should not be necessary. > > They may be the same size, but there are still pure C-level _type_ > differences that the compiler will warn about. > > This is the same issue as a 32-bit type on x86-32: is it an "int" or a > "long"? From a pure size perspective it shouldn't matter, but if you pass > a pointer to it, or use it in a "printf()", it matters a whole lot, > because the compiler will complain if you use the wrong version. > > So on some 32-bit architectures, "size_t" is "unsigned int", on others it > is "unsigned long", and you have to get it right in order to avoid > complaints. > > The exact same thing is true about "long" vs "long long" on 64-bit > architectures. They may have the same size, but they don't have the same > type. So ... given all this, why do we define s64 to be 'long' on some architectures and 'long long' on others? It seems to actively _hinder_ passing it to printf(), so there must be some other good reason that I'm missing to not make it 'long long' everywhere. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 01/24] types: create <asm-generic/int-*.h> 2008-04-25 18:52 ` Matthew Wilcox @ 2008-04-25 19:03 ` Linus Torvalds 2008-04-25 19:10 ` H. Peter Anvin 1 sibling, 0 replies; 70+ messages in thread From: Linus Torvalds @ 2008-04-25 19:03 UTC (permalink / raw) To: Matthew Wilcox Cc: Jan Engelhardt, H. Peter Anvin, Andrew Morton, Linux Kernel Mailing List, Linux Arch Mailing List On Fri, 25 Apr 2008, Matthew Wilcox wrote: > > So ... given all this, why do we define s64 to be 'long' on some > architectures and 'long long' on others? Historical reasons, mainly. Once we start using one type for things like loff_t, it ends up getting encoded in user header files, and we're then basically forced to continue to use that particular type. Some of them end literally being embedded in the compiler itself (ie __builtin_size_t etc end up being known by compiler built-ins). But yes, we could probably try to standardize the internal kernel s64/u64 types that don't end up spreading anywhere else. Of course, part of the worry is probably that people thought that maybe "long long" would some day be 128-bit on a 64-bit architecture. Linus ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 01/24] types: create <asm-generic/int-*.h> 2008-04-25 18:52 ` Matthew Wilcox 2008-04-25 19:03 ` Linus Torvalds @ 2008-04-25 19:10 ` H. Peter Anvin 2008-04-25 19:28 ` Matthew Wilcox 1 sibling, 1 reply; 70+ messages in thread From: H. Peter Anvin @ 2008-04-25 19:10 UTC (permalink / raw) To: Matthew Wilcox Cc: Linus Torvalds, Jan Engelhardt, Andrew Morton, Linux Kernel Mailing List, Linux Arch Mailing List Matthew Wilcox wrote: > > So ... given all this, why do we define s64 to be 'long' on some > architectures and 'long long' on others? It seems to actively _hinder_ > passing it to printf(), so there must be some other good reason that > I'm missing to not make it 'long long' everywhere. > Well, compatibility with userspace is probably one aspect of that. x86-64 is the odd man out there, it defines __s64 as "long long" even for userspace, even though int64_t from <stdint.h> is "long". This, IMO, is the Wrong Thing, but it's a separate set of changes. The right thing to do is probably to always use "long long" in the kernel, while defining __s64 et al as "long" on 64-bit platforms when not under __KERNEL__. Again, this is a separate set of changes from this patchset, which is just a code transformation. -hpa ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 01/24] types: create <asm-generic/int-*.h> 2008-04-25 19:10 ` H. Peter Anvin @ 2008-04-25 19:28 ` Matthew Wilcox 2008-04-25 19:38 ` H. Peter Anvin 0 siblings, 1 reply; 70+ messages in thread From: Matthew Wilcox @ 2008-04-25 19:28 UTC (permalink / raw) To: H. Peter Anvin Cc: Linus Torvalds, Jan Engelhardt, Andrew Morton, Linux Kernel Mailing List, Linux Arch Mailing List On Fri, Apr 25, 2008 at 12:10:40PM -0700, H. Peter Anvin wrote: > Well, compatibility with userspace is probably one aspect of that. > x86-64 is the odd man out there, it defines __s64 as "long long" even > for userspace, even though int64_t from <stdint.h> is "long". This, > IMO, is the Wrong Thing, but it's a separate set of changes. > > The right thing to do is probably to always use "long long" in the > kernel, while defining __s64 et al as "long" on 64-bit platforms when > not under __KERNEL__. > > Again, this is a separate set of changes from this patchset, which is > just a code transformation. Understood, and agreed. It just seemed like an opportune time to mention the problem of printing a u64. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 01/24] types: create <asm-generic/int-*.h> 2008-04-25 19:28 ` Matthew Wilcox @ 2008-04-25 19:38 ` H. Peter Anvin 2008-04-25 19:43 ` Jan Engelhardt 2008-04-25 19:45 ` Linus Torvalds 0 siblings, 2 replies; 70+ messages in thread From: H. Peter Anvin @ 2008-04-25 19:38 UTC (permalink / raw) To: Matthew Wilcox Cc: Linus Torvalds, Jan Engelhardt, Andrew Morton, Linux Kernel Mailing List, Linux Arch Mailing List Matthew Wilcox wrote: > On Fri, Apr 25, 2008 at 12:10:40PM -0700, H. Peter Anvin wrote: >> Well, compatibility with userspace is probably one aspect of that. >> x86-64 is the odd man out there, it defines __s64 as "long long" even >> for userspace, even though int64_t from <stdint.h> is "long". This, >> IMO, is the Wrong Thing, but it's a separate set of changes. >> >> The right thing to do is probably to always use "long long" in the >> kernel, while defining __s64 et al as "long" on 64-bit platforms when >> not under __KERNEL__. >> >> Again, this is a separate set of changes from this patchset, which is >> just a code transformation. > > Understood, and agreed. It just seemed like an opportune time to > mention the problem of printing a u64. > I have to admit to liking the Windows extension %I64u for this kind of stuff. Unfortunately gcc/glibc decided to use I for internationalized digits instead :( -hpa ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 01/24] types: create <asm-generic/int-*.h> 2008-04-25 19:38 ` H. Peter Anvin @ 2008-04-25 19:43 ` Jan Engelhardt 2008-04-28 13:55 ` David Howells 2008-04-25 19:45 ` Linus Torvalds 1 sibling, 1 reply; 70+ messages in thread From: Jan Engelhardt @ 2008-04-25 19:43 UTC (permalink / raw) To: H. Peter Anvin Cc: Matthew Wilcox, Linus Torvalds, Andrew Morton, Linux Kernel Mailing List, Linux Arch Mailing List On Friday 2008-04-25 21:38, H. Peter Anvin wrote: >> Understood, and agreed. It just seemed like an opportune time to >> mention the problem of printing a u64. >> > > I have to admit to liking the Windows extension %I64u for this kind of stuff. > Unfortunately gcc/glibc decided to use I for internationalized digits instead > :( In the kernel's *printk, we are free to do what we want :) %_64u perhaps? ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 01/24] types: create <asm-generic/int-*.h> 2008-04-25 19:43 ` Jan Engelhardt @ 2008-04-28 13:55 ` David Howells 0 siblings, 0 replies; 70+ messages in thread From: David Howells @ 2008-04-28 13:55 UTC (permalink / raw) To: Jan Engelhardt Cc: dhowells, H. Peter Anvin, Matthew Wilcox, Linus Torvalds, Andrew Morton, Linux Kernel Mailing List, Linux Arch Mailing List Jan Engelhardt <jengelh@computergmbh.de> wrote: > In the kernel's *printk, we are free to do what we want :) Subject to -Wformat in gcc, of course... David ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 01/24] types: create <asm-generic/int-*.h> 2008-04-25 19:38 ` H. Peter Anvin 2008-04-25 19:43 ` Jan Engelhardt @ 2008-04-25 19:45 ` Linus Torvalds 2008-04-25 19:48 ` H. Peter Anvin 2008-04-25 19:49 ` Harvey Harrison 1 sibling, 2 replies; 70+ messages in thread From: Linus Torvalds @ 2008-04-25 19:45 UTC (permalink / raw) To: H. Peter Anvin Cc: Matthew Wilcox, Jan Engelhardt, Andrew Morton, Linux Kernel Mailing List, Linux Arch Mailing List On Fri, 25 Apr 2008, H. Peter Anvin wrote: > > I have to admit to liking the Windows extension %I64u for this kind of stuff. > Unfortunately gcc/glibc decided to use I for internationalized digits instead > :( The sad part is that this is purely a gcc thing. We could easily do the right thing in the kernel vsnprintf stuff, but then we'd have to drop the nice format warnings from gcc ;( Linus ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 01/24] types: create <asm-generic/int-*.h> 2008-04-25 19:45 ` Linus Torvalds @ 2008-04-25 19:48 ` H. Peter Anvin 2008-04-25 19:49 ` Harvey Harrison 1 sibling, 0 replies; 70+ messages in thread From: H. Peter Anvin @ 2008-04-25 19:48 UTC (permalink / raw) To: Linus Torvalds Cc: Matthew Wilcox, Jan Engelhardt, Andrew Morton, Linux Kernel Mailing List, Linux Arch Mailing List Linus Torvalds wrote: > > On Fri, 25 Apr 2008, H. Peter Anvin wrote: >> I have to admit to liking the Windows extension %I64u for this kind of stuff. >> Unfortunately gcc/glibc decided to use I for internationalized digits instead >> :( > > The sad part is that this is purely a gcc thing. We could easily do the > right thing in the kernel vsnprintf stuff, but then we'd have to drop the > nice format warnings from gcc ;( > Yes, that's the fundamental problem. There isn't even a flag for gcc to set this behaviour, with the result that any code compiled with MinGW (gcc for Win32) spews warnings like crazy. -hpa ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 01/24] types: create <asm-generic/int-*.h> 2008-04-25 19:45 ` Linus Torvalds 2008-04-25 19:48 ` H. Peter Anvin @ 2008-04-25 19:49 ` Harvey Harrison 1 sibling, 0 replies; 70+ messages in thread From: Harvey Harrison @ 2008-04-25 19:49 UTC (permalink / raw) To: Linus Torvalds, Al Viro Cc: H. Peter Anvin, Matthew Wilcox, Jan Engelhardt, Andrew Morton, Linux Kernel Mailing List, Linux Arch Mailing List On Fri, 2008-04-25 at 12:45 -0700, Linus Torvalds wrote: > > On Fri, 25 Apr 2008, H. Peter Anvin wrote: > > > > I have to admit to liking the Windows extension %I64u for this kind of stuff. > > Unfortunately gcc/glibc decided to use I for internationalized digits instead > > :( > > The sad part is that this is purely a gcc thing. We could easily do the > right thing in the kernel vsnprintf stuff, but then we'd have to drop the > nice format warnings from gcc ;( This looks like something sparse could be made to check though, should we lose the gcc checking. In fact, didn't Al Viro mention adding just this kind of checking to sparse recently? Harvey ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 01/24] types: create <asm-generic/int-*.h> 2008-04-25 18:27 ` [PATCH 01/24] types: create <asm-generic/int-*.h> Jan Engelhardt 2008-04-25 18:36 ` Linus Torvalds @ 2008-04-25 20:30 ` David Miller 1 sibling, 0 replies; 70+ messages in thread From: David Miller @ 2008-04-25 20:30 UTC (permalink / raw) To: jengelh; +Cc: hpa, torvalds, akpm, linux-kernel, linux-arch From: Jan Engelhardt <jengelh@computergmbh.de> Date: Fri, 25 Apr 2008 20:27:53 +0200 (CEST) > On Friday 2008-04-25 01:05, H. Peter Anvin wrote: > > >This creates two generic files with common integer definitions; one > >where 64 bits is "long" (most 64-bit architectures) and one where 64 > >bits is "long long" (all 32-bit architectures and x86-64.) > > long long is 64 bits on both 32 and 64, is not it? > If so, the split between 32 and 64 should not be necessary. Because of the large precendence, if you change this stuff, you're going to get tons of warnings on the platforms that use "unsigned long" currently if you change them to use "unsigned long long". Think about all of the implicit type conversions, argument passing, et al. I know because I tried to convert sparc64 over to "unsigned long long" to make it more like powerpc, and I found quickly that fixing up all the fallout simply was not worth it. ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 01/24] types: create <asm-generic/int-*.h> [not found] ` <1209078352-7593-2-git-send-email-hpa@zytor.com> 2008-04-24 23:05 ` [PATCH 01/24] types: create <asm-generic/int-*.h> H. Peter Anvin @ 2008-04-25 0:15 ` Lennert Buytenhek 1 sibling, 0 replies; 70+ messages in thread From: Lennert Buytenhek @ 2008-04-25 0:15 UTC (permalink / raw) To: H. Peter Anvin Cc: Linus Torvalds, Andrew Morton, Linux Kernel Mailing List, Linux Arch Mailing List, Ben Dooks, Russell King On Thu, Apr 24, 2008 at 04:05:08PM -0700, H. Peter Anvin wrote: > This creates two generic files with common integer definitions; one > where 64 bits is "long" (most 64-bit architectures) and one where 64 > bits is "long long" (all 32-bit architectures and x86-64.) Acked-by: Lennert Buytenhek <kernel@wantstofly.org> ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 00/24] Unify integer type definitions, and add fixed type constructor macros 2008-04-24 23:05 [PATCH 00/24] Unify integer type definitions, and add fixed type constructor macros H. Peter Anvin [not found] ` <1209078352-7593-2-git-send-email-hpa@zytor.com> @ 2008-04-25 7:17 ` Geert Uytterhoeven 2008-04-25 7:49 ` Andreas Schwab 2008-04-25 8:15 ` Arnd Bergmann 2 siblings, 1 reply; 70+ messages in thread From: Geert Uytterhoeven @ 2008-04-25 7:17 UTC (permalink / raw) To: H. Peter Anvin Cc: Linus Torvalds, Andrew Morton, Linux Kernel Mailing List, Linux Arch Mailing List On Thu, 24 Apr 2008, H. Peter Anvin wrote: > This patchset unifies the integer definitions across all the > <asm-*/types.h> files, replacing them with two asm-generic files, one > for the LL64 model (all 32-bit architectures plus x86-64) and one for > the L64 model (all other 64-bit architectures.) Just a minor nitpick, what about calling them LP32 and LP64, like everybody else does? I.e. asm-generic/types-lp{32,64}.h? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 00/24] Unify integer type definitions, and add fixed type constructor macros 2008-04-25 7:17 ` [PATCH 00/24] Unify integer type definitions, and add fixed type constructor macros Geert Uytterhoeven @ 2008-04-25 7:49 ` Andreas Schwab 0 siblings, 0 replies; 70+ messages in thread From: Andreas Schwab @ 2008-04-25 7:49 UTC (permalink / raw) To: Geert Uytterhoeven Cc: H. Peter Anvin, Linus Torvalds, Andrew Morton, Linux Kernel Mailing List, Linux Arch Mailing List Geert Uytterhoeven <geert@linux-m68k.org> writes: > On Thu, 24 Apr 2008, H. Peter Anvin wrote: >> This patchset unifies the integer definitions across all the >> <asm-*/types.h> files, replacing them with two asm-generic files, one >> for the LL64 model (all 32-bit architectures plus x86-64) and one for >> the L64 model (all other 64-bit architectures.) > > Just a minor nitpick, what about calling them LP32 and LP64, like > everybody else does? LP32 wouldn't fit x86-64 (the header has nothing to say about pointer types, it's all about integer types). Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 00/24] Unify integer type definitions, and add fixed type constructor macros 2008-04-24 23:05 [PATCH 00/24] Unify integer type definitions, and add fixed type constructor macros H. Peter Anvin [not found] ` <1209078352-7593-2-git-send-email-hpa@zytor.com> 2008-04-25 7:17 ` [PATCH 00/24] Unify integer type definitions, and add fixed type constructor macros Geert Uytterhoeven @ 2008-04-25 8:15 ` Arnd Bergmann 2008-04-27 17:44 ` H. Peter Anvin 2 siblings, 1 reply; 70+ messages in thread From: Arnd Bergmann @ 2008-04-25 8:15 UTC (permalink / raw) To: H. Peter Anvin Cc: Linus Torvalds, Andrew Morton, Linux Kernel Mailing List, Linux Arch Mailing List On Friday 25 April 2008, H. Peter Anvin wrote: > This patchset unifies the integer definitions across all the > <asm-*/types.h> files, replacing them with two asm-generic files, one > for the LL64 model (all 32-bit architectures plus x86-64) and one for > the L64 model (all other 64-bit architectures.) I started hacking on a similar patch just yesterday, but with a slightly different goal. My intention was to move the headers in a direction where a new architecture (microblaze being the next one) would no longer have to care about ABI defining headers at all, but just use the defaults from a single #include line. I could deal with x86 by leaving the current asm-x86/types.h in place, and change all the others so they can use the common one. The only difference here would be umode_t and dma_addr_t, which are irregularly defined on a few architectures, but we can assume reasonable defaults, as in asm-powerpc/types.h: #ifdef __powerpc64__ #define __umode_t unsigned int #include <asm-generic/types_64.h> #else #include <asm-generic/types_32.h> #endif asm-generic/types_64.h: #ifdef __umode_t typedef __umode_t umode_t; #else typedef unsigned short umode_t; #endif Arnd <>< ^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [PATCH 00/24] Unify integer type definitions, and add fixed type constructor macros 2008-04-25 8:15 ` Arnd Bergmann @ 2008-04-27 17:44 ` H. Peter Anvin 0 siblings, 0 replies; 70+ messages in thread From: H. Peter Anvin @ 2008-04-27 17:44 UTC (permalink / raw) To: Arnd Bergmann Cc: Linus Torvalds, Andrew Morton, Linux Kernel Mailing List, Linux Arch Mailing List Arnd Bergmann wrote: > On Friday 25 April 2008, H. Peter Anvin wrote: >> This patchset unifies the integer definitions across all the >> <asm-*/types.h> files, replacing them with two asm-generic files, one >> for the LL64 model (all 32-bit architectures plus x86-64) and one for >> the L64 model (all other 64-bit architectures.) > > I started hacking on a similar patch just yesterday, but with a slightly > different goal. My intention was to move the headers in a direction > where a new architecture (microblaze being the next one) would no longer > have to care about ABI defining headers at all, but just use the defaults > from a single #include line. > > I could deal with x86 by leaving the current asm-x86/types.h in place, > and change all the others so they can use the common one. The only > difference here would be umode_t and dma_addr_t, which are irregularly > defined on a few architectures, but we can assume reasonable defaults, as in > It seems reasonable to implement what you are proposing on top of my changes, IMO. -hpa ^ permalink raw reply [flat|nested] 70+ messages in thread
end of thread, other threads:[~2008-04-28 13:55 UTC | newest]
Thread overview: 70+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-24 23:05 [PATCH 00/24] Unify integer type definitions, and add fixed type constructor macros H. Peter Anvin
[not found] ` <1209078352-7593-2-git-send-email-hpa@zytor.com>
2008-04-24 23:05 ` [PATCH 01/24] types: create <asm-generic/int-*.h> H. Peter Anvin
2008-04-24 23:05 ` [PATCH 02/24] alpha: types: use <asm-generic/int-*.h> for the alpha architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 03/24] arm: types: use <asm-generic/int-*.h> for the arm architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 04/24] avr32: types: use <asm-generic/int-*.h> for the avr32 architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 05/24] blackfin: types: use <asm-generic/int-*.h> for the blackfin architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 06/24] cris: types: use <asm-generic/int-*.h> for the cris architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 07/24] frv: types: use <asm-generic/int-*.h> for the frv architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 08/24] h8300: types: use <asm-generic/int-*.h> for the h8300 architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 09/24] ia64: types: use <asm-generic/int-*.h> for the ia64 architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 10/24] m32r: types: use <asm-generic/int-*.h> for the m32r architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 11/24] m68k: types: use <asm-generic/int-*.h> for the m68k architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 12/24] mips: types: use <asm-generic/int-*.h> for the mips architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 13/24] mn10300: types: use <asm-generic/int-*.h> for the mn10300 architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 14/24] parisc: types: use <asm-generic/int-*.h> for the parisc architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 15/24] powerpc: types: use <asm-generic/int-*.h> for the powerpc architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 16/24] s390: types: use <asm-generic/int-*.h> for the s390 architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 17/24] sh: types: use <asm-generic/int-*.h> for the sh architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 18/24] sparc: types: use <asm-generic/int-*.h> for the sparc architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 19/24] sparc64: types: use <asm-generic/int-*.h> for the sparc64 architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 20/24] v850: types: use <asm-generic/int-*.h> for the v850 architecture H. Peter Anvin
2008-04-24 23:05 ` [PATCH 21/24] x86: types: use <asm-generic/int-*.h> for the x86 architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 22/24] xtensa: types: use <asm-generic/int-*.h> for the xtensa architecture H. Peter Anvin
2008-04-24 23:05 ` H. Peter Anvin
2008-04-24 23:05 ` [PATCH 23/24] types: add C99-style constructors to <asm-generic/int-*.h> H. Peter Anvin
2008-04-24 23:05 ` [PATCH 24/24] Use U64_C() instead of casts in kernel/time.c H. Peter Anvin
2008-04-25 0:44 ` [PATCH 19/24] sparc64: types: use <asm-generic/int-*.h> for the sparc64 architecture David Miller
2008-04-25 0:44 ` [PATCH 18/24] sparc: types: use <asm-generic/int-*.h> for the sparc architecture David Miller
2008-04-25 1:37 ` [PATCH 09/24] ia64: types: use <asm-generic/int-*.h> for the ia64 architecture Luck, Tony
2008-04-25 3:42 ` H. Peter Anvin
2008-04-25 4:10 ` [PATCH 24/24] Use U64_C() instead of casts in kernel/time.c H. Peter Anvin
2008-04-25 4:44 ` Luck, Tony
2008-04-25 0:14 ` [PATCH 03/24] arm: types: use <asm-generic/int-*.h> for the arm architecture Lennert Buytenhek
2008-04-25 18:27 ` [PATCH 01/24] types: create <asm-generic/int-*.h> Jan Engelhardt
2008-04-25 18:36 ` Linus Torvalds
2008-04-25 18:52 ` Matthew Wilcox
2008-04-25 19:03 ` Linus Torvalds
2008-04-25 19:10 ` H. Peter Anvin
2008-04-25 19:28 ` Matthew Wilcox
2008-04-25 19:38 ` H. Peter Anvin
2008-04-25 19:43 ` Jan Engelhardt
2008-04-28 13:55 ` David Howells
2008-04-25 19:45 ` Linus Torvalds
2008-04-25 19:48 ` H. Peter Anvin
2008-04-25 19:49 ` Harvey Harrison
2008-04-25 20:30 ` David Miller
2008-04-25 0:15 ` Lennert Buytenhek
2008-04-25 7:17 ` [PATCH 00/24] Unify integer type definitions, and add fixed type constructor macros Geert Uytterhoeven
2008-04-25 7:49 ` Andreas Schwab
2008-04-25 8:15 ` Arnd Bergmann
2008-04-27 17:44 ` H. Peter Anvin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox