Re: [PATCH] bitops: remove "optimizations"

Thomas Gleixner
2008-04-29T16:52:30Z

On Tue, 29 Apr 2008, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Tue, 29 Apr 2008 03:03:32 -0700 (PDT)
>
> > From: Thomas Gleixner <tglx@linutronix.de>
> > Date: Tue, 29 Apr 2008 12:01:02 +0200 (CEST)
> >
> > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> >
> > Acked-by: David S. Miller <davem@davemloft.net>
>
> Ironically, I just bisected sparc64 bootup failures to the following
> changeset. It's very late here, and I haven't looked into the
> details, but it seems to wedge in free_area_init_nodes() on a non-NUMA
> system with CONFIG_NUMA disabled.
>
> Isn't it funny that this optimization not only was useless, but also
> broke things. :-/

The question is, whether it broke things or just unearthed some bug
hidden elsewhere.

Thanks,
tglx