From: "Denis V. Lunev" <den@openvz.org>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, "Denis V. Lunev" <den@openvz.org>,
Alexey Dobriyan <adobriyan@openvz.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Patrick McHardy <kaber@trash.net>
Subject: [PATCH 2/12] netfilter: assign PDE->data before gluing PDE into /proc tree
Date: Tue, 29 Apr 2008 15:13:12 +0400 [thread overview]
Message-ID: <1209467602-20001-2-git-send-email-den@openvz.org> (raw)
In-Reply-To: <1209467538.29647.11.camel@iris.sw.ru>
Simply replace proc_create and further data assigned with proc_create_data.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Cc: Alexey Dobriyan <adobriyan@openvz.org>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: Patrick McHardy <kaber@trash.net>
---
net/ipv4/netfilter/ipt_CLUSTERIP.c | 6 +++---
net/netfilter/xt_hashlimit.c | 12 ++++++------
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/net/ipv4/netfilter/ipt_CLUSTERIP.c b/net/ipv4/netfilter/ipt_CLUSTERIP.c
index 22d8e7c..1819ad7 100644
--- a/net/ipv4/netfilter/ipt_CLUSTERIP.c
+++ b/net/ipv4/netfilter/ipt_CLUSTERIP.c
@@ -169,14 +169,14 @@ clusterip_config_init(const struct ipt_clusterip_tgt_info *i, __be32 ip,
/* create proc dir entry */
sprintf(buffer, "%u.%u.%u.%u", NIPQUAD(ip));
- c->pde = proc_create(buffer, S_IWUSR|S_IRUSR,
- clusterip_procdir, &clusterip_proc_fops);
+ c->pde = proc_create_data(buffer, S_IWUSR|S_IRUSR,
+ clusterip_procdir,
+ &clusterip_proc_fops, c);
if (!c->pde) {
kfree(c);
return NULL;
}
}
- c->pde->data = c;
#endif
write_lock_bh(&clusterip_lock);
diff --git a/net/netfilter/xt_hashlimit.c b/net/netfilter/xt_hashlimit.c
index 40d344b..6809af5 100644
--- a/net/netfilter/xt_hashlimit.c
+++ b/net/netfilter/xt_hashlimit.c
@@ -237,15 +237,15 @@ static int htable_create_v0(struct xt_hashlimit_info *minfo, int family)
hinfo->family = family;
hinfo->rnd_initialized = 0;
spin_lock_init(&hinfo->lock);
- hinfo->pde = proc_create(minfo->name, 0,
+ hinfo->pde =
+ proc_create_data(minfo->name, 0,
family == AF_INET ? hashlimit_procdir4 :
hashlimit_procdir6,
- &dl_file_ops);
+ &dl_file_ops, hinfo);
if (!hinfo->pde) {
vfree(hinfo);
return -1;
}
- hinfo->pde->data = hinfo;
setup_timer(&hinfo->timer, htable_gc, (unsigned long )hinfo);
hinfo->timer.expires = jiffies + msecs_to_jiffies(hinfo->cfg.gc_interval);
@@ -301,15 +301,15 @@ static int htable_create(struct xt_hashlimit_mtinfo1 *minfo,
hinfo->rnd_initialized = 0;
spin_lock_init(&hinfo->lock);
- hinfo->pde = proc_create(minfo->name, 0,
+ hinfo->pde =
+ proc_create_data(minfo->name, 0,
family == AF_INET ? hashlimit_procdir4 :
hashlimit_procdir6,
- &dl_file_ops);
+ &dl_file_ops, hinfo);
if (hinfo->pde == NULL) {
vfree(hinfo);
return -1;
}
- hinfo->pde->data = hinfo;
setup_timer(&hinfo->timer, htable_gc, (unsigned long)hinfo);
hinfo->timer.expires = jiffies + msecs_to_jiffies(hinfo->cfg.gc_interval);
--
1.5.3.rc5
next prev parent reply other threads:[~2008-04-29 11:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 11:12 [PATCH 0/12] Further PDE->data assignments cleanups Denis V. Lunev
2008-04-29 11:13 ` [PATCH 1/12] sunrpc: assign PDE->data before gluing PDE into /proc tree Denis V. Lunev
2008-05-02 9:44 ` David Miller
2008-04-29 11:13 ` Denis V. Lunev [this message]
2008-05-02 9:45 ` [PATCH 2/12] netfilter: " David Miller
2008-04-29 11:13 ` [PATCH 3/12] net: " Denis V. Lunev
2008-05-02 9:46 ` David Miller
2008-04-29 11:13 ` [PATCH 4/12] ipv6: " Denis V. Lunev
2008-05-02 9:47 ` David Miller
2008-04-29 11:13 ` [PATCH 5/12] atm: " Denis V. Lunev
2008-05-02 11:08 ` David Miller
2008-04-29 11:13 ` [PATCH 6/12] vlan: " Denis V. Lunev
2008-05-02 11:09 ` David Miller
2008-04-29 11:13 ` [PATCH 7/12] cciss: " Denis V. Lunev
2008-04-29 15:26 ` Miller, Mike (OS Dev)
2008-04-29 11:13 ` [PATCH 8/12] powerpc: " Denis V. Lunev
2008-04-29 11:13 ` [PATCH 9/12] ipv4: " Denis V. Lunev
2008-05-02 11:10 ` David Miller
2008-07-12 3:12 ` Stoyan Gaydarov
2008-07-12 3:42 ` Eric W. Biederman
2008-07-12 14:55 ` Denis V. Lunev
2008-04-29 11:13 ` [PATCH 10/12] netfilter: assign PDE->fops " Denis V. Lunev
2008-05-02 11:11 ` David Miller
2008-04-29 11:13 ` [PATCH 11/12] netfilter: assign PDE->data " Denis V. Lunev
2008-04-29 12:01 ` Patrick McHardy
2008-05-02 11:12 ` David Miller
2008-04-29 11:13 ` [PATCH 12/12] netns: assign PDE->data before gluing entry " Denis V. Lunev
2008-05-02 11:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209467602-20001-2-git-send-email-den@openvz.org \
--to=den@openvz.org \
--cc=adobriyan@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox