From: Mike Galbraith <efault@gmx.de>
To: Michael Krufky <mkrufky@linuxtv.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
sfr@canb.auug.org.au, video4linux-list@redhat.com,
Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org, mchehab@infradead.org,
linux-dvb-maintainer@linuxtv.org, Ingo Molnar <mingo@elte.hu>,
torvalds@linux-foundation.org, David Miller <davem@davemloft.net>
Subject: Re: [v4l-dvb-maintainer] [patch, -git] drivers/media build fix for modular builds
Date: Wed, 30 Apr 2008 18:01:55 +0200 [thread overview]
Message-ID: <1209571315.4794.2.camel@marge.simson.net> (raw)
In-Reply-To: <37219a840804300839g55b53f31sdfd90bdede810455@mail.gmail.com>
On Wed, 2008-04-30 at 11:39 -0400, Michael Krufky wrote:
>
> ...and about your previous fix:
>
> --- a/drivers/media/video/tuner-core.c~drivers-media-video-tuner-corec-tuner_probe-fix-error-check
> +++ a/drivers/media/video/tuner-core.c
> @@ -1181,7 +1181,7 @@ static int tuner_probe(struct i2c_client
> case 0x60:
> if (tuner_symbol_probe(tea5767_autodetection,
> t->i2c->adapter, t->i2c->addr)
> - != EINVAL) {
> + != -EINVAL) {
> t->type = TUNER_TEA5767;
> t->mode_mask = T_RADIO;
> t->mode = T_STANDBY;
>
>
> I think we're better off testing for >= 0. Any < 0 should be
> considered a failure.
I tried it anyway, still went boom.
-Mike
next prev parent reply other threads:[~2008-04-30 16:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 21:50 [GIT PATCHES] V4L/DVB updates and fixes for 2.6.26 Mauro Carvalho Chehab
2008-04-29 21:59 ` Linus Torvalds
2008-04-29 23:49 ` [v4l-dvb-maintainer] " Michael Krufky
2008-04-30 0:00 ` Mauro Carvalho Chehab
2008-04-30 7:48 ` [patch, -git] drivers/media build fix for modular builds Ingo Molnar
2008-04-30 7:52 ` David Miller
2008-04-30 8:13 ` Ingo Molnar
2008-04-30 8:27 ` Mike Galbraith
2008-04-30 8:42 ` Mike Galbraith
2008-04-30 8:56 ` Mike Galbraith
2008-04-30 9:20 ` Mike Galbraith
2008-04-30 11:40 ` Andrew Morton
2008-04-30 13:03 ` Mike Galbraith
2008-04-30 14:39 ` [v4l-dvb-maintainer] " Michael Krufky
2008-04-30 15:29 ` Andrew Morton
2008-04-30 15:30 ` Mike Galbraith
2008-04-30 15:34 ` Andrew Morton
2008-04-30 15:39 ` Michael Krufky
2008-04-30 16:01 ` Mike Galbraith [this message]
2008-04-30 15:48 ` Mauro Carvalho Chehab
2008-04-30 15:25 ` Mauro Carvalho Chehab
2008-04-30 15:48 ` Mike Galbraith
2008-04-30 16:12 ` Mauro Carvalho Chehab
2008-04-30 16:31 ` Mike Galbraith
2008-04-30 21:35 ` Mauro Carvalho Chehab
2008-04-30 21:52 ` [v4l-dvb-maintainer] " Trent Piepho
2008-04-30 22:38 ` [v4l-dvb-maintainer] [patch, -git] drivers/media build fix fo r " mkrufky
2008-04-30 9:26 ` [patch, -git] drivers/media build fix for " Sam Ravnborg
2008-04-30 9:40 ` Mike Galbraith
2008-04-30 10:36 ` Ingo Molnar
2008-04-30 9:25 ` Sam Ravnborg
2008-04-30 9:37 ` Ingo Molnar
2008-04-30 9:55 ` Sam Ravnborg
2008-04-30 8:02 ` [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates and fixes for 2.6.26 Patrick Boettcher
2008-04-30 19:03 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209571315.4794.2.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mingo@elte.hu \
--cc=mkrufky@linuxtv.org \
--cc=sam@ravnborg.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox