* [PATCH 03/10] usb: fix integer as NULL pointer warnings
@ 2008-04-30 22:03 Harvey Harrison
2008-05-01 23:02 ` Andrew Morton
2008-05-08 22:38 ` patch usb-fix-integer-as-null-pointer-warnings-found-by-sparse.patch added to gregkh-2.6 tree gregkh
0 siblings, 2 replies; 4+ messages in thread
From: Harvey Harrison @ 2008-04-30 22:03 UTC (permalink / raw)
To: Andrew Morton; +Cc: Greg KH, LKML
drivers/usb/host/ohci-sm501.c:93:24: warning: Using plain integer as NULL pointer
drivers/usb/gadget/amd5536udc.c:3254:9: warning: Using plain integer as NULL pointer
drivers/usb/gadget/amd5536udc.c:3267:9: warning: Using plain integer as NULL pointer
drivers/usb/gadget/amd5536udc.c:3277:9: warning: Using plain integer as NULL pointer
drivers/usb/gadget/amd5536udc.c:3285:9: warning: Using plain integer as NULL pointer
drivers/usb/gadget/amd5536udc.c:3293:9: warning: Using plain integer as NULL pointer
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
drivers/usb/gadget/amd5536udc.c | 10 +++++-----
drivers/usb/host/ohci-sm501.c | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
index ce337cb..f261d2a 100644
--- a/drivers/usb/gadget/amd5536udc.c
+++ b/drivers/usb/gadget/amd5536udc.c
@@ -3251,7 +3251,7 @@ static int udc_pci_probe(
/* pci setup */
if (pci_enable_device(pdev) < 0) {
kfree(dev);
- dev = 0;
+ dev = NULL;
retval = -ENODEV;
goto finished;
}
@@ -3264,7 +3264,7 @@ static int udc_pci_probe(
if (!request_mem_region(resource, len, name)) {
dev_dbg(&pdev->dev, "pci device used already\n");
kfree(dev);
- dev = 0;
+ dev = NULL;
retval = -EBUSY;
goto finished;
}
@@ -3274,7 +3274,7 @@ static int udc_pci_probe(
if (dev->virt_addr == NULL) {
dev_dbg(&pdev->dev, "start address cannot be mapped\n");
kfree(dev);
- dev = 0;
+ dev = NULL;
retval = -EFAULT;
goto finished;
}
@@ -3282,7 +3282,7 @@ static int udc_pci_probe(
if (!pdev->irq) {
dev_err(&dev->pdev->dev, "irq not set\n");
kfree(dev);
- dev = 0;
+ dev = NULL;
retval = -ENODEV;
goto finished;
}
@@ -3290,7 +3290,7 @@ static int udc_pci_probe(
if (request_irq(pdev->irq, udc_irq, IRQF_SHARED, name, dev) != 0) {
dev_dbg(&dev->pdev->dev, "request_irq(%d) fail\n", pdev->irq);
kfree(dev);
- dev = 0;
+ dev = NULL;
retval = -EBUSY;
goto finished;
}
diff --git a/drivers/usb/host/ohci-sm501.c b/drivers/usb/host/ohci-sm501.c
index 77204f0..e899a77 100644
--- a/drivers/usb/host/ohci-sm501.c
+++ b/drivers/usb/host/ohci-sm501.c
@@ -90,7 +90,7 @@ static int ohci_hcd_sm501_drv_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct resource *res, *mem;
int retval, irq;
- struct usb_hcd *hcd = 0;
+ struct usb_hcd *hcd = NULL;
irq = retval = platform_get_irq(pdev, 0);
if (retval < 0)
--
1.5.5.1.305.g7c84
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 03/10] usb: fix integer as NULL pointer warnings
2008-04-30 22:03 [PATCH 03/10] usb: fix integer as NULL pointer warnings Harvey Harrison
@ 2008-05-01 23:02 ` Andrew Morton
2008-05-01 23:07 ` Harvey Harrison
2008-05-08 22:38 ` patch usb-fix-integer-as-null-pointer-warnings-found-by-sparse.patch added to gregkh-2.6 tree gregkh
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2008-05-01 23:02 UTC (permalink / raw)
To: Harvey Harrison; +Cc: gregkh, linux-kernel
On Wed, 30 Apr 2008 15:03:41 -0700
Harvey Harrison <harvey.harrison@gmail.com> wrote:
> drivers/usb/host/ohci-sm501.c:93:24: warning: Using plain integer as NULL pointer
> drivers/usb/gadget/amd5536udc.c:3254:9: warning: Using plain integer as NULL pointer
> drivers/usb/gadget/amd5536udc.c:3267:9: warning: Using plain integer as NULL pointer
> drivers/usb/gadget/amd5536udc.c:3277:9: warning: Using plain integer as NULL pointer
> drivers/usb/gadget/amd5536udc.c:3285:9: warning: Using plain integer as NULL pointer
> drivers/usb/gadget/amd5536udc.c:3293:9: warning: Using plain integer as NULL pointer
I'd suggest that you mention "sparse" in the title and/or changelog.
Otherwise people wonder what's up with their gcc.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 03/10] usb: fix integer as NULL pointer warnings
2008-05-01 23:02 ` Andrew Morton
@ 2008-05-01 23:07 ` Harvey Harrison
0 siblings, 0 replies; 4+ messages in thread
From: Harvey Harrison @ 2008-05-01 23:07 UTC (permalink / raw)
To: Andrew Morton; +Cc: gregkh, linux-kernel
On Thu, 2008-05-01 at 16:02 -0700, Andrew Morton wrote:
> On Wed, 30 Apr 2008 15:03:41 -0700
> Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> > drivers/usb/host/ohci-sm501.c:93:24: warning: Using plain integer as NULL pointer
> > drivers/usb/gadget/amd5536udc.c:3254:9: warning: Using plain integer as NULL pointer
> > drivers/usb/gadget/amd5536udc.c:3267:9: warning: Using plain integer as NULL pointer
> > drivers/usb/gadget/amd5536udc.c:3277:9: warning: Using plain integer as NULL pointer
> > drivers/usb/gadget/amd5536udc.c:3285:9: warning: Using plain integer as NULL pointer
> > drivers/usb/gadget/amd5536udc.c:3293:9: warning: Using plain integer as NULL pointer
>
> I'd suggest that you mention "sparse" in the title and/or changelog.
> Otherwise people wonder what's up with their gcc.
>
Noted, will do so in future.
Harvey
^ permalink raw reply [flat|nested] 4+ messages in thread
* patch usb-fix-integer-as-null-pointer-warnings-found-by-sparse.patch added to gregkh-2.6 tree
2008-04-30 22:03 [PATCH 03/10] usb: fix integer as NULL pointer warnings Harvey Harrison
2008-05-01 23:02 ` Andrew Morton
@ 2008-05-08 22:38 ` gregkh
1 sibling, 0 replies; 4+ messages in thread
From: gregkh @ 2008-05-08 22:38 UTC (permalink / raw)
To: harvey.harrison, akpm, gregkh, linux-kernel
This is a note to let you know that I've just added the patch titled
Subject: usb: fix integer as NULL pointer warnings found by sparse
to my gregkh-2.6 tree. Its filename is
usb-fix-integer-as-null-pointer-warnings-found-by-sparse.patch
This tree can be found at
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/
>From harvey.harrison@gmail.com Wed Apr 30 15:03:34 2008
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Wed, 30 Apr 2008 15:03:41 -0700
Subject: usb: fix integer as NULL pointer warnings found by sparse
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Greg KH <gregkh@suse.de>, LKML <linux-kernel@vger.kernel.org>
Message-ID: <1209593021.24729.113.camel@brick>
drivers/usb/host/ohci-sm501.c:93:24: warning: Using plain integer as NULL pointer
drivers/usb/gadget/amd5536udc.c:3254:9: warning: Using plain integer as NULL pointer
drivers/usb/gadget/amd5536udc.c:3267:9: warning: Using plain integer as NULL pointer
drivers/usb/gadget/amd5536udc.c:3277:9: warning: Using plain integer as NULL pointer
drivers/usb/gadget/amd5536udc.c:3285:9: warning: Using plain integer as NULL pointer
drivers/usb/gadget/amd5536udc.c:3293:9: warning: Using plain integer as NULL pointer
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/usb/gadget/amd5536udc.c | 10 +++++-----
drivers/usb/host/ohci-sm501.c | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
--- a/drivers/usb/gadget/amd5536udc.c
+++ b/drivers/usb/gadget/amd5536udc.c
@@ -3251,7 +3251,7 @@ static int udc_pci_probe(
/* pci setup */
if (pci_enable_device(pdev) < 0) {
kfree(dev);
- dev = 0;
+ dev = NULL;
retval = -ENODEV;
goto finished;
}
@@ -3264,7 +3264,7 @@ static int udc_pci_probe(
if (!request_mem_region(resource, len, name)) {
dev_dbg(&pdev->dev, "pci device used already\n");
kfree(dev);
- dev = 0;
+ dev = NULL;
retval = -EBUSY;
goto finished;
}
@@ -3274,7 +3274,7 @@ static int udc_pci_probe(
if (dev->virt_addr == NULL) {
dev_dbg(&pdev->dev, "start address cannot be mapped\n");
kfree(dev);
- dev = 0;
+ dev = NULL;
retval = -EFAULT;
goto finished;
}
@@ -3282,7 +3282,7 @@ static int udc_pci_probe(
if (!pdev->irq) {
dev_err(&dev->pdev->dev, "irq not set\n");
kfree(dev);
- dev = 0;
+ dev = NULL;
retval = -ENODEV;
goto finished;
}
@@ -3290,7 +3290,7 @@ static int udc_pci_probe(
if (request_irq(pdev->irq, udc_irq, IRQF_SHARED, name, dev) != 0) {
dev_dbg(&dev->pdev->dev, "request_irq(%d) fail\n", pdev->irq);
kfree(dev);
- dev = 0;
+ dev = NULL;
retval = -EBUSY;
goto finished;
}
--- a/drivers/usb/host/ohci-sm501.c
+++ b/drivers/usb/host/ohci-sm501.c
@@ -90,7 +90,7 @@ static int ohci_hcd_sm501_drv_probe(stru
struct device *dev = &pdev->dev;
struct resource *res, *mem;
int retval, irq;
- struct usb_hcd *hcd = 0;
+ struct usb_hcd *hcd = NULL;
irq = retval = platform_get_irq(pdev, 0);
if (retval < 0)
Patches currently in gregkh-2.6 which might be from harvey.harrison@gmail.com are
usb.next/usb-fix-integer-as-null-pointer-warnings-found-by-sparse.patch
usb.next/usb-use-get_unaligned_-helpers-for-kl5kusb105-driver.patch
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-05-08 22:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-30 22:03 [PATCH 03/10] usb: fix integer as NULL pointer warnings Harvey Harrison
2008-05-01 23:02 ` Andrew Morton
2008-05-01 23:07 ` Harvey Harrison
2008-05-08 22:38 ` patch usb-fix-integer-as-null-pointer-warnings-found-by-sparse.patch added to gregkh-2.6 tree gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox