* [PATCH 10/10] Make one-bit signed bitfields unsigned
@ 2008-04-30 22:03 Harvey Harrison
0 siblings, 0 replies; only message in thread
From: Harvey Harrison @ 2008-04-30 22:03 UTC (permalink / raw)
To: Andrew Morton; +Cc: LKML
Otherwise it can only take the values 0/-1 which doesn't seem to
have been intended.
drivers/input/tablet/wacom.h:108:12: error: dubious one-bit signed bitfield
drivers/mmc/host/sdhci.h:190:20: error: dubious one-bit signed bitfield
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
drivers/input/tablet/wacom.h | 2 +-
drivers/mmc/host/sdhci.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/tablet/wacom.h b/drivers/input/tablet/wacom.h
index 706619d..ca62ec6 100644
--- a/drivers/input/tablet/wacom.h
+++ b/drivers/input/tablet/wacom.h
@@ -105,7 +105,7 @@ struct wacom {
struct urb *irq;
struct wacom_wac * wacom_wac;
struct mutex lock;
- int open:1;
+ unsigned int open:1;
char phys[32];
};
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index 7fb02e1..299118d 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -187,7 +187,7 @@ struct sdhci_host {
struct mmc_request *mrq; /* Current request */
struct mmc_command *cmd; /* Current command */
struct mmc_data *data; /* Current data request */
- int data_early:1; /* Data finished before cmd */
+ unsigned int data_early:1; /* Data finished before cmd */
struct scatterlist *cur_sg; /* We're working on this */
int num_sg; /* Entries left */
--
1.5.5.1.305.g7c84
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-04-30 22:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-30 22:03 [PATCH 10/10] Make one-bit signed bitfields unsigned Harvey Harrison
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox