From: Harvey Harrison <harvey.harrison@gmail.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 02/10] scsi: fix integer as NULL pointer warnings
Date: Wed, 30 Apr 2008 15:34:48 -0700 [thread overview]
Message-ID: <1209594888.24729.130.camel@brick> (raw)
In-Reply-To: <1209594551.3774.37.camel@localhost.localdomain>
On Wed, 2008-04-30 at 17:29 -0500, James Bottomley wrote:
> On Wed, 2008-04-30 at 15:03 -0700, Harvey Harrison wrote:
> > drivers/scsi/FlashPoint.c:906:9: warning: Using plain integer as NULL pointer
> > drivers/scsi/FlashPoint.c:907:53: warning: Using plain integer as NULL pointer
> > drivers/scsi/FlashPoint.c:922:1: warning: Using plain integer as NULL pointer
> The flashpoint initialiser changes look wrong: {0} is a conventional
> notation for zero initialise this structure. Sparse should probably be
> taught to recognise that.
Actually, looking closer, should this be initialized at all? Can we
just remove the initialization here and let them end up in .bss?
Harvey
next prev parent reply other threads:[~2008-04-30 22:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 22:03 [PATCH 02/10] scsi: fix integer as NULL pointer warnings Harvey Harrison
2008-04-30 22:29 ` James Bottomley
2008-04-30 22:34 ` Harvey Harrison [this message]
2008-04-30 22:54 ` James Bottomley
2008-05-01 21:50 ` Mark Harvey
2008-04-30 23:29 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209594888.24729.130.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox