Re: [PATCH 1/4] lib: add ascii hex helper functions

Harvey Harrison
2008-05-01T21:32:16Z

On Thu, 2008-05-01 at 14:15 -0700, Andrew Morton wrote:
> On Thu, 01 May 2008 13:51:07 -0700
> Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> > Everyone rolls their own version around the tree, centralize
> > in lib/hexdump.c
> >
> > +extern const char hex_asc[];
> > +const char hexasc[16] = "0123456789abcdef";
>
> If I were a compiler I'd get upset about that.
>
> Honest, 24 hours really doesn't matter here. Do it carefully, do
> it right.

...insert something here about improving quality ;-)

Harvey