Re: [PATCH 1/4] lib: add ascii hex helper functions

Andrew Morton
2008-05-01T21:15:29Z

On Thu, 01 May 2008 13:51:07 -0700
Harvey Harrison <harvey.harrison@gmail.com> wrote:

> Everyone rolls their own version around the tree, centralize
> in lib/hexdump.c
>
> +extern const char hex_asc[];
> +const char hexasc[16] = "0123456789abcdef";

If I were a compiler I'd get upset about that.

Honest, 24 hours really doesn't matter here. Do it carefully, do
it right.