From: Harvey Harrison <harvey.harrison@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] lib: add ascii hex helper functions
Date: Thu, 01 May 2008 14:32:18 -0700 [thread overview]
Message-ID: <1209677538.24729.171.camel@brick> (raw)
In-Reply-To: <20080501141518.996edb65.akpm@linux-foundation.org>
On Thu, 2008-05-01 at 14:15 -0700, Andrew Morton wrote:
> On Thu, 01 May 2008 13:51:07 -0700
> Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> > Everyone rolls their own version around the tree, centralize
> > in lib/hexdump.c
> >
> > +extern const char hex_asc[];
> > +const char hexasc[16] = "0123456789abcdef";
>
> If I were a compiler I'd get upset about that.
>
> Honest, 24 hours really doesn't matter here. Do it carefully, do
> it right.
...insert something here about improving quality ;-)
Harvey
next prev parent reply other threads:[~2008-05-01 21:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-01 20:51 [PATCH 1/4] lib: add ascii hex helper functions Harvey Harrison
2008-05-01 21:15 ` Andrew Morton
2008-05-01 21:32 ` Harvey Harrison [this message]
2008-05-01 21:28 ` Joe Perches
2008-05-01 21:35 ` Harvey Harrison
2008-05-01 21:44 ` Joe Perches
2008-05-01 21:58 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209677538.24729.171.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox