From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765312AbYEBCOP (ORCPT ); Thu, 1 May 2008 22:14:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755657AbYEBCOA (ORCPT ); Thu, 1 May 2008 22:14:00 -0400 Received: from wa-out-1112.google.com ([209.85.146.181]:35620 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754245AbYEBCOA (ORCPT ); Thu, 1 May 2008 22:14:00 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding; b=oBjgmXp5WBsnadp+D6cYLZYUnbzPKxv4cdWaZ7kiofp6NFydUMKuWMCyZxEMZUBU2y3rAs0LreWM67YEA91YMGxKAFBsLw3AFcKf0AR5lOFi6Tu2tutMu6gAdmPqCbifWp+FExPcwzPTb+QQ6XznRzYgHLIublINbXWmJF1yERA= Subject: Re: [PATCH 5/9] frv: gdb-stub.c use the common ascii hex helpers From: Harvey Harrison To: David Howells Cc: Andrew Morton , LKML In-Reply-To: <11442.1209694140@redhat.com> References: <1209683136.24729.207.camel@brick> <11442.1209694140@redhat.com> Content-Type: text/plain Date: Thu, 01 May 2008 19:14:21 -0700 Message-Id: <1209694461.24729.223.camel@brick> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2008-05-02 at 03:09 +0100, David Howells wrote: > Harvey Harrison wrote: > > > arch/frv/kernel/gdb-stub.c | 163 ++++++++++++++++++++------------------------ > > 1 files changed, 73 insertions(+), 90 deletions(-) > > Can you send me the base patch this is built on? These functions you're using > don't seem to be upstream. > > David They get introduced in 1/9: Subject: [PATCH 1/9] lib: add ascii hex helper functions Everyone rolls their own version around the tree, centralize in lib/hexdump.c Signed-off-by: Harvey Harrison --- include/linux/kernel.h | 6 +++++- lib/hexdump.c | 25 +++++++++++++++++++++++-- 2 files changed, 28 insertions(+), 3 deletions(-) diff --git a/include/linux/kernel.h b/include/linux/kernel.h index 4d46e29..20cae9a 100644 --- a/include/linux/kernel.h +++ b/include/linux/kernel.h @@ -276,7 +276,11 @@ extern void print_hex_dump(const char *level, const char *prefix_str, const void *buf, size_t len, bool ascii); extern void print_hex_dump_bytes(const char *prefix_str, int prefix_type, const void *buf, size_t len); -#define hex_asc(x) "0123456789abcdef"[x] + +extern const char hex_asc[]; +extern int hex_to_int(char c); +#define hex_asc_lo(x) hex_asc[((x) & 0x0f)] +#define hex_asc_hi(x) hex_asc[((x) & 0xf0) >> 4] #define pr_emerg(fmt, arg...) \ printk(KERN_EMERG fmt, ##arg) diff --git a/lib/hexdump.c b/lib/hexdump.c index 3435465..fa1a76e 100644 --- a/lib/hexdump.c +++ b/lib/hexdump.c @@ -12,6 +12,27 @@ #include #include +const char hex_asc[] = "0123456789abcdef"; + +/** + * hex_to_int - convert a single hex ASCII char to an integer value + * @ch: char to convert, not case sensitive [a-f][A-F][0-9] + * + * Returns -1 if the char is not a valid hexadecimal character + */ +int hex_to_int(char ch) +{ + /* + * Make ch lower-case, works only for digits and letters + */ + ch |= 0x20; + if (ch >= 'a' && ch <= 'f') + return ch - 'a' + 10; + if (ch >= '0' && ch <= '9') + return ch - '0'; + return -1; +} + /** * hex_dump_to_buffer - convert a blob of data to "hex ASCII" in memory * @buf: data blob to dump @@ -93,8 +114,8 @@ void hex_dump_to_buffer(const void *buf, size_t len, int rowsize, for (j = 0; (j < rowsize) && (j < len) && (lx + 4) < linebuflen; j++) { ch = ptr[j]; - linebuf[lx++] = hex_asc(ch >> 4); - linebuf[lx++] = hex_asc(ch & 0x0f); + linebuf[lx++] = hex_asc_hi(ch); + linebuf[lx++] = hex_asc_lo(ch); linebuf[lx++] = ' '; } ascii_column = 3 * rowsize + 2; -- 1.5.5.1.305.g7c84