[PATCH] fix irq flags in mac80211 code

[PATCH] fix irq flags in mac80211 code

[Steven Rostedt]

A file in the net/mac80211 directory uses "int" for flags. This can
cause hard to find bugs on some architectures. This patch converts the
flags to use "long" instead.

This bug was discovered by doing an allyesconfig make on the -rt kernel
where checks are done to ensure all flags are of size sizeof(long).

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
 net/mac80211/rc80211_pid_debugfs.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-compile.git/net/mac80211/rc80211_pid_debugfs.c
===================================================================
--- linux-compile.git.orig/net/mac80211/rc80211_pid_debugfs.c	2008-05-01 16:59:01.000000000 -0400
+++ linux-compile.git/net/mac80211/rc80211_pid_debugfs.c	2008-05-01 18:32:08.000000000 -0400
@@ -85,7 +85,7 @@ static int rate_control_pid_events_open(
 	struct rc_pid_sta_info *sinfo = inode->i_private;
 	struct rc_pid_event_buffer *events = &sinfo->events;
 	struct rc_pid_events_file_info *file_info;
-	unsigned int status;
+	unsigned long status;

 	/* Allocate a state struct */
 	file_info = kmalloc(sizeof(*file_info), GFP_KERNEL);
@@ -135,7 +135,7 @@ static ssize_t rate_control_pid_events_r
 	char pb[RC_PID_PRINT_BUF_SIZE];
 	int ret;
 	int p;
-	unsigned int status;
+	unsigned long status;

 	/* Check if there is something to read. */
 	if (events->next_entry == file_info->next_entry) {

Re: [PATCH] fix irq flags in mac80211 code

[Mattias Nissler]

On Thu, 2008-05-01 at 18:48 -0400, Steven Rostedt wrote:
> A file in the net/mac80211 directory uses "int" for flags. This can
> cause hard to find bugs on some architectures. This patch converts the
> flags to use "long" instead.
> 
> This bug was discovered by doing an allyesconfig make on the -rt kernel
> where checks are done to ensure all flags are of size sizeof(long).

Good catch, thanks.

Mattias