public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Miquel van Smoorenburg <miquels@cistron.nl>
To: Chris Knadle <Chris.Knadle@coredump.us>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Adrian Bunk <bunk@kernel.org>,
	venkatesh.pallipadi@intel.com, davem@davemloft.net,
	trini@kernel.crashing.org, mingo@elte.hu, tglx@linutronix.de,
	hpa@zytor.com, linux-kernel@vger.kernel.org,
	suresh.b.siddha@intel.com
Subject: Re: huge gcc 4.1.{0,1} __weak problem
Date: Fri, 02 May 2008 11:19:19 +0200	[thread overview]
Message-ID: <1209719959.11360.47.camel@localhost.localdomain> (raw)
In-Reply-To: <20080501235558.GA20637@orac.ofobscurity.com>

On Thu, 2008-05-01 at 19:55 -0400, Chris Knadle wrote:
> On Thu, 1 May 2008, Linus Torvalds wrote:
> > On Thu, 1 May 2008, Andrew Morton wrote:
> > > > 
> > > > I see only the following choices:
> > > > - remove __weak and replace all current usages
> > > > - move all __weak functions into own files, and ensure that also happens
> > > >   for future usages
> > > > - #error for gcc 4.1.{0,1}
> > > 
> > > Can we detect the {0,1}?  __GNUC_EVEN_MORE_MINOR__?
> >
> > It's __GNUC_PATCHLEVEL__, I believe.
> >
> > So yes, we can distinguish 4.1.2 (good, and very common) from 4.1.{0,1} 
> > (bad, and rather uncommon).
> > And yes, considering that 4.1.1 (and even more so 4.1.0) should be rare to 
> > begin with, I think it's better to just not support it.

>    Unfortunately Debian Stable (i.e. Etch), which is relatively popular for server 
> use, is still using 4.1.1  :-(  (The current gcc package is gcc-4.1.1-21)

Well the package version string is 4.1.1, but the compiler thinks it's
4.1.2, at least on i386, amd64 and ia64:

$ cc -v
gcc version 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)

A small test program agrees:

        printf("%d\n", __GNUC_PATCHLEVEL__);
$ ./a.out 
2

Mike.


  reply	other threads:[~2008-05-02  9:30 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-01 23:55 huge gcc 4.1.{0,1} __weak problem Chris Knadle
2008-05-02  9:19 ` Miquel van Smoorenburg [this message]
2008-05-02  9:55 ` Alistair John Strachan
2008-05-02 10:43   ` Sam Ravnborg
2008-05-02 11:48     ` Alistair John Strachan
2008-05-02 13:57       ` Sam Ravnborg
2008-05-02 14:11         ` Jakub Jelinek
2008-05-02 15:26           ` Alistair John Strachan
2008-05-02 14:57         ` Jeremy Fitzhardinge
2008-05-02 12:40   ` Sven-Haegar Koch
  -- strict thread matches above, loose matches on Subject: below --
2008-04-30  1:31 [PATCH] /dev/mem gcc weak function workaround Venki Pallipadi
2008-04-30  4:28 ` David Miller
2008-04-30 12:49   ` Pallipadi, Venkatesh
2008-05-01 21:56     ` huge gcc 4.1.{0,1} __weak problem Adrian Bunk
2008-05-01 22:20       ` Andrew Morton
2008-05-01 22:27         ` Linus Torvalds
2008-05-01 22:33           ` Andrew Morton
2008-05-01 23:24             ` Tom Rini
2008-05-01 23:59               ` Andrew Morton
2008-05-02  0:21                 ` Justin Mattock
2008-05-02  7:18                 ` Vegard Nossum
2008-05-02 13:43                   ` Theodore Tso
2008-05-02  8:10                 ` Adrian Bunk
2008-05-02  9:09                 ` Andi Kleen
2008-05-01 22:35           ` Venki Pallipadi
2008-05-01 22:42             ` Andrew Morton
2008-05-01 22:49               ` Jakub Jelinek
2008-05-01 23:21               ` Tom Rini
2008-05-01 23:30                 ` Venki Pallipadi
2008-05-02  0:34                   ` Linus Torvalds
2008-05-02  0:39                     ` Suresh Siddha
2008-05-02 21:11                       ` Jeremy Fitzhardinge
2008-05-02 22:02                         ` David Miller
2008-05-01 23:23             ` Tom Rini
2008-05-01 22:51           ` David Miller
2008-05-02 21:09       ` Jeremy Fitzhardinge
2008-05-02 21:19         ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1209719959.11360.47.camel@localhost.localdomain \
    --to=miquels@cistron.nl \
    --cc=Chris.Knadle@coredump.us \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@kernel.org \
    --cc=davem@davemloft.net \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=trini@kernel.crashing.org \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox