From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933823AbYEBPD6 (ORCPT ); Fri, 2 May 2008 11:03:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756561AbYEBPDt (ORCPT ); Fri, 2 May 2008 11:03:49 -0400 Received: from accolon.hansenpartnership.com ([76.243.235.52]:56072 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756289AbYEBPDs (ORCPT ); Fri, 2 May 2008 11:03:48 -0400 Subject: Re: [PATCH #repost] SCSI: megaraid, fix suspend/resume sections From: James Bottomley To: Jiri Slaby Cc: Andrew Morton , megaraidlinux@lsi.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <481B2CB8.2000307@gmail.com> References: <1209657362-20300-1-git-send-email-jirislaby@gmail.com> <20080501142305.77433e50.akpm@linux-foundation.org> <481A3781.8080100@gmail.com> <1209679559.14864.33.camel@localhost.localdomain> <20080501153048.2a8d356f.akpm@linux-foundation.org> <1209740170.3121.24.camel@localhost.localdomain> <481B2CB8.2000307@gmail.com> Content-Type: text/plain Date: Fri, 02 May 2008 10:03:45 -0500 Message-Id: <1209740625.3121.27.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-4.fc8) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2008-05-02 at 17:01 +0200, Jiri Slaby wrote: > James Bottomley napsal(a): > >>> could we not at least make the machinery do something vaguely > >>> useful and expand it to confine the pm routines to sections which can be > >>> discarded if CONFIG_PM is n? > >> a) it would need to be discarded at link-time, ideally. > > > > Yes, the same way the exit sections are: as linker discards. We also > > have the mechanics for runtime discards which is useful for modules > > No it doesn't, exits are discarded at runtime only. At least on x86. No what doesn't? I said we have the mechanics to discard both at link and at run time. I think you'll find that .exitcall.exit is link time discarded on x86 and the others are runtime discarded. James