RE: [microblaze-uclinux] [PATCH 04/56] microblaze_v2: Open firmware files

Stephen Neuendorffer
2008-05-07T20:14:46Z

I'm don't think all of this code should move.

In particular, parts of prom_parse.c dealing with irqs handle virtual
irqs in a powerpc specific way.
I also think ifdef PPC_PSERIES and PPC_64 and PPC_32 in prom.c are
indicative of the fact that alot of this is dealing with
architecture-specific issues.

Probably some parts of these files, but it's going to take some tweezing
to figure out what parts.

Steve

> -----Original Message-----
> From: owner-microblaze-uclinux@itee.uq.edu.au
[mailto:owner-microblaze-uclinux@itee.uq.edu.au] On
> Behalf Of Michal Simek
> Sent: Wednesday, May 07, 2008 12:12 PM
> To: Grant Likely
> Cc: monstr@seznam.cz; microblaze-uclinux@itee.uq.edu.au;
linux-kernel@vger.kernel.org; arnd@arndb.de;
> linux-arch@vger.kernel.org; John Linn; john.williams@petalogix.com;
matthew@wil.cx;
> will.newton@gmail.com; drepper@redhat.com; Paul Mackerras; Stephen
Rothwell; David Miller
> Subject: Re: [microblaze-uclinux] [PATCH 04/56] microblaze_v2: Open
firmware files
>
> Hi Grant,
>
> you understand I use of_device, of_platform and prom_parse. If you do
diff
> between them they will almost the same. One small difference is in
prom.c file.
>
> I hope we will move these files to drivers/of.
> This is not only question to me.
>
> Paul, Steve and David: Can I moved these three files to drivers/of?
>
> Michal
>
> >> Hi Steve,
> >>
> >> you are right. Microblaze don't need CONFIG_PPC_something but
> >> I keep this in files because it will be easier to move this to
better place.
> >> I wanted to sort what Microblaze don't use.
> >>
> >> I need to talk with people from sparc and powerpc what we can move
and where.
> >> I see the best way to push these files to microblaze/kernel/ and
then sychronize
> >> them with one patch - all archs together.
> >
> > I would disagree. I think its better to push (and get merged)
patches
> > to move the files first; then add microblaze on top of that. You
can
> > start getting stuff merged piecemeal that way instead of relying on
> > getting your entire patch series merged at once.
> >
> > However, that's just my opinion, others may look at it differently.
> >
> > Cheers,
> > g.
> >
>
> ___________________________
> microblaze-uclinux mailing list
> microblaze-uclinux@itee.uq.edu.au
> Project Home Page :
http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
> Mailing List Archive :
http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/
>