Re: [PATCH 02/56] microblaze_v2: Makefiles for Microblaze cpu

Michal Simek
2008-05-06T09:03:35Z

Hi John,

>> --- /dev/null
>> +++ b/arch/microblaze/Makefile
>> @@ -0,0 +1,63 @@
>> +UTS_SYSNAME = -DUTS_SYSNAME=\"uClinux\"
>> +
>> +# What CPU vesion are we building for, and crack it open
>> +# as major.minor.rev
>> +CPU_VER=$(subst ",,$(CONFIG_XILINX_MICROBLAZE0_HW_VER) )
>> +CPU_MAJOR=$(shell echo $(CPU_VER) | cut -d '.' -f 1)
>> +CPU_MINOR=$(shell echo $(CPU_VER) | cut -d '.' -f 2)
>> +CPU_REV=$(shell echo $(CPU_VER) | cut -d '.' -f 3)
>
> No doubt there's some cleaner shell-fu to do this but I'm not
> complaining as I'm responsible for the original yucky version!

I think you told me that toolchain can use this flags. This is not pain for now.
I'll add to my future plans.

>> --- /dev/null
>> +++ b/arch/microblaze/platform/Makefile
>> @@ -0,0 +1,3 @@
>> +#
>> +# Makefile for arch/microblaze/platform directory
>> +#
>
> How about a single
>
> obj-$(CONFIG_PLATFORM_GENERIC) += generic/
>
> to show how platform-specific setup code can be added (even though
> there's none in the default generic target)?

We'll add this to Microblaze readme file. Chapter: how to add platform specific
files.

M