Re: [PATCH 01/56] microblaze_v2: Kconfig patches

Michal Simek
2008-05-05T06:35:15Z

Hi Grant,

>> From: Michal Simek <monstr@monstr.eu>
>>
>>
>> Signed-off-by: Michal Simek <monstr@monstr.eu>
>
>> diff --git a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig
>> new file mode 100644
>> index 0000000..49767d1
>> --- /dev/null
>> +++ b/arch/microblaze/Kconfig
> <snip>
>> +config XILINX_UNCACHED_SHADOW
>> + bool "Are you using uncached shadow for RAM ?"
>> + depends on MICROBLAZE
>
> Isn't CONFIG_MICROBLAZE a given?

I forget to remove this option. I'll remove consistent.c file where was this
choice used.

>> diff --git a/arch/microblaze/platform/Kconfig.platform b/arch/microblaze/platform/Kconfig.platform
>> new file mode 100644
>> index 0000000..64cbb80
>> --- /dev/null
>> +++ b/arch/microblaze/platform/Kconfig.platform
> <snip>
>> +config HACK
>> + bool "Increase performance"
>> + default y
>
> Is this appropriate for mainline? If so, it should have a better
> description. :-)

:-) Yes. A little bit.

Michal