Re: [PATCH 08/56] microblaze_v2: Interrupt handling, timer support, supported function

Thomas Gleixner
2008-05-11T14:38:29Z

Michal,

On Sun, 11 May 2008, Michal Simek wrote:
> >
> > Please split this modification code out into a separate function. The
> > same code is used below.
>
> Add Macro.

Please use a (inline) function whenever possible. Macros are harder to
read and not type safe.

> > Can you please move a new architecture to clockevents / clocksource
> > right from the beginning ? No need to invent another incompatible set
> > of time(r) related functions.
>
> I move whole code to GENERIC_TIME. Did you meant any others changes?

GENERIC_TIME and GENERIC_CLOCKEVENTS. You get high resolution timers
and dynamic ticks for free when your timer hardware allows it.

> >> +#define NO_IRQ (-1)
> >> +
> >> +static inline int irq_canonicalize(int irq)
> >> +{
> >> + return (irq);
> >> +}
> >
> > Why is this needed ? Any users ?
>
> is used in serial_core.c
> 684 new_serial.irq = irq_canonicalize(new_serial.irq);

Doh, forgot about that one.

Thanks,
tglx