Re: [PATCH 24/56] microblaze_v2: time support

John Williams
2008-05-06T22:51:29Z

Hi Michal,

On Tue, 2008-05-06 at 15:26 +0200, Michal Simek wrote:

> I am not discouraged from negative comments. I got school from Wolfgang Denk on
> U-BOOT project. (Thanks Wolfgang :-))
>
> I only want to direct this to right way. That's all. And positive ACK to some
> files give me better view what's wrong. :-)

I'd like to echo the other comments so far -you are doing a great job.
I'd take silence on a patch as cautious agreement - like Steve I'm
waiting for the dust to settle to do a build and boot test (probably on
v3 of your patchset).

Most of this code has been running happily for >18 months in the
PetaLogix 2.6.20 kernel, and you tested your OF changes pretty well over
Oct-Jan. So, I'm happy enough with the underlying implementation, it's
really just a case of meeting the kernel.org gatekeeper's standards.

The syscall interface is the last prickly one, but we'll get there.

Cheers,

John