Re: [PATCH 17/56] microblaze_v2: checksum support

Michal Simek
2008-05-05T14:04:19Z

Hi,

>> + *
>> + * INET An implementation of the TCP/IP protocol suite for the LINUX
>> + * operating system. INET is implemented using the BSD Socket
>> + * interface as the means of communication with the user level.
>> + *
>> + * IP/TCP/UDP checksumming routines
>> + *
>> + * Authors: Jorge Cwik, <jorge@laser.satlink.net>
>> + * Arnt Gulbrandsen, <agulbra@nvg.unit.no>
>> + * Tom May, <ftom@netcom.com>
>> + * Andreas Schwab, <schwab@issan.informatik.uni-dortmund.de>
>> + * Lots of code moved from tcp.c and ip.c; see those files
>> + * for more names.
>
> This is a pretty generic implementation, and you copied it from another
> architecture. How about moving it from arch/microblaze/lib/ to lib/?
> I'd suggest building it conditionally under CONFIG_GENERIC_CSUM,
> which you def_bool in your architecture Kconfig.
>
> Arnd <><
I move checksum.c to /lib and checksum.h to asm-generic and add to GENERIC_CSUM
to Kconfig

6 config MICROBLAZE
7 def_bool y
8 select HAVE_LMB
9 select GENERIC_CSUM

M