Re: [PATCH 50/56] microblaze_v2: setup.h string.h thread_info.h

Michal Simek
2008-05-05T14:23:42Z

FIXED to r1.
M

>> +++ b/include/asm-microblaze/thread_info.h
>> @@ -0,0 +1,155 @@
>> +/*
>> + * include/asm-microblaze/thread_info.h
>> + *
>> + * This file is subject to the terms and conditions of the GNU General Public
>> + * License. See the file "COPYING" in the main directory of this archive
>> + * for more details.
>> + *
>> + * Copyright (C) 2006 Atmark Techno, Inc.
>> + */
>> +
>> +#ifndef _ASM_MICROBLAZE_THREAD_INFO_H
>> +#define _ASM_MICROBLAZE_THREAD_INFO_H
>> +
>> +#ifdef __KERNEL__
>> +
>> +/* we have 8k stack */
>
> Is it worth trialling a 4K stack on MicroBlaze?
>
>
>> +struct cpu_context {
>> + __u32 sp;
>
> I'd be happier to see this called r1. If mb-as doesn't accept "sp" as
> an alias for "r1", nor should we.
>
> ...
>
>> + __u32 r30;
>
> Is it worth a comment that r31 is absent because it's used as 'current'
> pointer, and -ffixed-r31 etc?
>
>
>
>
>