Re: [PATCH 45/56] microblaze_v2: headers simple files - empty or redirect to asm-generic

Stephen Rothwell
2008-05-06T14:47:29Z

[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]

On Mon, 05 May 2008 12:34:09 +1000 John Williams <john.williams@petalogix.com> wrote:
>
>
> > include/asm-microblaze/auxvec.h | 14 ++++++++++++++
> > include/asm-microblaze/cputime.h | 16 ++++++++++++++++
> > include/asm-microblaze/div64.h | 16 ++++++++++++++++
> > include/asm-microblaze/emergency-restart.h | 16 ++++++++++++++++
> > include/asm-microblaze/errno.h | 16 ++++++++++++++++
> > include/asm-microblaze/futex.h | 16 ++++++++++++++++
> > include/asm-microblaze/kdebug.h | 19 +++++++++++++++++++
> > include/asm-microblaze/local.h | 16 ++++++++++++++++
> > include/asm-microblaze/mutex.h | 16 ++++++++++++++++
> > include/asm-microblaze/namei.h | 24 ++++++++++++++++++++++++
> > include/asm-microblaze/percpu.h | 16 ++++++++++++++++
> > include/asm-microblaze/resource.h | 16 ++++++++++++++++
> > include/asm-microblaze/user.h | 18 ++++++++++++++++++
>
> These are all just includes of asm-generic/* (hooray!).

Absolutely, but is it really necessary to have 14-16 lines of comment
(including a copyright notice) for a file whose single real line is just
to include another file? i.e. reduce all these to 1 line files.

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]