Re: [PATCH 36/56] microblaze_v2: dma support

Geert Uytterhoeven
2008-05-05T06:45:50Z

On Mon, 5 May 2008, John Williams wrote:
> > +++ b/include/asm-microblaze/scatterlist.h
> > @@ -0,0 +1,21 @@
> > +/*
> > + * include/asm-microblaze/scatterlist.h
> > + *
> > + * This file is subject to the terms and conditions of the GNU General Public
> > + * License. See the file "COPYING" in the main directory of this archive
> > + * for more details.
> > + *
> > + * Copyright (C) 2006 Atmark Techno, Inc.
> > + */
> > +
> > +#ifndef _ASM_MICROBLAZE_SCATTERLIST_H
> > +#define _ASM_MICROBLAZE_SCATTERLIST_H
> > +
> > +struct scatterlist {
> > + unsigned long page_link;
> > + unsigned int offset;
> > + dma_addr_t dma_address;
> > + unsigned int length;
> > +};
> > +
> > +#endif /* _ASM_MICROBLAZE_SCATTERLIST_H */
>
> Is this worthy of promotion to asm-generic/scatterlist.h?

after moving dma_address one position up in the structure, as dma_addr_t may be
64-bit?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds