Re: [PATCH] clocksource: shift helper

[Daniel Walker <dwalker@mvista.com>]

On Tue, 2008-05-06 at 22:25 +0200, Thomas Gleixner wrote:
> On Tue, 6 May 2008, Daniel Walker wrote:
> > On Tue, 2008-05-06 at 02:52 +0200, Thomas Gleixner wrote:
> > > On Thu, 1 May 2008, Daniel Walker wrote:
> > > 
> > > > This is a little helper I pulled from the mips tree.
> > > ... 
> > > > Signed-off-by: Daniel Walker <dwalker@mvista.com>
> > > 
> > > And who is the original author of this little helper in the MIPS tree?
> > 
> > commit 16b7b2ac0148e839da86af8747b6fa4aad43a9b7
> > Author: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> 
> Wouldn't it be appropriate to assign the authorship in the usual form
> i.e.:
> 
> From: Atsushi Nemoto <anemo@mba.ocn.ne.jp> 
> 
> on top of the patch and keep the original changelog message intact
> including the Signed-off-by of the author and Ralf ?
> 
> Aside of the broken S-O-B chain this is a blatant usurpation of
> somebody else's work.
> 

I took a function and modified it for my usage, which happens all the
time.

I'd be fine if Atsushi wants to sign off on the patch.

Daniel