Re: [PATCH] clocksource: shift helper

[Daniel Walker <dwalker@mvista.com>]

On Tue, 2008-05-06 at 22:53 +0200, Thomas Gleixner wrote:
> 
> And your description led me to the assumption that the code was pulled
> from the MIPS git tree and not from the MIPS architecture code in
> mainline. Everyone else I talked to was having the same impression.
> 
> I was wrong, but can you understand that your sloppy wording "pulled
> from the MIPS tree" along with the fact that you just copied code
> instead of moving it into the generic space and cleanup the MIPS code
> where it is duplicated from is causing such a misunderstanding ?

You could have asked me if it was mainline or not. I can see how words
could be misunderstood .

> I'm fine with the change itself, but it needs to move the code out of
> MIPS in the first place and not just duplicating code for no good
> reason.

I can work with Atsushi, but I still think the generic version should be
merged. We at least would need it in order to modify the mips code.

Daniel