* [PATCH] i2c: cs8427.c use put_unaligned helper
@ 2008-05-07 19:59 Harvey Harrison
2008-05-08 13:40 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-05-07 19:59 UTC (permalink / raw)
To: Andrew Morton, Takashi Iwai; +Cc: LKML
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
sound/i2c/cs8427.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/sound/i2c/cs8427.c b/sound/i2c/cs8427.c
index e57e9cb..9c3d361 100644
--- a/sound/i2c/cs8427.c
+++ b/sound/i2c/cs8427.c
@@ -23,6 +23,7 @@
#include <linux/slab.h>
#include <linux/delay.h>
#include <linux/init.h>
+#include <asm/unaligned.h>
#include <sound/core.h>
#include <sound/control.h>
#include <sound/pcm.h>
@@ -264,10 +265,7 @@ int snd_cs8427_create(struct snd_i2c_bus *bus,
goto __fail;
}
/* write default channel status bytes */
- buf[0] = ((unsigned char)(SNDRV_PCM_DEFAULT_CON_SPDIF >> 0));
- buf[1] = ((unsigned char)(SNDRV_PCM_DEFAULT_CON_SPDIF >> 8));
- buf[2] = ((unsigned char)(SNDRV_PCM_DEFAULT_CON_SPDIF >> 16));
- buf[3] = ((unsigned char)(SNDRV_PCM_DEFAULT_CON_SPDIF >> 24));
+ put_unaligned_le32(SNDRV_PCM_DEFAULT_CON_SPDIF, buf);
memset(buf + 4, 0, 24 - 4);
if (snd_cs8427_send_corudata(device, 0, buf, 24) < 0)
goto __fail;
--
1.5.5.1.404.g981f6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c: cs8427.c use put_unaligned helper
2008-05-07 19:59 [PATCH] i2c: cs8427.c use put_unaligned helper Harvey Harrison
@ 2008-05-08 13:40 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2008-05-08 13:40 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Andrew Morton, LKML
At Wed, 07 May 2008 12:59:27 -0700,
Harvey Harrison wrote:
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Thanks, applied to ALSA tree.
Takashi
> ---
> sound/i2c/cs8427.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/sound/i2c/cs8427.c b/sound/i2c/cs8427.c
> index e57e9cb..9c3d361 100644
> --- a/sound/i2c/cs8427.c
> +++ b/sound/i2c/cs8427.c
> @@ -23,6 +23,7 @@
> #include <linux/slab.h>
> #include <linux/delay.h>
> #include <linux/init.h>
> +#include <asm/unaligned.h>
> #include <sound/core.h>
> #include <sound/control.h>
> #include <sound/pcm.h>
> @@ -264,10 +265,7 @@ int snd_cs8427_create(struct snd_i2c_bus *bus,
> goto __fail;
> }
> /* write default channel status bytes */
> - buf[0] = ((unsigned char)(SNDRV_PCM_DEFAULT_CON_SPDIF >> 0));
> - buf[1] = ((unsigned char)(SNDRV_PCM_DEFAULT_CON_SPDIF >> 8));
> - buf[2] = ((unsigned char)(SNDRV_PCM_DEFAULT_CON_SPDIF >> 16));
> - buf[3] = ((unsigned char)(SNDRV_PCM_DEFAULT_CON_SPDIF >> 24));
> + put_unaligned_le32(SNDRV_PCM_DEFAULT_CON_SPDIF, buf);
> memset(buf + 4, 0, 24 - 4);
> if (snd_cs8427_send_corudata(device, 0, buf, 24) < 0)
> goto __fail;
> --
> 1.5.5.1.404.g981f6
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-08 13:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-07 19:59 [PATCH] i2c: cs8427.c use put_unaligned helper Harvey Harrison
2008-05-08 13:40 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox