From: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Gregory Haskins <ghaskins@novell.com>,
linux-kernel@vger.kernel.org, David Bahi <dbahi@novell.com>
Subject: Re: [PATCH] sched: fix SCHED_OTHER balance iterator to include all tasks
Date: Thu, 08 May 2008 10:11:25 +0200 [thread overview]
Message-ID: <1210234285.13978.172.camel@twins> (raw)
In-Reply-To: <20080506120616.GI32591@elte.hu>
On Tue, 2008-05-06 at 14:06 +0200, Ingo Molnar wrote:
> * Gregory Haskins <ghaskins@novell.com> wrote:
>
> > Hi Ingo,
> > The follow patch applies to sched-devel. I know the original
> > function was somehow trying to protect against dequeueing by
> > pre-iterating. I am not sure if I captured the intent properly in
> > that regard. What I can say is that the old algorithm would miss
> > tasks, and that is now fixed. It may need further adjustment if I
> > missed the pre-iterating operation.
> >
> > Hi Peter,
> > I was wrong earlier when I mentioned there might be a problem with
> > entity_is_task(). I think this was the root cause of what I was
> > seeing. Sorry for the red-herring.
>
> applied Gregory, thanks. Nice fix! Peter, do you concur with Gregory's
> analysis?
Yeah,
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
prev parent reply other threads:[~2008-05-08 8:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 14:31 [PATCH] sched: fix SCHED_OTHER balance iterator to include all tasks Gregory Haskins
2008-05-06 12:06 ` Ingo Molnar
2008-05-08 8:11 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210234285.13978.172.camel@twins \
--to=peterz@infradead.org \
--cc=dbahi@novell.com \
--cc=ghaskins@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox