From: Bryan Wu <cooloney@kernel.org>
To: dbrownell@users.sourceforge.net, dmitry.torokhov@gmail.com,
philipp.zabel@gmail.com
Cc: linux-kernel@vger.kernel.org,
Michael Hennerich <michael.hennerich@analog.com>,
Bryan Wu <cooloney@kernel.org>
Subject: [PATCH 1/1] [INPUT/KEYPAD] gpio keypad: Replace current blackfin specific pfbutton driver with kernel generic gpio key driver
Date: Mon, 12 May 2008 18:17:17 +0800 [thread overview]
Message-ID: <1210587437-9751-1-git-send-email-cooloney@kernel.org> (raw)
From: Michael Hennerich <michael.hennerich@analog.com>
It's an actual deficiency in the hardware that we can't address,
so it needs to be worked around in software.
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
---
drivers/input/keyboard/gpio_keys.c | 15 ++++++++++++++-
1 files changed, 14 insertions(+), 1 deletions(-)
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index bbd00c3..d856eb9 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -26,6 +26,18 @@
#include <asm/gpio.h>
+#if defined(CONFIG_BLACKFIN) && !defined(BF548_FAMILY)
+
+/*
+ * On some Blackfin CPUs reading edge triggered
+ * GPIOs doesn't return the current value
+ */
+
+#define GPIOKEYS_EDGE_SENSE(x) set_gpio_edge(gpio, x)
+#else
+#define GPIOKEYS_EDGE_SENSE(x) do {} while (0)
+#endif
+
static irqreturn_t gpio_keys_isr(int irq, void *dev_id)
{
int i;
@@ -39,8 +51,9 @@ static irqreturn_t gpio_keys_isr(int irq, void *dev_id)
if (irq == gpio_to_irq(gpio)) {
unsigned int type = button->type ?: EV_KEY;
+ GPIOKEYS_EDGE_SENSE(0);
int state = (gpio_get_value(gpio) ? 1 : 0) ^ button->active_low;
-
+ GPIOKEYS_EDGE_SENSE(1);
input_event(input, type, button->code, !!state);
input_sync(input);
return IRQ_HANDLED;
--
1.5.5
next reply other threads:[~2008-05-12 10:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 10:17 Bryan Wu [this message]
2008-05-12 11:27 ` [PATCH 1/1] [INPUT/KEYPAD] gpio keypad: Replace current blackfin specific pfbutton driver with kernel generic gpio key driver pHilipp Zabel
2008-05-12 11:42 ` Mike Frysinger
2008-05-12 12:11 ` Bryan Wu
2008-05-12 12:47 ` Mike Frysinger
2008-05-12 14:42 ` Bryan Wu
2008-05-12 16:54 ` David Brownell
2008-05-12 16:59 ` Mike Frysinger
2008-05-13 7:53 ` Hennerich, Michael
2008-05-12 16:55 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210587437-9751-1-git-send-email-cooloney@kernel.org \
--to=cooloney@kernel.org \
--cc=dbrownell@users.sourceforge.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox