[PATCH 1/1] [bluetooth]: fix bug - kernel warning detected if built in Bluetooth CF driver

[PATCH 1/1] [bluetooth]: fix bug - kernel warning detected if built in Bluetooth CF driver

[Bryan Wu]

From: Michael Hennerich <michael.hennerich@analog.com>

https://blackfin.uclinux.org/gf/project/uclinux-dist/tracker/?action=TrackerItemEdit&tracker_item_id=2650

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
---
 drivers/bluetooth/bluecard_cs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/bluetooth/bluecard_cs.c b/drivers/bluetooth/bluecard_cs.c
index bcf5792..3b330a0 100644
--- a/drivers/bluetooth/bluecard_cs.c
+++ b/drivers/bluetooth/bluecard_cs.c
@@ -867,7 +867,7 @@ static int bluecard_probe(struct pcmcia_device *link)
 
 	link->io.Attributes1 = IO_DATA_PATH_WIDTH_8;
 	link->io.NumPorts1 = 8;
-	link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
+	link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING | IRQ_HANDLE_PRESENT;
 	link->irq.IRQInfo1 = IRQ_LEVEL_ID;
 
 	link->irq.Handler = bluecard_interrupt;
-- 
1.5.5

Re: [PATCH 1/1] [bluetooth]: fix bug - kernel warning detected if built in Bluetooth CF driver

[Marcel Holtmann]

Hi Brian,

> https://blackfin.uclinux.org/gf/project/uclinux-dist/tracker/?action=TrackerItemEdit&tracker_item_id=2650
> 
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>
> ---
>  drivers/bluetooth/bluecard_cs.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/bluetooth/bluecard_cs.c b/drivers/bluetooth/bluecard_cs.c
> index bcf5792..3b330a0 100644
> --- a/drivers/bluetooth/bluecard_cs.c
> +++ b/drivers/bluetooth/bluecard_cs.c
> @@ -867,7 +867,7 @@ static int bluecard_probe(struct pcmcia_device *link)
>  
>  	link->io.Attributes1 = IO_DATA_PATH_WIDTH_8;
>  	link->io.NumPorts1 = 8;
> -	link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
> +	link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING | IRQ_HANDLE_PRESENT;
>  	link->irq.IRQInfo1 = IRQ_LEVEL_ID;
>  
>  	link->irq.Handler = bluecard_interrupt;

all Bluetooth PCMCIA drivers use an exclusive IRQ:

bluecard_cs.c:	link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
bt3c_cs.c:	link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
btuart_cs.c:	link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
dtl1_cs.c:	link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;

There was a reason for that when these drivers where written. I am not
sure if it is still valid or not. Does anybody at least have tested that
the cards still work if you use a shared IRQ.

Regards

Marcel

RE: [PATCH 1/1] [bluetooth]: fix bug - kernel warning detected ifbuilt in Bluetooth CF driver

[Hennerich, Michael]

>-----Original Message-----
>From: Marcel Holtmann [mailto:marcel@holtmann.org]
>Sent: Montag, 12. Mai 2008 15:10
>To: Bryan Wu
>Cc: linux-bluetooth@vger.kernel.org; linux-kernel@vger.kernel.org;
Michael
>Hennerich
>Subject: Re: [PATCH 1/1] [bluetooth]: fix bug - kernel warning detected
>ifbuilt in Bluetooth CF driver
>
>Hi Brian,
>
>> https://blackfin.uclinux.org/gf/project/uclinux-
>dist/tracker/?action=TrackerItemEdit&tracker_item_id=2650
>>
>> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
>> Signed-off-by: Bryan Wu <cooloney@kernel.org>
>> ---
>>  drivers/bluetooth/bluecard_cs.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/bluetooth/bluecard_cs.c
>b/drivers/bluetooth/bluecard_cs.c
>> index bcf5792..3b330a0 100644
>> --- a/drivers/bluetooth/bluecard_cs.c
>> +++ b/drivers/bluetooth/bluecard_cs.c
>> @@ -867,7 +867,7 @@ static int bluecard_probe(struct pcmcia_device
*link)
>>
>>  	link->io.Attributes1 = IO_DATA_PATH_WIDTH_8;
>>  	link->io.NumPorts1 = 8;
>> -	link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
>> +	link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING |
IRQ_HANDLE_PRESENT;
>>  	link->irq.IRQInfo1 = IRQ_LEVEL_ID;
>>
>>  	link->irq.Handler = bluecard_interrupt;
>
>all Bluetooth PCMCIA drivers use an exclusive IRQ:
>
>bluecard_cs.c:	link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
>IRQ_HANDLE_PRESENT;
>bt3c_cs.c:	link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
IRQ_HANDLE_PRESENT;
>btuart_cs.c:	link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
>IRQ_HANDLE_PRESENT;
>dtl1_cs.c:	link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
IRQ_HANDLE_PRESENT;
>
>There was a reason for that when these drivers where written. I am not
>sure if it is still valid or not. Does anybody at least have tested
that
>the cards still work if you use a shared IRQ.
>
>Regards
>
>Marcel

Please disregard this patch. It's a leftover and not really necessary.
Some time ago the Blackfin PCMCIA driver also requested the Card IRQ in
order to shut up some irq handling noise. However this is no longer the
case.

Best regards,
Michael

Re: [PATCH 1/1] [bluetooth]: fix bug - kernel warning detected ifbuilt in Bluetooth CF driver

[Bryan Wu]

On Tue, May 13, 2008 at 4:20 PM, Hennerich, Michael
<Michael.Hennerich@analog.com> wrote:
>
>
>
>  >-----Original Message-----
>  >From: Marcel Holtmann [mailto:marcel@holtmann.org]
>  >Sent: Montag, 12. Mai 2008 15:10
>  >To: Bryan Wu
>  >Cc: linux-bluetooth@vger.kernel.org; linux-kernel@vger.kernel.org;
>  Michael
>  >Hennerich
>  >Subject: Re: [PATCH 1/1] [bluetooth]: fix bug - kernel warning detected
>  >ifbuilt in Bluetooth CF driver
>  >
>  >Hi Brian,
>  >
>  >> https://blackfin.uclinux.org/gf/project/uclinux-
>  >dist/tracker/?action=TrackerItemEdit&tracker_item_id=2650
>  >>
>  >> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
>  >> Signed-off-by: Bryan Wu <cooloney@kernel.org>
>  >> ---
>  >>  drivers/bluetooth/bluecard_cs.c |    2 +-
>  >>  1 files changed, 1 insertions(+), 1 deletions(-)
>  >>
>  >> diff --git a/drivers/bluetooth/bluecard_cs.c
>  >b/drivers/bluetooth/bluecard_cs.c
>  >> index bcf5792..3b330a0 100644
>  >> --- a/drivers/bluetooth/bluecard_cs.c
>  >> +++ b/drivers/bluetooth/bluecard_cs.c
>  >> @@ -867,7 +867,7 @@ static int bluecard_probe(struct pcmcia_device
>  *link)
>  >>
>  >>      link->io.Attributes1 = IO_DATA_PATH_WIDTH_8;
>  >>      link->io.NumPorts1 = 8;
>  >> -    link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
>  >> +    link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING |
>  IRQ_HANDLE_PRESENT;
>  >>      link->irq.IRQInfo1 = IRQ_LEVEL_ID;
>  >>
>  >>      link->irq.Handler = bluecard_interrupt;
>  >
>  >all Bluetooth PCMCIA drivers use an exclusive IRQ:
>  >
>  >bluecard_cs.c: link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
>  >IRQ_HANDLE_PRESENT;
>  >bt3c_cs.c:     link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
>  IRQ_HANDLE_PRESENT;
>  >btuart_cs.c:   link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
>  >IRQ_HANDLE_PRESENT;
>  >dtl1_cs.c:     link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
>  IRQ_HANDLE_PRESENT;
>  >
>  >There was a reason for that when these drivers where written. I am not
>  >sure if it is still valid or not. Does anybody at least have tested
>  that
>  >the cards still work if you use a shared IRQ.
>  >
>  >Regards
>  >
>  >Marcel
>
>  Please disregard this patch. It's a leftover and not really necessary.
>  Some time ago the Blackfin PCMCIA driver also requested the Card IRQ in
>  order to shut up some irq handling noise. However this is no longer the
>  case.
>

OK, no problem. I will drop this.

Thanks
-Bryan