* [PATCH 1/1] [bluetooth]: fix bug - kernel warning detected if built in Bluetooth CF driver
@ 2008-05-12 10:22 Bryan Wu
2008-05-12 13:10 ` Marcel Holtmann
0 siblings, 1 reply; 4+ messages in thread
From: Bryan Wu @ 2008-05-12 10:22 UTC (permalink / raw)
To: marcel, linux-bluetooth; +Cc: linux-kernel, Michael Hennerich, Bryan Wu
From: Michael Hennerich <michael.hennerich@analog.com>
https://blackfin.uclinux.org/gf/project/uclinux-dist/tracker/?action=TrackerItemEdit&tracker_item_id=2650
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
---
drivers/bluetooth/bluecard_cs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/bluetooth/bluecard_cs.c b/drivers/bluetooth/bluecard_cs.c
index bcf5792..3b330a0 100644
--- a/drivers/bluetooth/bluecard_cs.c
+++ b/drivers/bluetooth/bluecard_cs.c
@@ -867,7 +867,7 @@ static int bluecard_probe(struct pcmcia_device *link)
link->io.Attributes1 = IO_DATA_PATH_WIDTH_8;
link->io.NumPorts1 = 8;
- link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
+ link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING | IRQ_HANDLE_PRESENT;
link->irq.IRQInfo1 = IRQ_LEVEL_ID;
link->irq.Handler = bluecard_interrupt;
--
1.5.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] [bluetooth]: fix bug - kernel warning detected if built in Bluetooth CF driver
2008-05-12 10:22 [PATCH 1/1] [bluetooth]: fix bug - kernel warning detected if built in Bluetooth CF driver Bryan Wu
@ 2008-05-12 13:10 ` Marcel Holtmann
2008-05-13 8:20 ` [PATCH 1/1] [bluetooth]: fix bug - kernel warning detected ifbuilt " Hennerich, Michael
0 siblings, 1 reply; 4+ messages in thread
From: Marcel Holtmann @ 2008-05-12 13:10 UTC (permalink / raw)
To: Bryan Wu; +Cc: linux-bluetooth, linux-kernel, Michael Hennerich
Hi Brian,
> https://blackfin.uclinux.org/gf/project/uclinux-dist/tracker/?action=TrackerItemEdit&tracker_item_id=2650
>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>
> ---
> drivers/bluetooth/bluecard_cs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/bluetooth/bluecard_cs.c b/drivers/bluetooth/bluecard_cs.c
> index bcf5792..3b330a0 100644
> --- a/drivers/bluetooth/bluecard_cs.c
> +++ b/drivers/bluetooth/bluecard_cs.c
> @@ -867,7 +867,7 @@ static int bluecard_probe(struct pcmcia_device *link)
>
> link->io.Attributes1 = IO_DATA_PATH_WIDTH_8;
> link->io.NumPorts1 = 8;
> - link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
> + link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING | IRQ_HANDLE_PRESENT;
> link->irq.IRQInfo1 = IRQ_LEVEL_ID;
>
> link->irq.Handler = bluecard_interrupt;
all Bluetooth PCMCIA drivers use an exclusive IRQ:
bluecard_cs.c: link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
bt3c_cs.c: link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
btuart_cs.c: link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
dtl1_cs.c: link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
There was a reason for that when these drivers where written. I am not
sure if it is still valid or not. Does anybody at least have tested that
the cards still work if you use a shared IRQ.
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 1/1] [bluetooth]: fix bug - kernel warning detected ifbuilt in Bluetooth CF driver
2008-05-12 13:10 ` Marcel Holtmann
@ 2008-05-13 8:20 ` Hennerich, Michael
2008-05-13 8:36 ` Bryan Wu
0 siblings, 1 reply; 4+ messages in thread
From: Hennerich, Michael @ 2008-05-13 8:20 UTC (permalink / raw)
To: Marcel Holtmann, Bryan Wu
Cc: linux-bluetooth, linux-kernel, Michael Hennerich
>-----Original Message-----
>From: Marcel Holtmann [mailto:marcel@holtmann.org]
>Sent: Montag, 12. Mai 2008 15:10
>To: Bryan Wu
>Cc: linux-bluetooth@vger.kernel.org; linux-kernel@vger.kernel.org;
Michael
>Hennerich
>Subject: Re: [PATCH 1/1] [bluetooth]: fix bug - kernel warning detected
>ifbuilt in Bluetooth CF driver
>
>Hi Brian,
>
>> https://blackfin.uclinux.org/gf/project/uclinux-
>dist/tracker/?action=TrackerItemEdit&tracker_item_id=2650
>>
>> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
>> Signed-off-by: Bryan Wu <cooloney@kernel.org>
>> ---
>> drivers/bluetooth/bluecard_cs.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/bluetooth/bluecard_cs.c
>b/drivers/bluetooth/bluecard_cs.c
>> index bcf5792..3b330a0 100644
>> --- a/drivers/bluetooth/bluecard_cs.c
>> +++ b/drivers/bluetooth/bluecard_cs.c
>> @@ -867,7 +867,7 @@ static int bluecard_probe(struct pcmcia_device
*link)
>>
>> link->io.Attributes1 = IO_DATA_PATH_WIDTH_8;
>> link->io.NumPorts1 = 8;
>> - link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
>> + link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING |
IRQ_HANDLE_PRESENT;
>> link->irq.IRQInfo1 = IRQ_LEVEL_ID;
>>
>> link->irq.Handler = bluecard_interrupt;
>
>all Bluetooth PCMCIA drivers use an exclusive IRQ:
>
>bluecard_cs.c: link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
>IRQ_HANDLE_PRESENT;
>bt3c_cs.c: link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
IRQ_HANDLE_PRESENT;
>btuart_cs.c: link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
>IRQ_HANDLE_PRESENT;
>dtl1_cs.c: link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
IRQ_HANDLE_PRESENT;
>
>There was a reason for that when these drivers where written. I am not
>sure if it is still valid or not. Does anybody at least have tested
that
>the cards still work if you use a shared IRQ.
>
>Regards
>
>Marcel
Please disregard this patch. It's a leftover and not really necessary.
Some time ago the Blackfin PCMCIA driver also requested the Card IRQ in
order to shut up some irq handling noise. However this is no longer the
case.
Best regards,
Michael
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] [bluetooth]: fix bug - kernel warning detected ifbuilt in Bluetooth CF driver
2008-05-13 8:20 ` [PATCH 1/1] [bluetooth]: fix bug - kernel warning detected ifbuilt " Hennerich, Michael
@ 2008-05-13 8:36 ` Bryan Wu
0 siblings, 0 replies; 4+ messages in thread
From: Bryan Wu @ 2008-05-13 8:36 UTC (permalink / raw)
To: Hennerich, Michael; +Cc: Marcel Holtmann, linux-bluetooth, linux-kernel
On Tue, May 13, 2008 at 4:20 PM, Hennerich, Michael
<Michael.Hennerich@analog.com> wrote:
>
>
>
> >-----Original Message-----
> >From: Marcel Holtmann [mailto:marcel@holtmann.org]
> >Sent: Montag, 12. Mai 2008 15:10
> >To: Bryan Wu
> >Cc: linux-bluetooth@vger.kernel.org; linux-kernel@vger.kernel.org;
> Michael
> >Hennerich
> >Subject: Re: [PATCH 1/1] [bluetooth]: fix bug - kernel warning detected
> >ifbuilt in Bluetooth CF driver
> >
> >Hi Brian,
> >
> >> https://blackfin.uclinux.org/gf/project/uclinux-
> >dist/tracker/?action=TrackerItemEdit&tracker_item_id=2650
> >>
> >> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> >> Signed-off-by: Bryan Wu <cooloney@kernel.org>
> >> ---
> >> drivers/bluetooth/bluecard_cs.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/bluetooth/bluecard_cs.c
> >b/drivers/bluetooth/bluecard_cs.c
> >> index bcf5792..3b330a0 100644
> >> --- a/drivers/bluetooth/bluecard_cs.c
> >> +++ b/drivers/bluetooth/bluecard_cs.c
> >> @@ -867,7 +867,7 @@ static int bluecard_probe(struct pcmcia_device
> *link)
> >>
> >> link->io.Attributes1 = IO_DATA_PATH_WIDTH_8;
> >> link->io.NumPorts1 = 8;
> >> - link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
> >> + link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING |
> IRQ_HANDLE_PRESENT;
> >> link->irq.IRQInfo1 = IRQ_LEVEL_ID;
> >>
> >> link->irq.Handler = bluecard_interrupt;
> >
> >all Bluetooth PCMCIA drivers use an exclusive IRQ:
> >
> >bluecard_cs.c: link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
> >IRQ_HANDLE_PRESENT;
> >bt3c_cs.c: link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
> IRQ_HANDLE_PRESENT;
> >btuart_cs.c: link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
> >IRQ_HANDLE_PRESENT;
> >dtl1_cs.c: link->irq.Attributes = IRQ_TYPE_EXCLUSIVE |
> IRQ_HANDLE_PRESENT;
> >
> >There was a reason for that when these drivers where written. I am not
> >sure if it is still valid or not. Does anybody at least have tested
> that
> >the cards still work if you use a shared IRQ.
> >
> >Regards
> >
> >Marcel
>
> Please disregard this patch. It's a leftover and not really necessary.
> Some time ago the Blackfin PCMCIA driver also requested the Card IRQ in
> order to shut up some irq handling noise. However this is no longer the
> case.
>
OK, no problem. I will drop this.
Thanks
-Bryan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-05-13 8:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-12 10:22 [PATCH 1/1] [bluetooth]: fix bug - kernel warning detected if built in Bluetooth CF driver Bryan Wu
2008-05-12 13:10 ` Marcel Holtmann
2008-05-13 8:20 ` [PATCH 1/1] [bluetooth]: fix bug - kernel warning detected ifbuilt " Hennerich, Michael
2008-05-13 8:36 ` Bryan Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox