* [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset
@ 2008-05-12 21:35 Christophe Jaillet
2008-05-12 21:38 ` [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc Joe Perches
2008-05-13 21:46 ` [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset Faisal Latif
0 siblings, 2 replies; 6+ messages in thread
From: Christophe Jaillet @ 2008-05-12 21:35 UTC (permalink / raw)
To: cj, linux, flatif, ngupta, gstreiff, general
From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Hi, here is a patch against linux/drivers/infiniband/hw/nes/nes_cm.c which :
1) Remove an explicit memset(.., 0, ...) to a variable allocated with
kzalloc (i.e. 'listener').
Note: this patch is based on 'linux-2.6.25.tar.bz2'
Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
---
--- linux/drivers/infiniband/hw/nes/nes_cm.c 2008-04-17 04:49:44.000000000 +0200
+++ linux/drivers/infiniband/hw/nes/nes_cm.c.cj 2008-05-12 23:31:24.000000000 +0200
@@ -1587,7 +1587,6 @@ static struct nes_cm_listener *mini_cm_l
return NULL;
}
- memset(listener, 0, sizeof(struct nes_cm_listener));
listener->loc_addr = htonl(cm_info->loc_addr);
listener->loc_port = htons(cm_info->loc_port);
listener->reused_node = 0;
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc
2008-05-12 21:35 [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset Christophe Jaillet
@ 2008-05-12 21:38 ` Joe Perches
2008-05-20 13:53 ` Jan-Bernd Themann
2008-05-22 10:22 ` Jeff Garzik
2008-05-13 21:46 ` [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset Faisal Latif
1 sibling, 2 replies; 6+ messages in thread
From: Joe Perches @ 2008-05-12 21:38 UTC (permalink / raw)
To: Christoph Raisch, Jan-Bernd Themann, Thomas Klein
Cc: linux, netdev, Jeff Garzik, Christophe Jaillet
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/ehea/ehea_main.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
index f9bc21c..fd4be0d 100644
--- a/drivers/net/ehea/ehea_main.c
+++ b/drivers/net/ehea/ehea_main.c
@@ -2207,18 +2207,16 @@ static void ehea_vlan_rx_register(struct net_device *dev,
port->vgrp = grp;
cb1 = kzalloc(PAGE_SIZE, GFP_KERNEL);
if (!cb1) {
ehea_error("no mem for cb1");
goto out;
}
- memset(cb1->vlan_filter, 0, sizeof(cb1->vlan_filter));
-
hret = ehea_h_modify_ehea_port(adapter->handle, port->logical_port_id,
H_PORT_CB1, H_PORT_CB1_ALL, cb1);
if (hret != H_SUCCESS)
ehea_error("modify_ehea_port failed");
kfree(cb1);
out:
return;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset
2008-05-12 21:35 [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset Christophe Jaillet
2008-05-12 21:38 ` [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc Joe Perches
@ 2008-05-13 21:46 ` Faisal Latif
2008-05-14 16:36 ` [ofa-general] " Roland Dreier
1 sibling, 1 reply; 6+ messages in thread
From: Faisal Latif @ 2008-05-13 21:46 UTC (permalink / raw)
To: Christophe Jaillet, linux, Nishi Gupta, Glenn Streiff, general
Cc: Roland Dreier
Acked-by Faisal Latif<faisal@neteffect.com>
Thanks
Faisal
>
> From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
>
> Hi, here is a patch against linux/drivers/infiniband/hw/nes/nes_cm.c
> which :
>
> 1) Remove an explicit memset(.., 0, ...) to a variable allocated with
> kzalloc (i.e. 'listener').
>
>
> Note: this patch is based on 'linux-2.6.25.tar.bz2'
>
> Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
>
> ---
>
> --- linux/drivers/infiniband/hw/nes/nes_cm.c 2008-04-17
> 04:49:44.000000000 +0200
> +++ linux/drivers/infiniband/hw/nes/nes_cm.c.cj 2008-05-12
> 23:31:24.000000000 +0200
> @@ -1587,7 +1587,6 @@ static struct nes_cm_listener *mini_cm_l
> return NULL;
> }
>
> - memset(listener, 0, sizeof(struct nes_cm_listener));
> listener->loc_addr = htonl(cm_info->loc_addr);
> listener->loc_port = htons(cm_info->loc_port);
> listener->reused_node = 0;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ofa-general] RE: [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset
2008-05-13 21:46 ` [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset Faisal Latif
@ 2008-05-14 16:36 ` Roland Dreier
0 siblings, 0 replies; 6+ messages in thread
From: Roland Dreier @ 2008-05-14 16:36 UTC (permalink / raw)
To: Faisal Latif
Cc: Christophe Jaillet, linux, Nishi Gupta, Glenn Streiff, general
thanks guys, applied for 2.6.27
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc
2008-05-12 21:38 ` [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc Joe Perches
@ 2008-05-20 13:53 ` Jan-Bernd Themann
2008-05-22 10:22 ` Jeff Garzik
1 sibling, 0 replies; 6+ messages in thread
From: Jan-Bernd Themann @ 2008-05-20 13:53 UTC (permalink / raw)
To: Joe Perches
Cc: Christoph Raisch, Jan-Bernd Themann, Thomas Klein, linux, netdev,
Jeff Garzik, Christophe Jaillet
On Monday 12 May 2008 23:38, Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
>
> ---
>
> drivers/net/ehea/ehea_main.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
> index f9bc21c..fd4be0d 100644
> --- a/drivers/net/ehea/ehea_main.c
> +++ b/drivers/net/ehea/ehea_main.c
> @@ -2207,18 +2207,16 @@ static void ehea_vlan_rx_register(struct net_device *dev,
> port->vgrp = grp;
>
> cb1 = kzalloc(PAGE_SIZE, GFP_KERNEL);
> if (!cb1) {
> ehea_error("no mem for cb1");
> goto out;
> }
>
> - memset(cb1->vlan_filter, 0, sizeof(cb1->vlan_filter));
> -
> hret = ehea_h_modify_ehea_port(adapter->handle, port->logical_port_id,
> H_PORT_CB1, H_PORT_CB1_ALL, cb1);
> if (hret != H_SUCCESS)
> ehea_error("modify_ehea_port failed");
>
> kfree(cb1);
> out:
> return;
>
The patch looks good.
Acked-by: Jan-Bernd Themann <themann@de.ibm.com>
Thanks,
Jan-Bernd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc
2008-05-12 21:38 ` [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc Joe Perches
2008-05-20 13:53 ` Jan-Bernd Themann
@ 2008-05-22 10:22 ` Jeff Garzik
1 sibling, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2008-05-22 10:22 UTC (permalink / raw)
To: Joe Perches
Cc: Christoph Raisch, Jan-Bernd Themann, Thomas Klein, linux, netdev,
Christophe Jaillet
Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
applied
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-05-22 10:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-12 21:35 [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset Christophe Jaillet
2008-05-12 21:38 ` [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc Joe Perches
2008-05-20 13:53 ` Jan-Bernd Themann
2008-05-22 10:22 ` Jeff Garzik
2008-05-13 21:46 ` [PATCH 1/1] infiniband/hw/nes/: avoid unnecessary memset Faisal Latif
2008-05-14 16:36 ` [ofa-general] " Roland Dreier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox