From: Matt Helsley <matthltc@us.ibm.com>
To: menage@google.com
Cc: pj@sgi.com, xemul@openvz.org, balbir@in.ibm.com,
serue@us.ibm.com, akpm@linux-foundation.org,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH 2/8]: CGroup Files: Add a cgroup write_string control file method
Date: Tue, 13 May 2008 13:44:11 -0700 [thread overview]
Message-ID: <1210711451.21217.55.camel@localhost.localdomain> (raw)
In-Reply-To: <20080513071522.301139000@menage.corp.google.com>
On Mon, 2008-05-12 at 23:37 -0700, menage@google.com wrote:
> plain text document attachment (cgroup_write_string.patch)
> This patch adds a write_string() method for cgroups control files. The
> semantics are that a buffer is copied from userspace to kernelspace
> and the handler function invoked on that buffer. Any control group
> locking is done after the copy from userspace has occurred. The buffer
> is guaranteed to be nul-terminated, and no longer than max_write_len
> (defaulting to 64 bytes if unspecified). Later patches will convert
> existing raw file write handlers in control group subsystems to use
> this method.
>
> Signed-off-by: Paul Menage <menage@google.com>
I haven't looked at this very thoroughly but I think the goal of this
patch is good. Can't this patch and the conversions precede your locking
changes?
Cheers,
-Matt Helsley
next prev parent reply other threads:[~2008-05-13 20:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 6:37 [RFC/PATCH 0/8]: CGroup Files: Clean up locking and boilerplate menage
2008-05-13 6:37 ` [RFC/PATCH 1/8]: CGroup Files: Add locking mode to cgroups control files menage
2008-05-13 9:23 ` Li Zefan
2008-05-13 21:07 ` Paul Menage
2008-05-14 1:30 ` Li Zefan
2008-05-14 1:40 ` Paul Menage
2008-05-13 20:01 ` Andrew Morton
2008-05-13 20:38 ` Matthew Helsley
2008-05-13 20:43 ` Andrew Morton
2008-05-13 21:17 ` Paul Menage
2008-05-13 21:32 ` Andrew Morton
2008-05-13 21:46 ` Paul Menage
2008-05-14 1:59 ` Paul Jackson
2008-05-13 6:37 ` [RFC/PATCH 2/8]: CGroup Files: Add a cgroup write_string control file method menage
2008-05-13 20:07 ` Andrew Morton
2008-05-13 21:01 ` Paul Menage
2008-05-13 20:44 ` Matt Helsley [this message]
2008-05-13 6:37 ` [RFC/PATCH 3/8]: CGroup Files: Move the release_agent file to use typed handlers menage
2008-05-13 20:08 ` Andrew Morton
2008-05-13 21:32 ` Paul Menage
2008-05-13 6:37 ` [RFC/PATCH 4/8]: CGroup Files: Move notify_on_release file to separate write handler menage
2008-05-13 6:37 ` [RFC/PATCH 5/8]: CGroup Files: Turn attach_task_by_pid directly into a cgroup " menage
2008-05-13 6:37 ` [RFC/PATCH 6/8]: CGroup Files: Remove cpuset_common_file_write() menage
2008-05-13 20:11 ` Andrew Morton
2008-05-13 21:27 ` Paul Menage
2008-05-13 6:37 ` [RFC/PATCH 7/8]: CGroup Files: Convert devcgroup_access_write() into a cgroup write_string() handler menage
2008-05-13 6:37 ` [RFC/PATCH 8/8]: CGroup Files: Convert res_counter_write() to be a cgroups " menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210711451.21217.55.camel@localhost.localdomain \
--to=matthltc@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@in.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=pj@sgi.com \
--cc=serue@us.ibm.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox