public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daejun Park <daejun7.park@samsung.com>
To: Bean Huo <huobean@gmail.com>,
	Daejun Park <daejun7.park@samsung.com>,
	ALIM AKHTAR <alim.akhtar@samsung.com>,
	"avri.altman@wdc.com" <avri.altman@wdc.com>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
	"beanhuo@micron.com" <beanhuo@micron.com>,
	"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
	"cang@codeaurora.org" <cang@codeaurora.org>,
	"bvanassche@acm.org" <bvanassche@acm.org>,
	"tomas.winkler@intel.com" <tomas.winkler@intel.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Sang-yoon Oh <sangyoon.oh@samsung.com>,
	Sung-Jun Park <sungjun07.park@samsung.com>,
	yongmyung lee <ymhungry.lee@samsung.com>,
	Jinyoung CHOI <j-young.choi@samsung.com>,
	Adel Choi <adel.choi@samsung.com>,
	BoRam Shin <boram.shin@samsung.com>
Subject: Re: [RFC PATCH v2 2/5] scsi: ufs: Add UFS-feature layer
Date: Tue, 16 Jun 2020 10:18:42 +0900	[thread overview]
Message-ID: <1210830415.21592275802431.JavaMail.epsvc@epcpadp1> (raw)
In-Reply-To: <47dcc56312229fc8f25f39c2beeb3a8ba811f3e9.camel@gmail.com>

Hi, Bean
> 
> On Mon, 2020-06-15 at 16:23 +0900, Daejun Park wrote:
> > +void ufsf_scan_features(struct ufs_hba *hba)
> > +{
> > +       int ret;
> > +
> > +       init_waitqueue_head(&hba->ufsf.sdev_wait);
> > +       atomic_set(&hba->ufsf.slave_conf_cnt, 0);
> > +
> > +       if (hba->dev_info.wspecversion >= HPB_SUPPORTED_VERSION &&
> > +           (hba->dev_info.b_ufs_feature_sup & UFS_DEV_HPB_SUPPORT)) 
> 
> How about removing this check "(hba->dev_info.wspecversion >=
> HPB_SUPPORTED_VERSION" since ufs with lower version than v3.1 can add
> HPB feature by FFU, 
> if (hba->dev_info.b_ufs_feature_sup  &UFS_FEATURE_SUPPORT_HPB_BIT) is
> enough.
OK, changing it seems no problem. But I want to know what other people think
about this version checking code.

Thanks,
Daejun

  reply	other threads:[~2020-06-16  2:50 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200615062708epcms2p19a7fbc051bcd5e843c29dcd58fff4210@epcms2p1>
2020-06-15  6:27 ` [RFC PATCH v2 0/5] scsi: ufs: Add Host Performance Booster Support Daejun Park
2020-06-15  7:21   ` [RFC PATCH v2 1/5] scsi: ufs: Add UFS feature related parameter Daejun Park
2020-06-15  7:23     ` [RFC PATCH v2 2/5] scsi: ufs: Add UFS-feature layer Daejun Park
2020-06-15  9:08       ` [RFC PATCH v2 3/5] scsi: ufs: Introduce HPB module Daejun Park
2020-06-15  9:30         ` [RFC PATCH v2 4/5] scsi: ufs: L2P map management for HPB read Daejun Park
2020-06-15  9:41           ` [RFC PATCH v2 5/5] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
2020-06-15 13:35           ` [RFC PATCH v2 4/5] scsi: ufs: L2P map management for HPB read Bean Huo
2020-06-16  1:17             ` Daejun Park
2020-06-17 11:44           ` Avri Altman
2020-06-18  1:03             ` Daejun Park
2020-06-18  6:12               ` Avri Altman
2020-06-19  0:16                 ` Daejun Park
2020-06-18 10:22           ` Avri Altman
2020-06-19  0:12             ` Daejun Park
2020-06-17  8:07         ` [RFC PATCH v2 3/5] scsi: ufs: Introduce HPB module Avri Altman
2020-06-17 10:30           ` Daejun Park
2020-06-17 18:24             ` Bean Huo
2020-06-18  1:06               ` Daejun Park
2020-06-18  6:19                 ` Avri Altman
2020-06-17 11:31         ` Avri Altman
2020-06-18  0:53           ` Daejun Park
2020-06-15 13:09       ` [RFC PATCH v2 2/5] scsi: ufs: Add UFS-feature layer Bean Huo
2020-06-16  1:18         ` Daejun Park [this message]
2020-06-17  6:55           ` Avri Altman
2020-06-17  8:57             ` Alim Akhtar
2020-06-17  9:41               ` Bean Huo
2020-06-17  9:53                 ` Alim Akhtar
2020-06-17  7:08       ` Avri Altman
2020-06-17 10:09         ` Daejun Park
2020-06-22  4:10   ` [RFC PATCH v2 0/5] scsi: ufs: Add Host Performance Booster Support Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1210830415.21592275802431.JavaMail.epsvc@epcpadp1 \
    --to=daejun7.park@samsung.com \
    --cc=adel.choi@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=boram.shin@samsung.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=huobean@gmail.com \
    --cc=j-young.choi@samsung.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sangyoon.oh@samsung.com \
    --cc=stanley.chu@mediatek.com \
    --cc=sungjun07.park@samsung.com \
    --cc=tomas.winkler@intel.com \
    --cc=ymhungry.lee@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox