From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757963AbYEORUu (ORCPT ); Thu, 15 May 2008 13:20:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756163AbYEORUN (ORCPT ); Thu, 15 May 2008 13:20:13 -0400 Received: from hellhawk.shadowen.org ([80.68.90.175]:3245 "EHLO hellhawk.shadowen.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756109AbYEORUL (ORCPT ); Thu, 15 May 2008 13:20:11 -0400 From: Andy Whitcroft To: linux-mm@kvack.org Cc: Andrew Morton , Christoph Lameter , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Rik van Riel , Jeremy Fitzhardinge , linux-kernel@vger.kernel.org Subject: [PATCH 3/3] slob: record page flag overlays explicitly References: InReply-To: Date: Thu, 15 May 2008 18:20:10 +0100 Message-Id: <1210872010.0@pinky> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SLOB reuses two page bits for internal purposes, it overlays PG_active and PG_private. This is hidden away in slob.c. Document these overlays explicitly in the main page-flags enum along with all the others. Signed-off-by: Andy Whitcroft --- include/linux/page-flags.h | 4 ++++ mm/slob.c | 12 ++++++------ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index 2e88df6..71aec98 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h @@ -104,6 +104,10 @@ enum pageflags { /* XEN */ PG_pinned = PG_owner_priv_1, + /* SLOB */ + PG_slob_page = PG_active, + PG_slob_free = PG_private, + /* SLUB */ PG_slub_frozen = PG_active, PG_slub_debug = PG_error, diff --git a/mm/slob.c b/mm/slob.c index 6038cba..9bc3147 100644 --- a/mm/slob.c +++ b/mm/slob.c @@ -130,17 +130,17 @@ static LIST_HEAD(free_slob_large); */ static inline int slob_page(struct slob_page *sp) { - return test_bit(PG_active, &sp->flags); + return test_bit(PG_slob_page, &sp->flags); } static inline void set_slob_page(struct slob_page *sp) { - __set_bit(PG_active, &sp->flags); + __set_bit(PG_slob_page, &sp->flags); } static inline void clear_slob_page(struct slob_page *sp) { - __clear_bit(PG_active, &sp->flags); + __clear_bit(PG_slob_free, &sp->flags); } /* @@ -148,19 +148,19 @@ static inline void clear_slob_page(struct slob_page *sp) */ static inline int slob_page_free(struct slob_page *sp) { - return test_bit(PG_private, &sp->flags); + return test_bit(PG_slob_free, &sp->flags); } static void set_slob_page_free(struct slob_page *sp, struct list_head *list) { list_add(&sp->list, list); - __set_bit(PG_private, &sp->flags); + __set_bit(PG_slob_free, &sp->flags); } static inline void clear_slob_page_free(struct slob_page *sp) { list_del(&sp->list); - __clear_bit(PG_private, &sp->flags); + __clear_bit(PG_slob_free, &sp->flags); } #define SLOB_UNIT sizeof(slob_t)