From: Johannes Berg <johannes@sipsolutions.net>
To: Sebastian Siewior <lkml@ml.breakpoint.cc>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: make michael_block a function
Date: Fri, 16 May 2008 10:10:05 +0200 [thread overview]
Message-ID: <1210925405.4000.3.camel@johannes.berg> (raw)
In-Reply-To: <20080516070157.GA9769@Chamillionaire.breakpoint.cc>
[-- Attachment #1: Type: text/plain, Size: 639 bytes --]
On Fri, 2008-05-16 at 09:01 +0200, Sebastian Siewior wrote:
> * Harvey Harrison | 2008-05-15 23:17:17 [-0700]:
>
> >Make the michael_block macro a function and change the calling
> >function to take a struct michael_mic_ctx * and the value for
> >the initial xor with ctx->l.
> >
> >Also open-code xswap in its one use in michael_block.
> Does this change have any performance impact?
> The only user is wireless (I guess). Is it used frequently (sign every
> packet for instance) or once in a while (in every re-keying)?
Every packet. I have no idea whether it has performance impact, very
hard to even guess.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2008-05-16 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 6:17 [PATCH] crypto: make michael_block a function Harvey Harrison
2008-05-16 7:01 ` Sebastian Siewior
2008-05-16 8:10 ` Johannes Berg [this message]
2008-05-16 15:52 ` Harvey Harrison
2008-05-18 21:57 ` Sebastian Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210925405.4000.3.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=harvey.harrison@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@ml.breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox