From: "Henrique de Moraes Holschuh" <hmh@hmh.eng.br>
To: "Jan Lieskovsky" <jlieskov@redhat.com>,
"Cyrill Gorcunov" <gorcunov@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Len Brown" <len.brown@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: thinkpad_acpi: fix possible NULL pointer dereference if kstrdup for ec_version_str failed
Date: Fri, 16 May 2008 12:54:41 -0300 [thread overview]
Message-ID: <1210953281.30902.1253547403@webmail.messagingengine.com> (raw)
In-Reply-To: <1210930449.3812.15.camel@dhcp-lab-164.englab.brq.redhat.com>
On Fri, 16 May 2008 11:34:09 +0200, "Jan Lieskovsky" <jlieskov@redhat.com> said:
> There is a potential NULL pointer dereference in
> thinkpad_acpi_module_exit() -- in case,
> kstrdup for thinkpad_id.ec_version_str failed.
One can kfree(NULL) without problems. Is there any other unprotected access to ec_version_str that I failed to see?
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
prev parent reply other threads:[~2008-05-16 15:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 9:34 thinkpad_acpi: fix possible NULL pointer dereference if kstrdup for ec_version_str failed Jan Lieskovsky
2008-05-16 15:54 ` Henrique de Moraes Holschuh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210953281.30902.1253547403@webmail.messagingengine.com \
--to=hmh@hmh.eng.br \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@gmail.com \
--cc=jlieskov@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox