From: Harvey Harrison <harvey.harrison@gmail.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: mchehab@infradead.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH] dvb-usb: unaligned
Date: Tue, 20 May 2008 17:42:46 -0700 [thread overview]
Message-ID: <1211330566.5915.230.camel@brick> (raw)
In-Reply-To: <E1JycGL-0004x6-SF@ZenIV.linux.org.uk>
On Wed, 2008-05-21 at 01:33 +0100, Al Viro wrote:
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> drivers/media/dvb/dvb-usb/dvb-usb-firmware.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c b/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
> index e1112e3..733a7ff 100644
> --- a/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
> +++ b/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
> @@ -127,7 +127,7 @@ int dvb_usb_get_hexline(const struct firmware *fw, struct hexline *hx,
> if ((*pos + hx->len + 4) >= fw->size)
> return -EINVAL;
>
> - hx->addr = le16_to_cpu( *((u16 *) &b[1]) );
> + hx->addr = b[1] | (b[2] << 8);
hx->addr = get_unaligned_le16(&b[1]);
Cheers,
Harvey
next prev parent reply other threads:[~2008-05-21 0:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 0:33 [PATCH] dvb-usb: unaligned Al Viro
2008-05-21 0:42 ` Harvey Harrison [this message]
2008-05-21 0:47 ` Al Viro
2008-05-21 0:53 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1211330566.5915.230.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox