* [PATCH] dvb-usb: unaligned
@ 2008-05-21 0:33 Al Viro
2008-05-21 0:42 ` Harvey Harrison
0 siblings, 1 reply; 4+ messages in thread
From: Al Viro @ 2008-05-21 0:33 UTC (permalink / raw)
To: mchehab; +Cc: linux-kernel, torvalds
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
drivers/media/dvb/dvb-usb/dvb-usb-firmware.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c b/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
index e1112e3..733a7ff 100644
--- a/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
+++ b/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
@@ -127,7 +127,7 @@ int dvb_usb_get_hexline(const struct firmware *fw, struct hexline *hx,
if ((*pos + hx->len + 4) >= fw->size)
return -EINVAL;
- hx->addr = le16_to_cpu( *((u16 *) &b[1]) );
+ hx->addr = b[1] | (b[2] << 8);
hx->type = b[3];
if (hx->type == 0x04) {
--
1.5.3.GIT
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dvb-usb: unaligned
2008-05-21 0:33 [PATCH] dvb-usb: unaligned Al Viro
@ 2008-05-21 0:42 ` Harvey Harrison
2008-05-21 0:47 ` Al Viro
0 siblings, 1 reply; 4+ messages in thread
From: Harvey Harrison @ 2008-05-21 0:42 UTC (permalink / raw)
To: Al Viro; +Cc: mchehab, linux-kernel, torvalds
On Wed, 2008-05-21 at 01:33 +0100, Al Viro wrote:
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> drivers/media/dvb/dvb-usb/dvb-usb-firmware.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c b/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
> index e1112e3..733a7ff 100644
> --- a/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
> +++ b/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
> @@ -127,7 +127,7 @@ int dvb_usb_get_hexline(const struct firmware *fw, struct hexline *hx,
> if ((*pos + hx->len + 4) >= fw->size)
> return -EINVAL;
>
> - hx->addr = le16_to_cpu( *((u16 *) &b[1]) );
> + hx->addr = b[1] | (b[2] << 8);
hx->addr = get_unaligned_le16(&b[1]);
Cheers,
Harvey
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dvb-usb: unaligned
2008-05-21 0:42 ` Harvey Harrison
@ 2008-05-21 0:47 ` Al Viro
2008-05-21 0:53 ` Harvey Harrison
0 siblings, 1 reply; 4+ messages in thread
From: Al Viro @ 2008-05-21 0:47 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Al Viro, mchehab, linux-kernel, torvalds
On Tue, May 20, 2008 at 05:42:46PM -0700, Harvey Harrison wrote:
> On Wed, 2008-05-21 at 01:33 +0100, Al Viro wrote:
> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> > ---
> > drivers/media/dvb/dvb-usb/dvb-usb-firmware.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c b/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
> > index e1112e3..733a7ff 100644
> > --- a/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
> > +++ b/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
> > @@ -127,7 +127,7 @@ int dvb_usb_get_hexline(const struct firmware *fw, struct hexline *hx,
> > if ((*pos + hx->len + 4) >= fw->size)
> > return -EINVAL;
> >
> > - hx->addr = le16_to_cpu( *((u16 *) &b[1]) );
> > + hx->addr = b[1] | (b[2] << 8);
>
> ???hx->addr = get_unaligned_le16(&b[1]);
Again, what's the benefit? Having a function doesn't mean that we need
to use it religiously - if it doesn't make things more clear...
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dvb-usb: unaligned
2008-05-21 0:47 ` Al Viro
@ 2008-05-21 0:53 ` Harvey Harrison
0 siblings, 0 replies; 4+ messages in thread
From: Harvey Harrison @ 2008-05-21 0:53 UTC (permalink / raw)
To: Al Viro; +Cc: Al Viro, mchehab, linux-kernel, torvalds
On Wed, 2008-05-21 at 01:47 +0100, Al Viro wrote:
> On Tue, May 20, 2008 at 05:42:46PM -0700, Harvey Harrison wrote:
> > On Wed, 2008-05-21 at 01:33 +0100, Al Viro wrote:
> > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> > > ---
> > > drivers/media/dvb/dvb-usb/dvb-usb-firmware.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c b/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
> > > index e1112e3..733a7ff 100644
> > > --- a/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
> > > +++ b/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
> > > @@ -127,7 +127,7 @@ int dvb_usb_get_hexline(const struct firmware *fw, struct hexline *hx,
> > > if ((*pos + hx->len + 4) >= fw->size)
> > > return -EINVAL;
> > >
> > > - hx->addr = le16_to_cpu( *((u16 *) &b[1]) );
> > > + hx->addr = b[1] | (b[2] << 8);
> >
> > ???hx->addr = get_unaligned_le16(&b[1]);
>
> Again, what's the benefit? Having a function doesn't mean that we need
> to use it religiously - if it doesn't make things more clear...
Just curious, is gcc smart enough to just turn this into a 2-byte load
on x86 (little-endian with no particular alignment constraints).
Otherwise it would have a better chance at doing this using the helper
function.
You're right though, it is a small consideration.
Harvey
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-05-21 0:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-21 0:33 [PATCH] dvb-usb: unaligned Al Viro
2008-05-21 0:42 ` Harvey Harrison
2008-05-21 0:47 ` Al Viro
2008-05-21 0:53 ` Harvey Harrison
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox