From: Harvey Harrison <harvey.harrison@gmail.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Al Viro <viro@ftp.linux.org.uk>,
mchehab@infradead.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH] dvb-usb: unaligned
Date: Tue, 20 May 2008 17:53:23 -0700 [thread overview]
Message-ID: <1211331203.5915.244.camel@brick> (raw)
In-Reply-To: <20080521004717.GE28946@ZenIV.linux.org.uk>
On Wed, 2008-05-21 at 01:47 +0100, Al Viro wrote:
> On Tue, May 20, 2008 at 05:42:46PM -0700, Harvey Harrison wrote:
> > On Wed, 2008-05-21 at 01:33 +0100, Al Viro wrote:
> > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> > > ---
> > > drivers/media/dvb/dvb-usb/dvb-usb-firmware.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c b/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
> > > index e1112e3..733a7ff 100644
> > > --- a/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
> > > +++ b/drivers/media/dvb/dvb-usb/dvb-usb-firmware.c
> > > @@ -127,7 +127,7 @@ int dvb_usb_get_hexline(const struct firmware *fw, struct hexline *hx,
> > > if ((*pos + hx->len + 4) >= fw->size)
> > > return -EINVAL;
> > >
> > > - hx->addr = le16_to_cpu( *((u16 *) &b[1]) );
> > > + hx->addr = b[1] | (b[2] << 8);
> >
> > ???hx->addr = get_unaligned_le16(&b[1]);
>
> Again, what's the benefit? Having a function doesn't mean that we need
> to use it religiously - if it doesn't make things more clear...
Just curious, is gcc smart enough to just turn this into a 2-byte load
on x86 (little-endian with no particular alignment constraints).
Otherwise it would have a better chance at doing this using the helper
function.
You're right though, it is a small consideration.
Harvey
prev parent reply other threads:[~2008-05-21 0:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 0:33 [PATCH] dvb-usb: unaligned Al Viro
2008-05-21 0:42 ` Harvey Harrison
2008-05-21 0:47 ` Al Viro
2008-05-21 0:53 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1211331203.5915.244.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox