public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Louis Rilling <Louis.Rilling@kerlabs.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
	Joel Becker <Joel.Becker@oracle.com>,
	linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: Re: [RFC][PATCH 0/3] configfs: Make nested default groups	lockdep-friendly
Date: Wed, 21 May 2008 12:59:37 +0200	[thread overview]
Message-ID: <1211367577.6463.91.camel@lappy.programming.kicks-ass.net> (raw)
In-Reply-To: <4833F89F.7080707@kerlabs.com>

On Wed, 2008-05-21 at 12:25 +0200, Louis Rilling wrote:

> > http://programming.kicks-ass.net/kernel-patches/concurrent-pagecache/23-rc1-rt/radix-concurrent-lockdep.patch
> 
> Thanks for pointing this out.
> 
> Yes this could solve part of the issue, at the price of duplicating the
> inode mutex class. However, this still does not solve the issue when
> deleting config_groups, since in that case all nodes of the tree are
> locked. Thinking about adding lockdep support for concurrent locking of
> the direct children of a node in a tree...

Why doesn't sysfs have this problem? - the code says configfs was
derived from sysfs.

Also, do you really need to hold all locks when removing something?
sound like a bit overdone. Also realise there is a maximum number of
held locks - various people have already requested it to be increased or
made dynamic. We're reluctant in doing so because we feel lock chains
should not be of unlimited length. The deeper the chains the bigger the
PI overhead etc..

As to modifying lockdep - it currently doesn't know about trees and
teaching it about them isn't easy.


  reply	other threads:[~2008-05-21 11:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-20 16:33 [RFC][PATCH 0/3] configfs: Make nested default groups lockdep-friendly Louis Rilling
2008-05-20 16:33 ` [RFC][PATCH 1/3] configfs: set CONFIGFS_USET_DEFAULT earlier in configfs_attach_group() Louis Rilling
2008-05-20 16:33 ` [RFC][PATCH 2/3] configfs: Silence lockdep when creating nested default groups Louis Rilling
2008-05-20 16:33 ` [RFC][PATCH 3/3] configfs: Silence lockdep when destroying " Louis Rilling
2008-05-20 16:58 ` [RFC][PATCH 0/3] configfs: Make nested default groups lockdep-friendly Arjan van de Ven
2008-05-20 17:08   ` Louis Rilling
2008-05-20 21:56   ` Joel Becker
2008-05-20 22:13     ` Arjan van de Ven
2008-05-20 22:27       ` Joel Becker
2008-05-20 22:35         ` Arjan van de Ven
2008-05-20 23:51           ` Joel Becker
2008-05-21  9:20             ` Peter Zijlstra
2008-05-21  9:23       ` Peter Zijlstra
2008-05-21 10:25         ` Louis Rilling
2008-05-21 10:59           ` Peter Zijlstra [this message]
2008-05-21 12:54             ` Louis Rilling
2008-05-21 22:09             ` Joel Becker
2008-05-21  8:13     ` Louis Rilling
2008-05-20 21:41 ` [Ocfs2-devel] " Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1211367577.6463.91.camel@lappy.programming.kicks-ass.net \
    --to=a.p.zijlstra@chello.nl \
    --cc=Joel.Becker@oracle.com \
    --cc=Louis.Rilling@kerlabs.com \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox