Re: [Re: Linux 2.6.26-rc2] Write protect on on

Matthew Wilcox
2008-05-19T18:16:54Z

On Mon, May 19, 2008 at 10:27:17AM -0700, Linus Torvalds wrote:
> On Mon, 19 May 2008, Boaz Harrosh wrote:
> >
> > Sure, inspecting other places that emulate MODE_SENSE, (And inspecting the scsi
> > spec) all zeros is a very good scsi response. Alan do you want to send a fix for all
> > places that initiate a MODE_SENSE command, specifically at
> > scsi_scan.c::scsi_unlock_floptical() ? (Some other places do)
>
> I was actualyl more thinking that the safest thing to do would be to just
> pre-clear the sense buffer. Then, if some driver doesn't fill it
> correctly, big deal..
>
> It's not like pre-clearing the bugger is a performance issue.

Actually, I think it might be. I don't have any hard evidence for this
right now, but I'll let you know if I do. There's certainly a lot of L2
cache misses in the scsi command submission path.

I'm not arguing that speed should trump performance, just we might
want to not clear the sense buffer if we know we have a non-USB device.

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."