Re: [Re: Linux 2.6.26-rc2] Write protect on on

Boaz Harrosh
2008-05-19T17:46:05Z

Linus Torvalds wrote:
>
> On Mon, 19 May 2008, Boaz Harrosh wrote:
>> Sure, inspecting other places that emulate MODE_SENSE, (And inspecting the scsi
>> spec) all zeros is a very good scsi response. Alan do you want to send a fix for all
>> places that initiate a MODE_SENSE command, specifically at
>> scsi_scan.c::scsi_unlock_floptical() ? (Some other places do)
>
> I was actualyl more thinking that the safest thing to do would be to just
> pre-clear the sense buffer. Then, if some driver doesn't fill it
> correctly, big deal..

The sense buffer *is* always cleared and it is mandated by scsi spec.
But the problem above is that the actual data buffer for read, had
garbage data, and *no* read was actually preformed do to none-standard
device response.

>
> It's not like pre-clearing the bugger is a performance issue.
>
> Linus
> --

Boaz