Re: Early SPECWeb99 results on 2.5.33 with TSO on e1000

Jeff Garzik
2002-09-16T23:44:13Z

David S. Miller wrote:
> From: Jeff Garzik <jgarzik@mandrakesoft.com>
> Date: Mon, 16 Sep 2002 19:08:15 -0400
>
> I was rather disappointed when file->file sendfile was [purposefully?]
> broken in 2.5.x...
>
> What change made this happen?

I dunno when it happened, but 2.5.x now returns EINVAL for all
file->file cases.

In 2.4.x, if sendpage is NULL, file_send_actor in mm/filemap.c faked a
call to fops->write().
In 2.5.x, if sendpage is NULL, EINVAL is unconditionally returned.