Re: [PATCH] [POWERPC] Improve (in|out)_beXX() asm code

Trent Piepho
2008-05-20T23:01:25Z

On Tue, 20 May 2008, Scott Wood wrote:
> Alan Cox wrote:
>> > It looks like we rely on -fno-strict-aliasing to prevent reordering
>> > ordinary memory accesses (such as to DMA descriptors) past the I/O
>>
>> DMA descriptors in main memory are dependant on cache behaviour anyway
>> and the dma_* operators should be the ones enforcing the needed behaviour.
>
> What about memory obtained from dma_alloc_coherent()? We still need a sync
> and a compiler barrier. The current I/O accessors have the former, but not
> the latter.

There doesn't appear to be any barriers to use for coherent dma other than
mb() and wmb().

Correct me if I'm wrong, but I think the sync isn't actually _required_ (by
memory-barriers.txt's definitions), and it would be enough to use eieio,
except there is code that doesn't use mmiowb() between I/O access and
unlocking.

So, as I understand it, the minimum needed is eieio. To provide strict
ordering w.r.t. spin locks without using mmiowb(), you need sync. To provide
strict ordering w.r.t. normal memory, you need sync and a compiler barrier.

Right now no archs provide the last option. powerpc is currently the middle
option. I don't know if anything uses the first option, maybe alpha? I'm
almost certain x86 is the middle option (the first isn't possible, the arch
already has more ordering than that), which is probably why powerpc used that
option and not the first.