Re: [fixed] [patch] Re: [bug] stuck localhost TCP connections, v2.6.26-rc3+

Ilpo Järvinen
2008-06-04T20:56:52Z

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1021 bytes --]

On Wed, 4 Jun 2008, David Miller wrote:

> From: Ingo Molnar <mingo@elte.hu>
> Date: Wed, 4 Jun 2008 09:23:11 +0200
>
> > * Ilpo Järvinen <ilpo.jarvinen@helsinki.fi> wrote:
> >
> > > ...I couldn't immediately find anything obviously wrong with those
> > > changes but the patch below might be worth of a try (without the
> > > revert of course). If it ever spits out that WARN_ON for you, we were
> > > playing with fire too much and it's better to return on the safe side
> > > there...
> >
> > i'll queue it up for testing, but no promises about speedy action here -
> > the test cycle is really long with this bug.
>
> Ilpo posted another patch which fixes a locking bug in the
> code, please test with that patch. I include it below so
> that you know exactly which one I am referring to.

Do you know if TCP ever needs to lock the child sk again (after creating
it and it has started to live on its own) from a context that has already
locked the listen_sk (it could deadlock after this change)?

--
i.